Repository navigation
Run the tests of the CI scripts on pull requests that change them - #117
Merged
Merged
Conversation
This was referenced Nov 13, 2026
jwrosewell
marked this pull request as ready for review
November 14, 2026 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The scripts in
ci/decide what a pull request builds and what a publish releases, and each has Pester tests beside it.rcholds five such files, beingci/packages.Tests.ps1,ci/dispatch.Tests.ps1,ci/check-environment-variable-names.Tests.ps1,ci/get-next-package-version.Tests.ps1from #54 andci/select-options.Tests.ps1from #33. Only the environment variable name tests ran in a workflow. The rest ran only by hand or on a temporary branch, as #47, #54 and #60 each say under what remains, so a change to the release plan or the dispatcher could break them unseen.What changed
.github/workflows/ci-script-tests.ymlis new. On a pull request or a push tomainorrcthat changesci/or the workflow, it checks out this repository and common-ci'smainbeside it, which is whereci/dispatch.Tests.ps1looks for common-ci and, after #47, whereci/packages.ps1finds the shared release plan, and runs everyci/*.Tests.ps1with Pester onubuntu-latestandwindows-latest. It can also be started by hand.Checks
The workflow ran on this pull request at head 3cd797c1, which is the earlier head 343ed03 with
rcat 32ffdcf1 merged in, as run 43520274370, and passed on both,Tests Passed: 168, Failed: 0onubuntu-latestand onwindows-latest, being every test in the five files above. At the earlier head, beforercheld #54 and #33, run 43483333111 passed the three filesrchad then, 130 tests. The other checks passed on this head, being run 43520274430 (environment variable names), run 43520274906 (only rc into main) and run 43520274329 (link campaign tags).This draft adds a workflow and changes no package code. James Rosewell decided at about 11:35 UTC on 12 November, for a change only to CI, "rebuild and include, but the change doesn't impact the code so no need to run the full builds."
What remains
Nothing. Once this is on
rc, the CI script drafts above are tested by it on their own pull requests.The last release into
mainwas #114, merged at 06:22 UTC on 13 November.