Skip to content

Do not refresh again when the watcher sees a file the update service wrote itself #170

Open

Description

@jwrosewell

When update_from_memory or a polled update writes a data file kept on disk, last_changed_time is not moved. So with the file system watcher on, its next pass (track_local_data_file_changes in pipeline/fiftyone_pipeline_engines/src/fiftyone_pipeline_engines/datafile_update_service.py) sees the new time, refreshes the engine a second time and reports that to the update complete callbacks, which an update from memory must not do (data-updates.md lines 372 to 376 at 706de1f0).

Done when the service moves last_changed_time to the time of the file it wrote, and a test with the watcher on shows one refresh and no report after an update from memory.

Found by #169.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions