Repository navigation
Remove the old workflows from the package directories - #87
Merged
Merged
Conversation
Each package directory still held the workflows of its old repository. They never run here, and on the mirrors they land at the repository root, where they ran as live workflows until they were disabled by hand. The next push of main deletes them from the mirrors too.
jwrosewell
marked this pull request as ready for review
November 13, 2026 23:06
This was referenced Nov 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
Problem
Each package directory still holds the workflows of the repository it came from, 49 files under eight
.github/workflowsfolders (device-detection/cloud,device-detection/onpremise,ip-intelligence,location,pipeline/cloudrequestengine,pipeline/core,pipeline/didandpipeline/engines). GitHub runs only the workflows at the root of a repository, so they never run here. On the mirrors that Packagist reads,mirror.ymlputs each package directory at the root, so there they ran as live workflows, and all 21 on the mirrors were disabled by hand on 4 November 2026 after the UTM link lint failed there, as #33 says.What changed
.github/workflowsfolders are deleted. Every package directory held only workflows under.github, so each.githubfolder goes with them. The root workflows are untouched..github/workflows/mirror.ymlno longer says that every package keeps its old workflows. The mirror token still needs Workflows write, because the push that deletes them from the mirrors changes files under.github/workflows.The next push of
mainruns the Branch job ofmirror.yml, which splits each directory and pushes it to its mirror'smain, so the deletions reach the mirrors then. No release tag is needed for that.Releases
Nothing in this change is package code. Under #37 each package's
Ignorelist inci/packages.jsonleaves out<path>/.github/workflows/**, so this change releases no package. Once both are merged thoseIgnoreentries match nothing, and they can stay, so that a workflow added to a package directory by mistake still releases nothing.Checks
CI only, so it merges on green quick checks and an independent review with no full build, under the 12 November decision for changes that touch only CI scripts and their notes.
The quick checks on head f593d21 passed, being the environment variable names check (run 43476788705), only rc into main (run 43476789224) and the UTM link lint (run 43476788664). A search of the branch finds no
.githubfolder under any package directory, and the root.github/workflowsis unchanged apart from the comment inmirror.yml.