Repository navigation
Run the cloud 51Did tests on pull requests into rc as well as main - #100
Merged
Merged
Conversation
jwrosewell
marked this pull request as ready for review
November 14, 2026 04:39
This was referenced Nov 14, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Cloud 51Did workflow runs the live 51Did tests on a pull request only when it targets
main(.github/workflows/cloud-51did.ymllines 32 and 33 at 758fea81). Changes reachmainthroughrc, so a change to the 51Did package is first tested against the live cloud service when the release pull request fromrcopens, after it has been reviewed and merged intorc.#88, #77 and #70 each changed
pipeline/fiftyone.pipeline.didand merged intorcwith only the "Only rc into main" and UTM link checks. Every pull request run of the workflow in the last two days came fromrc, the release pull request, for example run 43368094724.What changed
branches: [main]becomesbranches: [main, rc]in the workflow'spull_requesttrigger. The paths are unchanged, so only a pull request that changes the 51Did package or this workflow runs the live tests. The secrets reach a pull request from a branch in this repository and not one from a fork, as the workflow's header says.Checks
This draft changes the workflow itself and targets
rc, so the workflow running on it is the proof. On head aec4bc5e the Cloud 51Did workflow ran on this pull request intorc(run 43553950651, job 132322448611) and passed, 5 of 5 tests with_51DEGREES_RESOURCE_KEY_51DID, 5 of 5 with_51DEGREES_RESOURCE_KEY_BESPOKE, and 3 of 3 in the tier test. The UTM link lint (run 43553950630) and Only rc into main (run 43553950892) are green.This draft changes one workflow file and no package code. James Rosewell's decision of 11:35 UTC on 12 November for such changes is "rebuild and include, but the change doesn't impact the code so no need to run the full builds", so it merges on green quick checks and a review, with no full build of its own.
What remains
Nothing. This closes the gap DX-node-21, recorded under "What remains" in #27.