Repository navigation
Describe the rc approach to releases in AGENTS.md - #39
Merged
Merged
Conversation
jwrosewell
marked this pull request as ready for review
November 4, 2026 08:32
Merged
jwrosewell
added a commit
that referenced
this pull request
Nov 4, 2026
Releases what has collected on `rc` since #30: - [#37](#37) Use the data repository for the examples, tests and CI - [#41](#41) Say in AGENTS.md how to get the data, build and run the examples - [#42](#42) Point package metadata at this repository and fix stale links - [#39](#39) Describe the rc approach to releases in AGENTS.md - [#40](#40) Check the callback URL before the JavaScript builder writes it - [#44](#44) Close every FlowData, Pipeline and metadata collection, and fail the build when one is left open ## Release note From [#44](#44): - `ComponentMetaData.getProperties()`, `ProfileMetaData.getValues()`, `ProfileMetaData.getValues(String)` and `FiftyOneAspectPropertyMetaData.getValues()` now declare `CloseableIterable` rather than `Iterable`, which is what the on-premise engines have always returned. Close the collection, for example in a try-with-resources statement, so that it releases the engine's data set straight away. Source that assigns the result to an `Iterable` still compiles. Code compiled against the old declared types needs recompiling, and a class that implements one of these interfaces needs its method to declare `CloseableIterable`, so this is a small breaking change. The release stays a patch release. - `PipelineBuilder.buildFromConfiguration` now closes the elements it has already built when building fails. - The servlet filter and the Spring interceptor now close the request's FlowData on every path. ## Notes The cxx submodule moves from [4.5.102](https://github.com/51Degrees/51degrees-cxx/releases/tag/4.5.102) to [4.5.103](https://github.com/51Degrees/51degrees-cxx/releases/tag/4.5.103). That release adds the [data](https://github.com/51Degrees/data) repository at `cxx/data` and changes nothing under `src/`. No commit asks for a major or minor version change, so the publish moves only patch numbers. The last release into `main` was #30, merged at 06:35 UTC on 4 November 2026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.mdnow says how changes reach a release here, so anyone working in the repository, an assistant included, follows thercapproach:rc, notmain,rcthat is not a draft and has no review requested (get-pull-requests.ps1andget-target-branch.ps1in common-ci),rcintomainwhen a release is wanted, and the "Only rc into main" check, now required onmain, fails a pull request intomainfrom any other branch.The organisation-wide contributing guide in 51Degrees/.github#8 says the same for contributors, and the full steps are in the common-ci contributing guide.