Skip to content

Build the package trees on JDK 25, the runner's default #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jwrosewell wants to merge 3 commits into
base: rc
Choose a base branch
from
Draft

Build the package trees on JDK 25, the runner's default #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a347d10
Build the package trees with maven-pmd-plugin 3.28.0
jwrosewell Nov 14, 2026
866d517
Leave the dangling doc comment check out of pipeline.did on JDK 23 an…
jwrosewell Nov 14, 2026
50331fb
Remove a doc comment attached to nothing from EvidenceKeyFilterShareU…
jwrosewell Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion device-detection/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<maven-site-plugin.version>3.7.1</maven-site-plugin.version>
<dependency-check-maven.version>6.5.3</dependency-check-maven.version>
<central-publishing-maven-plugin.version>0.7.0</central-publishing-maven-plugin.version>
<maven-pmd-plugin.version>3.26.0</maven-pmd-plugin.version>
<maven-pmd-plugin.version>3.28.0</maven-pmd-plugin.version>

<skippackagesign>true</skippackagesign>
<skipPublishing>false</skipPublishing>
Expand Down
2 changes: 1 addition & 1 deletion ip-intelligence/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<org.json.version>20211205</org.json.version>

<maven-compiler-plugin.version>3.9.0</maven-compiler-plugin.version>
<maven-pmd-plugin.version>3.26.0</maven-pmd-plugin.version>
<maven-pmd-plugin.version>3.28.0</maven-pmd-plugin.version>
<exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
<maven-install-plugin.version>2.5.2</maven-install-plugin.version>
<maven-jar-plugin.version>3.2.2</maven-jar-plugin.version>
Expand Down
2 changes: 1 addition & 1 deletion location/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<maven-jarsigner-plugin.version>3.0.0</maven-jarsigner-plugin.version>
<maven-gpg-plugin.version>3.0.1</maven-gpg-plugin.version>
<central-publishing-maven-plugin.version>0.7.0</central-publishing-maven-plugin.version>
<maven-pmd-plugin.version>3.26.0</maven-pmd-plugin.version>
<maven-pmd-plugin.version>3.28.0</maven-pmd-plugin.version>

<skippackagesign>true</skippackagesign>
<skipPublishing>false</skipPublishing>
Expand Down
26 changes: 26 additions & 0 deletions pipeline/pipeline.did/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,4 +153,30 @@
</plugins>
</build>

<profiles>
<!-- javac 23 and later warn about a documentation comment that is
attached to nothing, and the OWID source compiled in has one, so
-Werror would fail the build. Those JDKs leave that one check out
here. Earlier JDKs do not know the check's name. -->
<profile>
<id>owid-dangling-doc-comments</id>
<activation>
<jdk>[23,)</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<compilerArgs combine.children="append">
<arg>-Xlint:-dangling-doc-comments</arg>
</compilerArgs>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>

</project>
5 changes: 0 additions & 5 deletions ...c/test/java/fiftyone/pipeline/engines/fiftyone/data/EvidenceKeyFilterShareUsageTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@ private static EvidenceKeyFilterShareUsage defaults() {
false);
}

/**
* By default headers other than Cookie are shared, cookies, session
* values and query string parameters only when their names start with
* 51D_, and any other evidence.
*/
/**
* The whole web request is read by the Usage Sharing Element and never
* shared as a value, so the filter does not include it.
Expand Down
2 changes: 1 addition & 1 deletion pipeline/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
<maven-project-info-reports-plugin.version>2.6</maven-project-info-reports-plugin.version>
<maven-site-plugin.version>3.7</maven-site-plugin.version>
<central-publishing-maven-plugin.version>0.7.0</central-publishing-maven-plugin.version>
<maven-pmd-plugin.version>3.26.0</maven-pmd-plugin.version>
<maven-pmd-plugin.version>3.28.0</maven-pmd-plugin.version>

<skippackagesign>true</skippackagesign>
<skipPublishing>false</skipPublishing>
Expand Down
Loading