Skip to content

Log the rest of the data update Errors table as the specification gives it #150

Open

Description

@jwrosewell

51degrees-java#129 logs every HTTP failure of the data file download as its row of the Errors table. What is still different, at DataUpdateServiceDefault.java on rc 6e03a25f, is the following.

  1. The integrity check failure is logged at Warning with a retry note (line 1020), where the table gives Error and "Integrity check failed. MD5 hash in HTTP response ...".
  2. The other Error rows log their message directly, rather than as "Error during check for data update" with an error attached that carries the row's message.
  3. A programmatic check and the update on start-up log a failure, where the specification says they pass it to the caller.
  4. The body is decompressed while it is read (line 1003), so a body that is not gzip, or is corrupt, is reported as an access failure with AUTO_UPDATE_HTTPS_ERR (already so on rc, and with Log a data update download cut short, and every other HTTP failure, as the specification's Errors table rows #129 logged as "Error accessing data update service"). .NET decompresses after the download (DataUpdateService.cs line 1150 at 8b3220b3) and reports the "Any other error" row with AUTO_UPDATE_UNKNOWN_ERROR (lines 886 to 888).
  5. AUTO_UPDATE_NO_CONFIGURATION, AUTO_UPDATE_TEMP_PATH_NOT_SET and AUTO_UPDATE_UNKNOWN_ERROR do not exist in DataUpdateService.java, and a watched file that is not newer does not return AUTO_UPDATE_NOT_NEEDED.

Test each row first, red then green.

Found in the review of 51degrees-java#129.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions