Repository navigation
Add unit tests for audit logging and sinks, enhance config validation - #77
Merged
Merged
Conversation
- Introduced comprehensive unit tests for auditing changes in `test_audit_changes.py`, covering successful and failed operations across various services. - Added tests for custom audit sinks and publisher behavior in `test_audit_sinks.py`, ensuring proper event handling and error counting. - Enhanced configuration validation in `test_config_editor.py` to include audit section checks and error handling for unknown keys. - Implemented JSON log format tests in `test_json_logs.py`, verifying structure and context in log entries. - Updated store router tests in `test_store_router.py` to use `MagicMock` for memory ID responses, improving test reliability.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_audit_changes.py, covering successful and failed operations across various services.test_audit_sinks.py, ensuring proper event handling and error counting.test_config_editor.pyto include audit section checks and error handling for unknown keys.test_json_logs.py, verifying structure and context in log entries.test_store_router.pyto useMagicMockfor memory ID responses, improving test reliability.