Honor required request options in native Studio - #245
Merged
0xShug0 merged 1 commit intoAug 15, 2026
Merged
Conversation
JoeMattie
marked this pull request as ready for review
August 15, 2026 03:59
Owner
|
@JoeMattie Merged, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
MiniMax Music3 declares lyrics as required and rejects empty lyrics at runtime, but Studio labeled lyrics optional and omitted the field when blank. That made prompt-only submissions fail at the server. Studio now uses model-spec metadata as the source of truth, which also honors GLM-TTS's required reference transcript.
Port notes
This ports the applicable review fix from
717fadeonto the implementation merged by #243. The other findings are already satisfied or no longer present on this branch: it uses a portablekTwoPi, retains runtimes whenmem_saver=false, publishes a valid 32 MiB weight-context default withmin: 1, and uses the file-basedaudiocpp_ggufconverter instead of a raw stdio helper.Validation
npm run checknpm run buildcmake --build build/linux-cuda-release --target engine_model_minimax_music3 --parallel 4python3 tools/check_loader_catalog_sync.py --self-testpython3 tools/check_loader_catalog_sync.py