diff --git a/docs/development/setup-assistant-review.mdx b/docs/development/setup-assistant-review.mdx index 629cc098a..a8d06d773 100644 --- a/docs/development/setup-assistant-review.mdx +++ b/docs/development/setup-assistant-review.mdx @@ -222,3 +222,23 @@ Isolated GitHub Variable probes confirmed blank values are rejected and the native empty-list format round-trips and cleans up; no Secret/shared value was written. New pure planning policies have an executable 100% coverage budget. The existing setup acceptance ledger's unrelated open items remain explicit. + + +## Remaining platform observations — #982 + +The [six-case platform packet](../../quality/bugbot/evidence/issue-982/README.md) +records the frozen source/package identities and exact procedures for I039-I042 +and X023/X026. It contains no new platform pass; the acceptance ledger remains +336/350 with all fourteen previous gaps open. Preparing or validating the packet +adds zero automated acceptance cases and does not replace a named observation. + +Use the corresponding actual self-hosted Linux/Windows desktop for packaged +launch, pairing and browser-open fallback. For the two filesystem rows use the +actual Windows service identity, retain the native assertion results and keep +Windows service jobs without the codex label. EPERM/skipped symlink cases stay +open; do not grant privileges, remove capability skips or use another OS to +manufacture evidence. Record runner/job/source/CLI/OS/browser identities and +failures. The current macOS session and automated smoke HTTP assertions cannot +supply the missing desktop or Windows-service observations. No platform workflow +was dispatched from this preparation. These six Setup rows remain separate from +Linux Bugbot qualification. diff --git a/quality/bugbot/evidence/issue-982/README.md b/quality/bugbot/evidence/issue-982/README.md new file mode 100644 index 000000000..1c62d5ee7 --- /dev/null +++ b/quality/bugbot/evidence/issue-982/README.md @@ -0,0 +1,85 @@ +# Six real platform observations — #982 + +No case is passed by this packet. The historical acceptance ledger is unchanged: +I039/I040 require a real Linux desktop; I041/I042 require a real Windows desktop; +X023/X026 require the named actual Windows service account and file-symlink +capability. This current session is macOS. Linux CI activity does not establish +Linux desktop access, and a repository runner list does not establish organization +capacity. Organization runner-policy inspection returned HTTP 403. + +The exact source/package/CLI/UI identity is in manifest.json, also recorded by the +independent #981 review packet (PR #994). This packet contains its own identities; +#981 is not a prerequisite for these platform observations. +Use a disposable fixture only, no real repository or credentials. Keep Windows +service jobs off the codex label; do not grant privileges or alter runner policy +as part of an observation. Never enable enforcement or publish a release. + +## Required evidence + +Record actual reviewer/date, self-hosted runner identity/group/job URL, OS/version, +Node/CLI/package/source hashes, browser/version for desktop cases, Windows service +principal/session and actual file-symlink capability for X023/X026. Keep a terminal +trace and direct browser observation of URL/pairing/fallback. Use the existing +fixture-only protocol in scripts/smoke-packaged-web-session.cjs as the safe boundary: +it strips credentials, starts a disposable local Git fixture, deliberately +suppresses the browser opener, pairs only on loopback, cancels before confirming +the repository or submitting a credential, and verifies that the fixture checkout +is unchanged. The automated smoke closes its session; its HTTP assertions alone +are supplementary and do not supply the required human desktop observation. + +A reviewer-assisted interactive execution must keep that same isolation and stop +before repository confirmation or real credential entry. Do not run copilot setup +against a live checkout. Do not expose the loopback server on an external address. +Capture actual normal launch and actual opener failure/fallback separately. + +## Windows service symlink checks + +Use the exact ccefb source on the actual reviewed self-hosted Windows service +runner (self-hosted, Windows; no codex label). Record its native identity and +privilege result without changing privileges. Run the two existing production +server assertions with Node 24 and the frozen lockfile: + + pnpm exec jest src/cli/__tests__/web_setup_server.test.ts --runInBand --json --outputFile=platform-symlink-results.json --testNamePattern="an asset replaced by an escaping symlink is not served|startup refuses an index symlink outside the asset root" + +Inspect the two exact JSON assertion rows. Both must be passed, executed on +Windows under the stated service identity. A skipped/pending assertion caused by +EPERM is unavailable evidence; record that result and leave its ledger row open. +Two passes on macOS/Linux are not substitutes. Do not remove capability-based +skips or loosen the server containment boundary to manufacture an observation. +The fixture creates and removes only its own local files; no model/provider/GitHub +write adapter is needed. Keep raw failures, skips and available capability details. + +The broad setup_platform_smoke.yml also includes companion native verification +and repository/extension suites. Do not dispatch it blindly as proof of these six +cases: its complete effects must first be reviewed, and automated package checks +still cannot replace the four human desktop observations. A queued job is not an +execution result. No platform-observation workflow has been dispatched for #982 in this task. +The ordinary issue/PR delivery Actions are separate from these observations. + +After actual evidence arrives, update only its corresponding existing ledger rows, +preserve the previous unavailable observations, and run validate:setup-acceptance +and the applicable specification/docs validators. Partial focused Jest output is +not a repository-wide acceptance pass. All six rows remain open pending evidence. + + +## Budget and actual result + +The budget is exactly the six existing observations: four direct desktop/package +journeys and two existing Windows-service filesystem assertions. There are zero +new automated acceptance cases and zero claimed executions of these six rows. +The blank fields are a review template, not evidence. No named corresponding +reviewer/environment has been supplied to this session. Keep all six cases open; +do not infer that organization runners or desktops are absent merely from an +inaccessible policy endpoint. The platform/environment request is still pending. + +After an actual observation, retain its raw result, identity and any failed/skipped +attempt, then reconcile only its corresponding existing ledger row. Existing +336/350 acceptance with 14 open cases is unchanged by preparing these instructions. +Run `pnpm run validate:setup-acceptance`, documentation and applicable specification +validators. A focused Jest run cannot establish complete repository acceptance. +No runner label, privilege, consumer installation template, model invocation, +production verification setting or default workflow is changed by this packet. + +Preparation validation passes: unchanged acceptance ledger 336/350 with 14 open, documentation and specification contracts, and Graphify. These checks provide no new desktop or Windows-service observation. + +The initial mandatory hook passed 942 suites but a worker received SIGSEGV before the unchanged complete-conversation prompt suite started. Its exact log/metadata are retained. That suite passes independently (6/6 in one process); the complete mandatory hook is retried without altering tests or assertions. These delivery tests supply none of the six platform observations. diff --git a/quality/bugbot/evidence/issue-982/acceptance-unchanged.log.gz b/quality/bugbot/evidence/issue-982/acceptance-unchanged.log.gz new file mode 100644 index 000000000..93528144b Binary files /dev/null and b/quality/bugbot/evidence/issue-982/acceptance-unchanged.log.gz differ diff --git a/quality/bugbot/evidence/issue-982/documentation-pass.log.gz b/quality/bugbot/evidence/issue-982/documentation-pass.log.gz new file mode 100644 index 000000000..2335da887 Binary files /dev/null and b/quality/bugbot/evidence/issue-982/documentation-pass.log.gz differ diff --git a/quality/bugbot/evidence/issue-982/hook-worker-failure.json b/quality/bugbot/evidence/issue-982/hook-worker-failure.json new file mode 100644 index 000000000..b74e36f07 --- /dev/null +++ b/quality/bugbot/evidence/issue-982/hook-worker-failure.json @@ -0,0 +1,12 @@ +{ + "outcome": "failed", + "stage": "mandatory pre-commit Jest", + "suitesPassed": 942, + "suiteFailedToStart": "src/prompts/__tests__/bugbot_complete_conversation.test.ts", + "signal": "SIGSEGV", + "testsPassed": 18689, + "testsSkipped": 35, + "rawSha256": "2e9cc621a52ff61bc74e2c81cb5103d91b455c176d2dcd7dc53cdb3ced5b7e30", + "rawBytes": 532863, + "observationCasesExecuted": 0 +} diff --git a/quality/bugbot/evidence/issue-982/hook-worker-failure.log.gz b/quality/bugbot/evidence/issue-982/hook-worker-failure.log.gz new file mode 100644 index 000000000..ef4ccfaa5 Binary files /dev/null and b/quality/bugbot/evidence/issue-982/hook-worker-failure.log.gz differ diff --git a/quality/bugbot/evidence/issue-982/hook-worker-recheck.log.gz b/quality/bugbot/evidence/issue-982/hook-worker-recheck.log.gz new file mode 100644 index 000000000..6f496e732 Binary files /dev/null and b/quality/bugbot/evidence/issue-982/hook-worker-recheck.log.gz differ diff --git a/quality/bugbot/evidence/issue-982/manifest.json b/quality/bugbot/evidence/issue-982/manifest.json new file mode 100644 index 000000000..90d135ba8 --- /dev/null +++ b/quality/bugbot/evidence/issue-982/manifest.json @@ -0,0 +1,21 @@ +{ + "purpose": "six real Linux/Windows desktop and Windows-service symlink observations; no observations claimed", + "sourceCommit": "ccefb27627cd627ccdb7d5666fd174c2ac1da07b", + "sourceArchiveSha256": "c8e82a9051b9c531d8f306134bafd9a5adf94f49a2980a6b76dc07e3383920d8", + "packageVersion": "3.10.13", + "package": "vypdev-copilot-3.10.13.tgz", + "packageSha256": "abeac2c108ed9b663bef80317f38eefbd14eed35502a32952f9d418f045f0d88", + "packScriptsExecuted": false, + "cliSha256": "35ef7d099c2c7b31faed2276ac535cd2c018ad61ad1a1be23b91370acaf6286e", + "fixtureScriptSha256": "203ef1cf80c70057f379586d9a8229e6a5a055a56f4e415c95bce16624229963", + "node": "v24.20.0", + "host": "Darwin", + "borrowedFixtureDependencies": "exact installed dependencies from isolated #979 worktree; not a measured qualification runtime", + "webAssets": { + "build/web/assets/index-CNXf8Vmj.js": "e839491cd0736213063845961a39557b4f1d5d0bd182cd0a69150d009c947c8f", + "build/web/assets/index-CfyclPC5.css": "a6eddae87eaeb35e0548caaa356ae94d231806b9605f6331b9ec77bf4dacb1e6", + "build/web/index.html": "6ed7b55e202c589061e558de8abe775cc119bb13853174781bf60fd4cea827e1" + }, + "realProviderPorts": 0, + "status": "not-executed" +} diff --git a/quality/bugbot/evidence/issue-982/observation-template.json b/quality/bugbot/evidence/issue-982/observation-template.json new file mode 100644 index 000000000..72de1dcfe --- /dev/null +++ b/quality/bugbot/evidence/issue-982/observation-template.json @@ -0,0 +1,92 @@ +[ + { + "case": "I039", + "platform": "Linux", + "requirement": "packaged launch and pairing on an actual desktop", + "status": "not-observed", + "reviewer": null, + "date": null, + "runner": null, + "servicePrincipalAndSession": null, + "osVersion": null, + "browserVersion": null, + "sourceAndPackageSha256": null, + "actualResult": null, + "artifactOrRun": null + }, + { + "case": "I040", + "platform": "Linux", + "requirement": "actual browser opener fallback on an actual desktop", + "status": "not-observed", + "reviewer": null, + "date": null, + "runner": null, + "servicePrincipalAndSession": null, + "osVersion": null, + "browserVersion": null, + "sourceAndPackageSha256": null, + "actualResult": null, + "artifactOrRun": null + }, + { + "case": "I041", + "platform": "Windows", + "requirement": "packaged launch and pairing on an actual desktop", + "status": "not-observed", + "reviewer": null, + "date": null, + "runner": null, + "servicePrincipalAndSession": null, + "osVersion": null, + "browserVersion": null, + "sourceAndPackageSha256": null, + "actualResult": null, + "artifactOrRun": null + }, + { + "case": "I042", + "platform": "Windows", + "requirement": "actual browser opener fallback on an actual desktop", + "status": "not-observed", + "reviewer": null, + "date": null, + "runner": null, + "servicePrincipalAndSession": null, + "osVersion": null, + "browserVersion": null, + "sourceAndPackageSha256": null, + "actualResult": null, + "artifactOrRun": null + }, + { + "case": "X023", + "platform": "Windows service without codex label", + "requirement": "escaping asset symlink is refused", + "status": "not-observed", + "reviewer": null, + "date": null, + "runner": null, + "servicePrincipalAndSession": null, + "osVersion": null, + "browserVersion": null, + "sourceAndPackageSha256": null, + "actualResult": null, + "artifactOrRun": null + }, + { + "case": "X026", + "platform": "Windows service without codex label", + "requirement": "startup refuses out-of-root index symlink", + "status": "not-observed", + "reviewer": null, + "date": null, + "runner": null, + "servicePrincipalAndSession": null, + "osVersion": null, + "browserVersion": null, + "sourceAndPackageSha256": null, + "actualResult": null, + "artifactOrRun": null + } +]