From 4823a85a491b8bdd14cd1afd09668ce5531156e2 Mon Sep 17 00:00:00 2001 From: "Benedicto Franco Jr." Date: Fri, 6 Nov 2026 11:39:08 -0800 Subject: [PATCH] ci: put vcpkg's protoc on PATH for the Windows test legs Every test that compiles a schema skipped on Windows with "protoc not available": 67 of 152 on main. vcpkg installs protoc under tools\protobuf, and only bin was on PATH. Fixes #43 --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 376eccb..6cf583e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -105,9 +105,10 @@ jobs: PROTOWIRE_CPP_DIR: ${{ github.workspace }}\protowire-cpp-checkout # editable installs don't bundle DLLs — _protowire.pyd resolves # libprotobuf.dll / libabsl_*.dll out of vcpkg's bin dir at - # import time. Put it on PATH for the pytest run. + # import time. Put it on PATH for the pytest run, and vcpkg's + # protoc too: the tests that compile a schema skip without it (#43). run: | - $env:PATH = "$env:VCPKG_INSTALLATION_ROOT\installed\x64-windows\bin;$env:PATH" + $env:PATH = "$env:VCPKG_INSTALLATION_ROOT\installed\x64-windows\bin;$env:VCPKG_INSTALLATION_ROOT\installed\x64-windows\tools\protobuf;$env:PATH" pytest -v # ---------------------------------------------------------------------