From b098459572545829e72626d3118a2bd23566d5a2 Mon Sep 17 00:00:00 2001 From: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com> Date: Fri, 30 Oct 2026 20:33:15 +0100 Subject: [PATCH] fix: Remove the connection limit from the native transport --- .../DockerHandlerFactory.cs | 3 -- .../ISystemOperations.Tests.cs | 29 +++++++++++++++++++ 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/src/Docker.DotNet.NativeHttp/DockerHandlerFactory.cs b/src/Docker.DotNet.NativeHttp/DockerHandlerFactory.cs index 29cf1869..7af58de9 100644 --- a/src/Docker.DotNet.NativeHttp/DockerHandlerFactory.cs +++ b/src/Docker.DotNet.NativeHttp/DockerHandlerFactory.cs @@ -2,8 +2,6 @@ namespace Docker.DotNet.NativeHttp; public sealed class DockerHandlerFactory : IDockerHandlerFactory { - private const int MaxConnectionsPerServer = 10; - private static readonly TimeSpan PooledConnectionLifetime = TimeSpan.FromMinutes(5); private static readonly TimeSpan PooledConnectionIdleTimeout = TimeSpan.FromMinutes(2); @@ -35,7 +33,6 @@ public ResolvedTransport CreateHandler(NativeHttpTransportOptions transportOptio #if NET var handler = new SocketsHttpHandler { - MaxConnectionsPerServer = MaxConnectionsPerServer, PooledConnectionLifetime = PooledConnectionLifetime, PooledConnectionIdleTimeout = PooledConnectionIdleTimeout, }; diff --git a/test/Docker.DotNet.Tests/ISystemOperations.Tests.cs b/test/Docker.DotNet.Tests/ISystemOperations.Tests.cs index d2fb43e0..700e47a5 100644 --- a/test/Docker.DotNet.Tests/ISystemOperations.Tests.cs +++ b/test/Docker.DotNet.Tests/ISystemOperations.Tests.cs @@ -26,6 +26,35 @@ public async Task GetVersionAsync_Succeeds() Assert.NotNull(version.APIVersion); } + [Fact] + public async Task GetVersionAsync_ManyEventStreamsOpen_Succeeds() + { + using var cts = CancellationTokenSource.CreateLinkedTokenSource(_testFixture.Cts.Token); + + // Each event stream holds its connection until it is cancelled. + var monitorTasks = Enumerable.Range(0, 16) + .Select(_ => _testFixture.DockerClient.System.MonitorEventsAsync(new ContainerEventsParameters(), new Progress(), cts.Token)) + .ToArray(); + + try + { + using var timeoutCts = CancellationTokenSource.CreateLinkedTokenSource(_testFixture.Cts.Token); + timeoutCts.CancelAfter(TimeSpan.FromSeconds(10)); + + var version = await _testFixture.DockerClient.System.GetVersionAsync(timeoutCts.Token); + Assert.NotNull(version.APIVersion); + } + finally + { + await cts.CancelAsync(); + } + + foreach (var monitorTask in monitorTasks) + { + await Assert.ThrowsAnyAsync(() => monitorTask); + } + } + [Fact] public async Task MonitorEventsAsync_EmptyContainersList_CanBeCancelled() {