Skip to content

[PHP 8.4 Compatibility] Unable to compile the Spinupwp binary #63

Description

@adampatterson

Current Outcome

When using PHP 8.4, php spinupwp app:build spinupwp deletes the root directory spinupwp file, and then replaces box.json with an empty file.

Desired Outcome

Build the binary.

Steps to Reproduce

  1. php -v confirm PHP 8.4 in the CLI
  2. php spinupwp app:build spinupwp
php spinupwp app:build spinupwp --build-version=1.2.0
                                               
                Building process                
                                                
   1. Moving application to production mode: ✔
   2. Compile into a single file: ✔

   ErrorException 

  rename(/spinupwp-cli/spinupwp.phar,/spinupwp-cli/builds/spinupwp): No such file or directory

  at vendor/illuminate/filesystem/Filesystem.php:315
    311▕      * @return bool
    312▕      */
    313▕     public function move($path, $target)
    314▕     {
  ➜ 315▕         return rename($path, $target);
    316▕     }
    317▕ 
    318▕     /**
    319▕      * Copy a file to a new location.

      +20 vendor frames 
  21  spinupwp:35
      LaravelZero\Framework\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

Related

#59

Acceptance Criteria

I'm unable to build the CLI using PHP 8.4, but that's related to Laravel Zero 9 dependency.

A decision should be made around the minim PHP version supported by SpinupWP.

The CLI currently uses Laravel Zero 9 which supports PHP 8.0-8.2 and are are end of life.

Modern Laravel Zero supports PHP 8.2+ and while I don't know if upgrading to version 12 and hopefully will resolve issues with PHP 8.4.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: BugFixes broken functionality that prevents something from being achieved.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions