Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Knative Service invocation should use status.url instead of Istio IP #2

Description

@bbrowning

Knative Services should be invoked via the Service's status.url property instead of setting a host header and directly trying to hit the Istio ingress gateway. Not all Knative installations use Istio. Not all of the ones that do expose Istio directly to the internet via a LoadBalancer IP. Nor do all the ones that use Istio use the same service name and namespace as the hardcoded assumptions in the serverless-components/knative-serving repo.

Some Knative installations are not properly configured and the status.url of the Knative Service doesn't actually work. But, for properly configured ones, assuming you can directly talk to Istio is not a valid assumption.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions