From d8a9984f9b86dd56382cc68e45c107728f8147ad Mon Sep 17 00:00:00 2001 From: Ryuz Date: Thu, 19 Nov 2026 13:30:10 +0100 Subject: [PATCH 1/5] Pin Cello 0.2.0 and follow the cello spellings - CELLO_VERSION=0.2.0 with the release digest; lineage comment rewritten. - celld-config -> cello-config (pipeline comment, agent docs; plugin renamed in outer-templates). - stale_celld_names test -> stale_tenant_names; WIPE verify line reworded. - check-pins.sh now guards the Cello tag+digest pin shape. - Remaining celld hits are only the CELLD_ tenant reservation and celld.dev doc URLs. --- crates/outer/src/config.rs | 2 +- crates/outer/src/deploy/pipeline.rs | 2 +- deploy/WIPE.md | 2 +- docker/Dockerfile | 9 ++++----- scripts/check-pins.sh | 25 ++++++++++++++++++++++++- web/docs/agents/frontend/website.md | 2 +- 6 files changed, 32 insertions(+), 10 deletions(-) diff --git a/crates/outer/src/config.rs b/crates/outer/src/config.rs index f5b58ee..5cb43a0 100644 --- a/crates/outer/src/config.rs +++ b/crates/outer/src/config.rs @@ -1622,7 +1622,7 @@ mod tests { } #[test] - fn stale_celld_names_are_ignored_after_the_wipe() { + fn stale_tenant_names_are_ignored_after_the_wipe() { // No rename shims: a carried-over `CELLD_*` or `OUTER_CELLD_BIN` // is dead config, not a refusal. (The runtime still refuses to // start a fleet with `CELLD_*` set; that reservation lives in diff --git a/crates/outer/src/deploy/pipeline.rs b/crates/outer/src/deploy/pipeline.rs index bb44d40..da1d9f3 100644 --- a/crates/outer/src/deploy/pipeline.rs +++ b/crates/outer/src/deploy/pipeline.rs @@ -3526,7 +3526,7 @@ mod tests { } #[test] fn astro_website_config_passes_key_validation() { - // The shape the website template's `celld-config` integration derives + // The shape the website template's `cello-config` integration derives // into `dist/wrangler.json` from the Cloudflare adapter's // `dist/server/wrangler.json` (verbatim from a real `bun run build`): // `main` rewrites to `server/…`, assets to `client`, `vars` to `{}`. diff --git a/deploy/WIPE.md b/deploy/WIPE.md index 535a7fd..2689727 100644 --- a/deploy/WIPE.md +++ b/deploy/WIPE.md @@ -91,7 +91,7 @@ Kept untouched: 7. Verify empty: - `/health` + `/ready` (200 once the fresh DB and bucket answer; the first snapshot writes a fresh `owner.json` claim under `outer/state/`). - - `docs` tool lists `cello`, not `celld`; `outer check-config` clean. + - `docs` tool lists the `cello` spellings throughout; `outer check-config` clean. - Create one scratch app, deploy, `GET /.well-known/cello/health` (synthetic, no wake), stop the fleet, delete the app (exercises the `fleets/`, `git/`, `outer/backups/`, `outer/exports/` delete paths), diff --git a/docker/Dockerfile b/docker/Dockerfile index 2b899bc..4504017 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -8,13 +8,12 @@ # # outer terminates TLS itself (rustls) on OUTER_LISTEN: the Cloudflare # Origin CA certificate plus Authenticated Origin Pulls (mTLS). -# cello is the renamed celld continuation (ryuzcorp/cello): the same code -# and formats as celld `0.6.3-ryuzcorp.13`, new names, published as semver -# with SLSA provenance attestations. The two ARG lines below are the +# cello (ryuzcorp/cello): the runtime each app fleet runs, published as +# semver with SLSA provenance attestations. The two ARG lines below are the # single source of the pin: a bump changes these values (the tag, then the # digest from the release's publish summary). -ARG CELLO_VERSION=0.1.0 -ARG CELLO_DIGEST=sha256:3d6943b69b2201f8980f73178d3530c4b7f558c2bcb3cbb99badbc67deb87689 +ARG CELLO_VERSION=0.2.0 +ARG CELLO_DIGEST=sha256:d0aaa5492d376139c62a0dcd6bd5717ff21f5ab1921ec48b434738cbb0b98d95 ARG CELLO_IMAGE=ghcr.io/ryuzcorp/cello:${CELLO_VERSION}@${CELLO_DIGEST} ARG ESBUILD_VERSION=0.28.2 # Pinned formatter for agent commits. Keep in step with the template's diff --git a/scripts/check-pins.sh b/scripts/check-pins.sh index 2b03197..c2f4a84 100755 --- a/scripts/check-pins.sh +++ b/scripts/check-pins.sh @@ -3,7 +3,9 @@ # - every workflow action is pinned to a full commit SHA (a moved tag can # change what CI runs without a commit here); # - the release image builds with the same Rust as rust-toolchain.toml -# (a floating `stable` broke clippy on every PR on 2026-11-14). +# (a floating `stable` broke clippy on every PR on 2026-11-14); +# - the Cello runtime is pinned by tag + digest (a floating tag would +# change what the release image runs without a commit here). set -eu cd "$(dirname "$0")/.." @@ -23,4 +25,25 @@ if [ -z "$channel" ] || [ "$channel" != "$image" ]; then status=1 fi +# - the Cello runtime is pinned by tag + digest, and the image ref is built +# from exactly those two values (a floating tag would change what the +# release image runs without a commit here). +version=$(sed -n 's/^ARG CELLO_VERSION=\(.*\)$/\1/p' docker/Dockerfile) +digest=$(sed -n 's/^ARG CELLO_DIGEST=\(.*\)$/\1/p' docker/Dockerfile) +imageref=$(sed -n 's|^ARG CELLO_IMAGE=\(.*\)$|\1|p' docker/Dockerfile) +case "$version" in + [0-9]*.[0-9]*.[0-9]*) ;; + *) echo "docker/Dockerfile CELLO_VERSION '$version' is not a semver pin" >&2; status=1 ;; +esac +case "$digest" in + sha256:????????????????????????????????????????????????????????????????) ;; + *) echo "docker/Dockerfile CELLO_DIGEST '$digest' is not a sha256 pin" >&2; status=1 ;; +esac +# The Dockerfile holds the unexpanded form literally. +# shellcheck disable=SC2016 +if [ "$imageref" != 'ghcr.io/ryuzcorp/cello:${CELLO_VERSION}@${CELLO_DIGEST}' ]; then + echo "docker/Dockerfile CELLO_IMAGE '$imageref' is not built from the pinned version and digest" >&2 + status=1 +fi + exit "$status" diff --git a/web/docs/agents/frontend/website.md b/web/docs/agents/frontend/website.md index b17701f..403d2fd 100644 --- a/web/docs/agents/frontend/website.md +++ b/web/docs/agents/frontend/website.md @@ -44,7 +44,7 @@ export const POST: APIRoute = async () => { ## Ship config and schema the Cello way -1. Edit `astro.config.mjs` (`celld-config` integration), never hand-write `dist/wrangler.json`. +1. Edit `astro.config.mjs` (`cello-config` integration), never hand-write `dist/wrangler.json`. 2. Read derived keys from `dist/wrangler.json` after `bun run build`. 3. Commit migration files under `db/migrations/`; never edit an applied migration. 4. Keep the route's `CREATE TABLE IF NOT EXISTS` as a local-dev backstop matching the migration. From 869d45e93d456782f9243cd5c37a4470a869dfce Mon Sep 17 00:00:00 2001 From: Ryuz Date: Thu, 19 Nov 2026 13:30:24 +0100 Subject: [PATCH 2/5] Fix two load-dependent test flakes - agent_action_commit_logged_with_redacted_summary: pin INLINE_WAIT so the dispatch-time action rows are terminal; under parallel load the fake deploy outlasted the 200 ms test tool_wait and the row kept the in-progress building outcome. - failed_wake_is_a_503_with_retry_after: hold the silent listener instead of bind-and-drop, so no other test's fake fleet can grab the freed port and answer the wake probe (503 -> 200). --- crates/outer/src/http/proxy.rs | 16 ++++++++-------- crates/outer/src/mcp/tests.rs | 7 ++++++- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/crates/outer/src/http/proxy.rs b/crates/outer/src/http/proxy.rs index 6f9806e..a85e203 100644 --- a/crates/outer/src/http/proxy.rs +++ b/crates/outer/src/http/proxy.rs @@ -3354,14 +3354,14 @@ mod tests { #[tokio::test] async fn failed_wake_is_a_503_with_retry_after() { let fix = fixture().await; - // A closed loopback port: nothing answers, and the binary does not - // exist, so the wake fails without touching the network. - let closed = tokio::net::TcpListener::bind("127.0.0.1:0") - .await - .unwrap() - .local_addr() - .unwrap() - .port(); + // A held-but-silent loopback listener, and a binary that does not + // exist, so the wake fails without touching the network. Holding + // the socket (rather than binding and dropping it) keeps the port + // out of the ephemeral pool: under parallel load another test's + // fake fleet could otherwise bind the freed port and answer the + // wake probe, flaking the expected 503 into a proxied 200. + let _held = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap(); + let closed = _held.local_addr().unwrap().port(); insert_app(&fix.pool, "app-down", "down", closed, "public").await; let state = ProxyState::new( fix.pool.clone(), diff --git a/crates/outer/src/mcp/tests.rs b/crates/outer/src/mcp/tests.rs index ced1476..2f7daa3 100644 --- a/crates/outer/src/mcp/tests.rs +++ b/crates/outer/src/mcp/tests.rs @@ -2379,7 +2379,12 @@ async fn action_rows(state: &McpState, slug: &str) -> Vec Date: Thu, 19 Nov 2026 13:44:08 +0100 Subject: [PATCH 3/5] templates: pin outer-templates #9 (cello-config plugin) --- crates/outer/src/templates.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/outer/src/templates.rs b/crates/outer/src/templates.rs index e85a415..e7b1767 100644 --- a/crates/outer/src/templates.rs +++ b/crates/outer/src/templates.rs @@ -21,7 +21,7 @@ use crate::store::Store; pub const TEMPLATES_URL: &str = "https://github.com/ryuzcorp/outer-templates"; /// The pinned commit `outer templates sync` vendors. Repinning is a /// one-line change, then `outer templates sync`. -pub const TEMPLATES_SHA: &str = "dee7c8197a0ef489ab95141e4886c5caebf1c15f"; +pub const TEMPLATES_SHA: &str = "23573d7e34b0a26dfb909bfe0ec88913e69c53a1"; /// The store pointer to the vendored bundle. const CURRENT_KEY: &str = "outer/templates/current.json"; From 6fe2d4dc53c62ae21c77050522a306c81f38f6fe Mon Sep 17 00:00:00 2001 From: Ryuz Date: Thu, 19 Nov 2026 13:46:09 +0100 Subject: [PATCH 4/5] check-pins: require 64 lowercase hex in the Cello digest Security review on #151: the ? glob accepted any characters. --- scripts/check-pins.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/check-pins.sh b/scripts/check-pins.sh index c2f4a84..e36efaa 100755 --- a/scripts/check-pins.sh +++ b/scripts/check-pins.sh @@ -35,10 +35,11 @@ case "$version" in [0-9]*.[0-9]*.[0-9]*) ;; *) echo "docker/Dockerfile CELLO_VERSION '$version' is not a semver pin" >&2; status=1 ;; esac -case "$digest" in - sha256:????????????????????????????????????????????????????????????????) ;; - *) echo "docker/Dockerfile CELLO_DIGEST '$digest' is not a sha256 pin" >&2; status=1 ;; -esac +# Exactly 64 lowercase hex after the prefix (a `?` glob would accept any byte). +if ! printf '%s\n' "$digest" | grep -Eq '^sha256:[0-9a-f]{64}$'; then + echo "docker/Dockerfile CELLO_DIGEST '$digest' is not a sha256 pin" >&2 + status=1 +fi # The Dockerfile holds the unexpanded form literally. # shellcheck disable=SC2016 if [ "$imageref" != 'ghcr.io/ryuzcorp/cello:${CELLO_VERSION}@${CELLO_DIGEST}' ]; then From 1e22c6f032472fa70bdf5b9eec4490b52d79bc2a Mon Sep 17 00:00:00 2001 From: Ryuz Date: Thu, 19 Nov 2026 14:27:42 +0100 Subject: [PATCH 5/5] check-pins: anchor the Cello version check --- scripts/check-pins.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/check-pins.sh b/scripts/check-pins.sh index e36efaa..7405318 100755 --- a/scripts/check-pins.sh +++ b/scripts/check-pins.sh @@ -31,11 +31,11 @@ fi version=$(sed -n 's/^ARG CELLO_VERSION=\(.*\)$/\1/p' docker/Dockerfile) digest=$(sed -n 's/^ARG CELLO_DIGEST=\(.*\)$/\1/p' docker/Dockerfile) imageref=$(sed -n 's|^ARG CELLO_IMAGE=\(.*\)$|\1|p' docker/Dockerfile) -case "$version" in - [0-9]*.[0-9]*.[0-9]*) ;; - *) echo "docker/Dockerfile CELLO_VERSION '$version' is not a semver pin" >&2; status=1 ;; -esac -# Exactly 64 lowercase hex after the prefix (a `?` glob would accept any byte). +# Anchored regexes: a shell glob's `*` would accept any trailing bytes. +if ! printf '%s\n' "$version" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.-]+)?$'; then + echo "docker/Dockerfile CELLO_VERSION '$version' is not a semver pin" >&2 + status=1 +fi if ! printf '%s\n' "$digest" | grep -Eq '^sha256:[0-9a-f]{64}$'; then echo "docker/Dockerfile CELLO_DIGEST '$digest' is not a sha256 pin" >&2 status=1