Greetings!
I'm very glad that the scraper crate has support for serde crate through an optional feature flag (i.e: serde), which can be opted-in through the cargo add scraper --features serde command. However, I noticed that the trait implementations for the serde::Serialize and serde::Deserialize were missing on scraper::selectors::CssLocalName struct. I thought it has been implemented and provided by default.
Since the scraper crate didn't provide the required implementations, I implemented it all by myself for my own use-case scenario. Unfortunately, it is such a hassle to implement the necessary traits all over again across multiple projects. It's better if the scraper crate can provide the necessary implementations of serde::Deserialize and serde::Serialize traits in the first place. Even though the benefits are small, it is a one-step forward that propels better serde integration on this project.
I hope the developers of this project accepts my feature request. Thank you for reading!
Greetings!
I'm very glad that the
scrapercrate has support forserdecrate through an optional feature flag (i.e:serde), which can be opted-in through thecargo add scraper --features serdecommand. However, I noticed that the trait implementations for theserde::Serializeandserde::Deserializewere missing onscraper::selectors::CssLocalNamestruct. I thought it has been implemented and provided by default.Since the
scrapercrate didn't provide the required implementations, I implemented it all by myself for my own use-case scenario. Unfortunately, it is such a hassle to implement the necessary traits all over again across multiple projects. It's better if thescrapercrate can provide the necessary implementations ofserde::Deserializeandserde::Serializetraits in the first place. Even though the benefits are small, it is a one-step forward that propels betterserdeintegration on this project.I hope the developers of this project accepts my feature request. Thank you for reading!