Skip to content

Commit bfa64ad

Browse files
Delete deprecated RCTBridge initializers (#59434)
Summary: Both `RCTBridge` initializers return an inert stub and have no callers left now that the test harness is gone. Delete the declarations and stub implementations. `RCTBridgeModuleListProvider` stays until the proxy shim using it is removed. Changelog: [iOS][Removed] - Remove deprecated `RCTBridge` initializers Reviewed By: andrewdacenko Differential Revision: D127294773 Pull Request resolved: #59434
1 parent f9855ad commit bfa64ad

6 files changed

Lines changed: 0 additions & 48 deletions

File tree

‎packages/react-native/React/Base/RCTBridge.h‎

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -85,34 +85,6 @@ RCT_EXTERN_C_END
8585
*/
8686
@interface RCTBridge : NSObject <RCTInvalidating>
8787

88-
/**
89-
* Creates a new bridge with a custom RCTBridgeDelegate.
90-
*
91-
* All the interaction with the JavaScript context should be done using the bridge
92-
* instance of the RCTBridgeModules. Modules will be automatically instantiated
93-
* using the default constructor, but you can optionally pass in an array of
94-
* pre-initialized module instances if they require additional init parameters
95-
* or configuration.
96-
*/
97-
- (instancetype)initWithDelegate:(id<RCTBridgeDelegate>)delegate
98-
launchOptions:(NSDictionary *)launchOptions
99-
__deprecated_msg("This API will be removed along with the legacy architecture.");
100-
101-
/**
102-
* DEPRECATED: Use initWithDelegate:launchOptions: instead
103-
*
104-
* The designated initializer. This creates a new bridge on top of the specified
105-
* executor. The bridge should then be used for all subsequent communication
106-
* with the JavaScript code running in the executor. Modules will be automatically
107-
* instantiated using the default constructor, but you can optionally pass in an
108-
* array of pre-initialized module instances if they require additional init
109-
* parameters or configuration.
110-
*/
111-
- (instancetype)initWithBundleURL:(NSURL *)bundleURL
112-
moduleProvider:(RCTBridgeModuleListProvider)block
113-
launchOptions:(NSDictionary *)launchOptions
114-
__deprecated_msg("This API will be removed along with the legacy architecture.");
115-
11688
/**
11789
* This method registers the file path of an additional JS segment by its ID.
11890
*

‎packages/react-native/React/Base/RCTBridge.mm‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -218,18 +218,6 @@ void RCTSetTurboModuleInteropBridgeProxyLogLevel(RCTBridgeProxyLoggingLevel logL
218218
}
219219

220220
@implementation RCTBridge
221-
- (instancetype)initWithDelegate:(id<RCTBridgeDelegate>)delegate launchOptions:(NSDictionary *)launchOptions
222-
{
223-
return self;
224-
}
225-
226-
- (instancetype)initWithBundleURL:(NSURL *)bundleURL
227-
moduleProvider:(__strong RCTBridgeModuleListProvider)block
228-
launchOptions:(NSDictionary *)launchOptions
229-
{
230-
return self;
231-
}
232-
233221
- (void)registerSegmentWithId:(NSUInteger)segmentId path:(NSString *)path
234222
{
235223
}

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -655,8 +655,6 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
655655
public virtual id moduleForClass:(Class moduleClass);
656656
public virtual id moduleForName:(NSString* moduleName);
657657
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
658-
public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
659-
public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
660658
public virtual void onFastRefresh();
661659
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
662660
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -664,8 +664,6 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
664664
public virtual id moduleForClass:(Class moduleClass);
665665
public virtual id moduleForName:(NSString* moduleName);
666666
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
667-
public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
668-
public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
669667
public virtual void onFastRefresh();
670668
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
671669
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -655,8 +655,6 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
655655
public virtual id moduleForClass:(Class moduleClass);
656656
public virtual id moduleForName:(NSString* moduleName);
657657
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
658-
public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
659-
public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
660658
public virtual void onFastRefresh();
661659
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
662660
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -655,8 +655,6 @@ interface RCTBridge : public NSObject <RCTInvalidating> {
655655
public virtual id moduleForClass:(Class moduleClass);
656656
public virtual id moduleForName:(NSString* moduleName);
657657
public virtual id moduleForName:lazilyLoadIfNecessary:(NSString* moduleName, BOOL lazilyLoad);
658-
public virtual instancetype initWithBundleURL:moduleProvider:launchOptions:(NSURL* bundleURL, RCTBridgeModuleListProvider block, NSDictionary* launchOptions);
659-
public virtual instancetype initWithDelegate:launchOptions:(id<RCTBridgeDelegate> delegate, NSDictionary* launchOptions);
660658
public virtual void onFastRefresh();
661659
public virtual void registerSegmentWithId:path:(NSUInteger segmentId, NSString* path);
662660
public virtual void setRCTTurboModuleRegistry:(id<RCTTurboModuleRegistry> turboModuleRegistry);

0 commit comments

Comments
 (0)