From a29119e959877c96f9f3c1f1b53e704ef555758b Mon Sep 17 00:00:00 2001 From: fzahir786 Date: Wed, 4 Nov 2026 13:03:20 +0530 Subject: [PATCH 1/4] RDKEMW-28023: Remove ExecStop from update-device-details.service MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reason for change: With default KillMode=control-group, systemctl stop already SIGTERMs (then SIGKILLs after TimeoutStopSec) any process still in the cgroup — so no ExecStop is needed. $MAINPID is returned as 0, so it is empty Test Procedure: Check for service failure after stopping the service Priority: P1 Risks: None Signed-off-by: Faizal Hasan.Z Date: Wed, 4 Nov 2026 15:20:02 +0530 Subject: [PATCH 2/4] RDKEMW-28023: Add exit trap for signal handling in getDeviceDetails.sh --- lib/rdk/getDeviceDetails.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/rdk/getDeviceDetails.sh b/lib/rdk/getDeviceDetails.sh index ef9ff6225..0b2fbcc05 100755 --- a/lib/rdk/getDeviceDetails.sh +++ b/lib/rdk/getDeviceDetails.sh @@ -563,6 +563,7 @@ lock() echo "$$" > $lockPidFile logMsg "lock acquired successfully" trap 'unlock "active process"' 0 1 13 15 &>/dev/null + trap 'unlock "active process"; exit 0' 15 &>/dev/null } unlock() From dd510957849dbf70f3a35eadfb04be7b77ec2e35 Mon Sep 17 00:00:00 2001 From: fzahir786 Date: Wed, 4 Nov 2026 19:15:37 +0530 Subject: [PATCH 3/4] Potential fix for pull request finding 'Avoid releasing the shared lock twice on SIGTERM' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- lib/rdk/getDeviceDetails.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rdk/getDeviceDetails.sh b/lib/rdk/getDeviceDetails.sh index 0b2fbcc05..f827cc5fb 100755 --- a/lib/rdk/getDeviceDetails.sh +++ b/lib/rdk/getDeviceDetails.sh @@ -563,7 +563,7 @@ lock() echo "$$" > $lockPidFile logMsg "lock acquired successfully" trap 'unlock "active process"' 0 1 13 15 &>/dev/null - trap 'unlock "active process"; exit 0' 15 &>/dev/null + trap 'exit 0' 15 &>/dev/null } unlock() From 0e37f9c2c208b34de69d5404428fef4bd35ee9c3 Mon Sep 17 00:00:00 2001 From: fzahir786 Date: Thu, 5 Nov 2026 11:17:44 +0530 Subject: [PATCH 4/4] RDKEMW-28023: Removed signal 15 for earlier trap in getDeviceDetails.sh --- lib/rdk/getDeviceDetails.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rdk/getDeviceDetails.sh b/lib/rdk/getDeviceDetails.sh index f827cc5fb..3ec0891ae 100755 --- a/lib/rdk/getDeviceDetails.sh +++ b/lib/rdk/getDeviceDetails.sh @@ -562,7 +562,7 @@ lock() done echo "$$" > $lockPidFile logMsg "lock acquired successfully" - trap 'unlock "active process"' 0 1 13 15 &>/dev/null + trap 'unlock "active process"' 0 1 13 &>/dev/null trap 'exit 0' 15 &>/dev/null }