Use tempfile in the parent process

Author: vstinner

runtests.py

@@ -12,6 +12,7 @@
 import os.path
 import shutil
 import sys
+import tempfile
 import time
 from concurrent.futures import ThreadPoolExecutor
 
@@ -51,10 +52,10 @@
 )
 
 
-def get_test_command(executable, verbose):
+def get_test_command(executable, verbose, build_dir):
     # Don't use realpath() for the executed command to support virtual
     # environments
-    cmd = [executable, TEST_COMPAT]
+    cmd = [executable, TEST_COMPAT, build_dir]
     if verbose:
         cmd.append('-v')
     return cmd
@@ -90,8 +91,9 @@ def run_tests_parallel(args):
         jobs.append(executable)
 
     def worker(executable):
-        cmd = get_test_command(executable, args.verbose)
-        return get_output(cmd)
+        with tempfile.TemporaryDirectory() as build_dir:
+            cmd = get_test_command(executable, args.verbose, build_dir)
+            return get_output(cmd)
 
     if hasattr(os, 'process_cpu_count'):
         max_workers = os.process_cpu_count()
@@ -127,6 +129,13 @@ def test_upgrade_pythoncapi(args):
     print()
 
 
+def test_current_version(args):
+    with tempfile.TemporaryDirectory() as build_dir:
+        cmd = get_test_command(sys.executable, args.verbose, build_dir)
+        run_command(cmd)
+    print()
+
+
 def main():
     start_time = time.perf_counter()
     args = parse_args()
@@ -136,9 +145,7 @@ def main():
     if not args.current:
         run_tests_parallel(args)
     else:
-        cmd = get_test_command(sys.executable, args.verbose)
-        run_command(cmd)
-        print()
+        test_current_version(args)
 
     dt = time.perf_counter() - start_time
     print(f"Total time: {dt:.1f} seconds")

tests/test_pythoncapi_compat.py

@@ -7,14 +7,14 @@
     python3 run_tests.py
     python3 run_tests.py -v # verbose mode
 """
+import argparse
 import faulthandler
 import gc
 import os.path
 import shutil
 import subprocess
 import sys
 import sysconfig
-import tempfile
 
 # test.utils
 import setup
@@ -202,28 +202,36 @@ def test_func():
         msg += " (no reference leak detected)"
     print(msg)
 
+    # Unload the extension module
+    testmod = None
+    del sys.modules[module_name]
+
+
+def parse_args():
+    parser = argparse.ArgumentParser()
+    parser.add_argument('-v', '--verbose',
+                        action='store_true')  # on/off flag
+    parser.add_argument('build_dir')
+    return parser.parse_args()
+
 
 def main():
     global VERBOSE
-    VERBOSE = ("-v" in sys.argv[1:] or "--verbose" in sys.argv[1:])
-
-    if (3, 13) <= sys.version_info <= (3, 13, 0, 'alpha', 4):
-        print("SKIP Python 3.13 alpha 1..4: not supported!")
-        return
+    args = parse_args()
+    VERBOSE = args.verbose
+    build_dir = args.build_dir
 
-    if faulthandler is not None:
-        faulthandler.enable()
+    faulthandler.enable()
 
     src_dir = os.path.dirname(__file__)
     if src_dir:
         os.chdir(src_dir)
 
-    with tempfile.TemporaryDirectory() as build_dir:
-        build_ext(build_dir)
+    build_ext(build_dir)
 
-        tests = setup.C_TESTS + setup.CXX_TESTS
-        for module_name, std, limited in tests:
-            run_tests(build_dir, module_name, std)
+    tests = setup.C_TESTS + setup.CXX_TESTS
+    for module_name, std, limited in tests:
+        run_tests(build_dir, module_name, std)
 
 
 if __name__ == "__main__":

tests/utils.py

@@ -10,6 +10,7 @@ def _run_command(cmd, **kw):
         proc = subprocess.Popen(cmd, **kw)
         try:
             proc.communicate()
+            proc.wait()
         except:
             proc.kill()
             proc.wait()