From 504d672e9b61700bfd0fc2b7e94c50ffcbdebd5a Mon Sep 17 00:00:00 2001 From: Talley Lambert Date: Tue, 10 Nov 2026 14:03:22 +0100 Subject: [PATCH] fix: fix slider readout qt6.12 --- src/magicgui/backends/_qtpy/widgets.py | 7 ++++++- tests/test_widgets.py | 11 +++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/magicgui/backends/_qtpy/widgets.py b/src/magicgui/backends/_qtpy/widgets.py index 89f26d0c..8fd66bc3 100644 --- a/src/magicgui/backends/_qtpy/widgets.py +++ b/src/magicgui/backends/_qtpy/widgets.py @@ -848,7 +848,12 @@ def __init__(self, qwidg=QtW.QSlider, **kwargs: Any) -> None: no_buttons = QtW.QAbstractSpinBox.ButtonSymbols.NoButtons self._readout_widget.setButtonSymbols(no_buttons) - self._readout_widget.setStyleSheet("background:transparent; border: 0;") + # style the inner line edit rather than the spinbox itself: on Qt 6.12, a + # `border` rule on a button-less spinbox shrinks its line edit to 1px (#750) + self._readout_widget.setFrame(False) + self._readout_widget.lineEdit().setStyleSheet( + "background:transparent; border: 0;" + ) self._qwidget.valueChanged.connect(self._on_slider_change) self._readout_widget.editingFinished.connect(self._on_readout_change) diff --git a/tests/test_widgets.py b/tests/test_widgets.py index 4866453b..ddae07a1 100644 --- a/tests/test_widgets.py +++ b/tests/test_widgets.py @@ -1154,6 +1154,17 @@ def test_float_slider_readout(): assert sld._widget._readout_widget.maximum() == 10.5 +@pytest.mark.parametrize("cls", [widgets.Slider, widgets.FloatSlider]) +def test_slider_readout_not_clipped(cls): + """Readout text must fit in its line edit (#750: 1px wide on Qt 6.12).""" + sld = cls(value=10) + sld.show() + line_edit = sld._widget._readout_widget.lineEdit() + text_width = line_edit.fontMetrics().horizontalAdvance(line_edit.text()) + assert line_edit.width() >= text_width + sld.close() + + def test_toolbar(): tb = widgets.ToolBar() tb.add_button("test", callback=lambda: None)