From 7cca5c1e7beca16341daa3a4fc9d6275d04b3ba2 Mon Sep 17 00:00:00 2001
From: devholic22 <hyunjoon.tech@gmail.com>
Date: Thu, 28 Aug 2025 21:42:46 +0900
Subject: [PATCH] test_runner: remove `failure` attribute from JUnit reporter
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit aligns the Node.js test runner’s JUnit XML output with the
official JUnit specification by removing the non-standard failure
attribute from elements and replacing it with a proper nested tag.
---
 lib/internal/test_runner/reporter/junit.js    |  1 -
 .../output/junit_reporter.snapshot            | 54 +++++++++----------
 2 files changed, 27 insertions(+), 28 deletions(-)

diff --git a/lib/internal/test_runner/reporter/junit.js b/lib/internal/test_runner/reporter/junit.js
index ed25a4bd5fbd..7f6d7122d43b 100644
--- a/lib/internal/test_runner/reporter/junit.js
+++ b/lib/internal/test_runner/reporter/junit.js
@@ -149,7 +149,6 @@ module.exports = async function* junitReporter(source) {
               children: [inspectWithNoCustomRetry(error, inspectOptions)],
             });
             currentTest.failures = 1;
-            currentTest.attrs.failure = error?.message ?? '';
           }
         }
         break;
diff --git a/test/fixtures/test-runner/output/junit_reporter.snapshot b/test/fixtures/test-runner/output/junit_reporter.snapshot
index cef5f0b52da1..b49579fc4721 100644
--- a/test/fixtures/test-runner/output/junit_reporter.snapshot
+++ b/test/fixtures/test-runner/output/junit_reporter.snapshot
@@ -16,7 +16,7 @@
 	<testcase name="sync pass todo with message" time="*" classname="test" file="*">
 		<skipped type="todo" message="this is a passing todo"/>
 	</testcase>
-	<testcase name="sync fail todo" time="*" classname="test" file="*" failure="thrown from sync fail todo">
+	<testcase name="sync fail todo" time="*" classname="test" file="*">
 		<skipped type="todo" message="true"/>
 		<failure type="testCodeFailure" message="thrown from sync fail todo">
 [Error [ERR_TEST_FAILURE]: thrown from sync fail todo] {
@@ -28,7 +28,7 @@
 }
 		</failure>
 	</testcase>
-	<testcase name="sync fail todo with message" time="*" classname="test" file="*" failure="thrown from sync fail todo with message">
+	<testcase name="sync fail todo with message" time="*" classname="test" file="*">
 		<skipped type="todo" message="this is a failing todo"/>
 		<failure type="testCodeFailure" message="thrown from sync fail todo with message">
 [Error [ERR_TEST_FAILURE]: thrown from sync fail todo with message] {
@@ -48,7 +48,7 @@
 	</testcase>
 	<testcase name="sync pass" time="*" classname="test" file="*"/>
 	<!-- this test should pass -->
-	<testcase name="sync throw fail" time="*" classname="test" file="*" failure="thrown from sync throw fail">
+	<testcase name="sync throw fail" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="thrown from sync throw fail">
 [Error [ERR_TEST_FAILURE]: thrown from sync throw fail] {
   code: 'ERR_TEST_FAILURE',
@@ -63,7 +63,7 @@
 		<skipped type="skipped" message="true"/>
 	</testcase>
 	<testcase name="async pass" time="*" classname="test" file="*"/>
-	<testcase name="async throw fail" time="*" classname="test" file="*" failure="thrown from async throw fail">
+	<testcase name="async throw fail" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="thrown from async throw fail">
 [Error [ERR_TEST_FAILURE]: thrown from async throw fail] {
   code: 'ERR_TEST_FAILURE',
@@ -74,7 +74,7 @@
 }
 		</failure>
 	</testcase>
-	<testcase name="async skip fail" time="*" classname="test" file="*" failure="thrown from async throw fail">
+	<testcase name="async skip fail" time="*" classname="test" file="*">
 		<skipped type="skipped" message="true"/>
 		<failure type="testCodeFailure" message="thrown from async throw fail">
 [Error [ERR_TEST_FAILURE]: thrown from async throw fail] {
@@ -86,7 +86,7 @@
 }
 		</failure>
 	</testcase>
-	<testcase name="async assertion fail" time="*" classname="test" file="*" failure="Expected values to be strictly equal:&#10;&#10;true !== false&#10;">
+	<testcase name="async assertion fail" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="Expected values to be strictly equal:&#10;&#10;true !== false">
 [Error [ERR_TEST_FAILURE]: Expected values to be strictly equal:
 
@@ -112,7 +112,7 @@ true !== false
 		</failure>
 	</testcase>
 	<testcase name="resolve pass" time="*" classname="test" file="*"/>
-	<testcase name="reject fail" time="*" classname="test" file="*" failure="rejected from reject fail">
+	<testcase name="reject fail" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="rejected from reject fail">
 [Error [ERR_TEST_FAILURE]: rejected from reject fail] {
   code: 'ERR_TEST_FAILURE',
@@ -129,7 +129,7 @@ true !== false
 	<testcase name="immediate reject - passes but warns" time="*" classname="test" file="*"/>
 	<testcase name="immediate resolve pass" time="*" classname="test" file="*"/>
 	<testsuite name="subtest sync throw fail" time="*" disabled="0" errors="0" tests="1" failures="1" skipped="0" timestamp="*" hostname="HOSTNAME">
-		<testcase name="+sync throw fail" time="*" classname="test" file="*" failure="thrown from subtest sync throw fail">
+		<testcase name="+sync throw fail" time="*" classname="test" file="*">
 			<failure type="testCodeFailure" message="thrown from subtest sync throw fail">
 Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fail
     at TestContext.&lt;anonymous> (<project-root>/test/fixtures/test-runner/output/output.js:125:11)
@@ -146,7 +146,7 @@ Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fail
 		</testcase>
 		<!-- this subtest should make its parent test fail -->
 	</testsuite>
-	<testcase name="sync throw non-error fail" time="*" classname="test" file="*" failure="Symbol(thrown symbol from sync throw non-error fail)">
+	<testcase name="sync throw non-error fail" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="Symbol(thrown symbol from sync throw non-error fail)">
 [Error [ERR_TEST_FAILURE]: Symbol(thrown symbol from sync throw non-error fail)] { code: 'ERR_TEST_FAILURE', failureType: 'testCodeFailure', cause: Symbol(thrown symbol from sync throw non-error fail) }
 		</failure>
@@ -170,7 +170,7 @@ Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fail
 	<testcase name="sync skip option with message" time="*" classname="test" file="*">
 		<skipped type="skipped" message="this is skipped"/>
 	</testcase>
-	<testcase name="sync skip option is false fail" time="*" classname="test" file="*" failure="this should be executed">
+	<testcase name="sync skip option is false fail" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="this should be executed">
 [Error [ERR_TEST_FAILURE]: this should be executed] {
   code: 'ERR_TEST_FAILURE',
@@ -196,7 +196,7 @@ Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fail
 		<skipped type="skipped" message="true"/>
 	</testcase>
 	<testcase name="callback pass" time="*" classname="test" file="*"/>
-	<testcase name="callback fail" time="*" classname="test" file="*" failure="callback failure">
+	<testcase name="callback fail" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="callback failure">
 [Error [ERR_TEST_FAILURE]: callback failure] {
   code: 'ERR_TEST_FAILURE',
@@ -210,12 +210,12 @@ Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fail
 	<testcase name="sync t is this in test" time="*" classname="test" file="*"/>
 	<testcase name="async t is this in test" time="*" classname="test" file="*"/>
 	<testcase name="callback t is this in test" time="*" classname="test" file="*"/>
-	<testcase name="callback also returns a Promise" time="*" classname="test" file="*" failure="passed a callback but also returned a Promise">
+	<testcase name="callback also returns a Promise" time="*" classname="test" file="*">
 		<failure type="callbackAndPromisePresent" message="passed a callback but also returned a Promise">
 [Error [ERR_TEST_FAILURE]: passed a callback but also returned a Promise] { code: 'ERR_TEST_FAILURE', failureType: 'callbackAndPromisePresent', cause: 'passed a callback but also returned a Promise' }
 		</failure>
 	</testcase>
-	<testcase name="callback throw" time="*" classname="test" file="*" failure="thrown from callback throw">
+	<testcase name="callback throw" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="thrown from callback throw">
 [Error [ERR_TEST_FAILURE]: thrown from callback throw] {
   code: 'ERR_TEST_FAILURE',
@@ -226,7 +226,7 @@ Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fail
 }
 		</failure>
 	</testcase>
-	<testcase name="callback called twice" time="*" classname="test" file="*" failure="callback invoked multiple times">
+	<testcase name="callback called twice" time="*" classname="test" file="*">
 		<failure type="multipleCallbackInvocations" message="callback invoked multiple times">
 Error [ERR_TEST_FAILURE]: callback invoked multiple times
     at TestContext.&lt;anonymous> (<project-root>/test/fixtures/test-runner/output/output.js:272:3)
@@ -238,7 +238,7 @@ Error [ERR_TEST_FAILURE]: callback invoked multiple times
 		</failure>
 	</testcase>
 	<testcase name="callback called twice in different ticks" time="*" classname="test" file="*"/>
-	<testcase name="callback called twice in future tick" time="*" classname="test" file="*" failure="callback invoked multiple times">
+	<testcase name="callback called twice in future tick" time="*" classname="test" file="*">
 		<failure type="uncaughtException" message="callback invoked multiple times">
 Error [ERR_TEST_FAILURE]: callback invoked multiple times
     at <node-internal-frames> {
@@ -253,7 +253,7 @@ Error [ERR_TEST_FAILURE]: callback invoked multiple times
 }
 		</failure>
 	</testcase>
-	<testcase name="callback async throw" time="*" classname="test" file="*" failure="thrown from callback async throw">
+	<testcase name="callback async throw" time="*" classname="test" file="*">
 		<failure type="uncaughtException" message="thrown from callback async throw">
 Error [ERR_TEST_FAILURE]: thrown from callback async throw
     at <node-internal-frames> {
@@ -271,12 +271,12 @@ Error [ERR_TEST_FAILURE]: thrown from callback async throw
 		<testcase name="running subtest 3" time="*" classname="test" file="*"/>
 		<testcase name="running subtest 4" time="*" classname="test" file="*"/>
 	</testsuite>
-	<testcase name="custom inspect symbol fail" time="*" classname="test" file="*" failure="customized">
+	<testcase name="custom inspect symbol fail" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="customized">
 [Error [ERR_TEST_FAILURE]: customized] { code: 'ERR_TEST_FAILURE', failureType: 'testCodeFailure', cause: customized }
 		</failure>
 	</testcase>
-	<testcase name="custom inspect symbol that throws fail" time="*" classname="test" file="*" failure="{&#10;  foo: 1,&#10;  Symbol(nodejs.util.inspect.custom): [Function: [nodejs.util.inspect.custom]]&#10;}">
+	<testcase name="custom inspect symbol that throws fail" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="{&#10;  foo: 1,&#10;  Symbol(nodejs.util.inspect.custom): [Function: [nodejs.util.inspect.custom]]&#10;}">
 [Error [ERR_TEST_FAILURE]: {
   foo: 1,
@@ -289,7 +289,7 @@ Error [ERR_TEST_FAILURE]: thrown from callback async throw
 		</failure>
 	</testcase>
 	<testsuite name="subtest sync throw fails" time="*" disabled="0" errors="0" tests="2" failures="2" skipped="0" timestamp="*" hostname="HOSTNAME">
-		<testcase name="sync throw fails at first" time="*" classname="test" file="*" failure="thrown from subtest sync throw fails at first">
+		<testcase name="sync throw fails at first" time="*" classname="test" file="*">
 			<failure type="testCodeFailure" message="thrown from subtest sync throw fails at first">
 Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fails at first
     at TestContext.&lt;anonymous> (<project-root>/test/fixtures/test-runner/output/output.js:334:11)
@@ -304,7 +304,7 @@ Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fails at first
 }
 			</failure>
 		</testcase>
-		<testcase name="sync throw fails at second" time="*" classname="test" file="*" failure="thrown from subtest sync throw fails at second">
+		<testcase name="sync throw fails at second" time="*" classname="test" file="*">
 			<failure type="testCodeFailure" message="thrown from subtest sync throw fails at second">
 Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fails at second
     at TestContext.&lt;anonymous> (<project-root>/test/fixtures/test-runner/output/output.js:337:11) {
@@ -319,12 +319,12 @@ Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fails at second
 			</failure>
 		</testcase>
 	</testsuite>
-	<testcase name="timed out async test" time="*" classname="test" file="*" failure="test timed out after 5ms">
+	<testcase name="timed out async test" time="*" classname="test" file="*">
 		<failure type="testTimeoutFailure" message="test timed out after 5ms">
 [Error [ERR_TEST_FAILURE]: test timed out after 5ms] { code: 'ERR_TEST_FAILURE', failureType: 'testTimeoutFailure', cause: 'test timed out after 5ms' }
 		</failure>
 	</testcase>
-	<testcase name="timed out callback test" time="*" classname="test" file="*" failure="test timed out after 5ms">
+	<testcase name="timed out callback test" time="*" classname="test" file="*">
 		<failure type="testTimeoutFailure" message="test timed out after 5ms">
 [Error [ERR_TEST_FAILURE]: test timed out after 5ms] { code: 'ERR_TEST_FAILURE', failureType: 'testTimeoutFailure', cause: 'test timed out after 5ms' }
 		</failure>
@@ -332,12 +332,12 @@ Error [ERR_TEST_FAILURE]: thrown from subtest sync throw fails at second
 	<testcase name="large timeout async test is ok" time="*" classname="test" file="*"/>
 	<testcase name="large timeout callback test is ok" time="*" classname="test" file="*"/>
 	<testcase name="successful thenable" time="*" classname="test" file="*"/>
-	<testcase name="rejected thenable" time="*" classname="test" file="*" failure="custom error">
+	<testcase name="rejected thenable" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="custom error">
 [Error [ERR_TEST_FAILURE]: custom error] { code: 'ERR_TEST_FAILURE', failureType: 'testCodeFailure', cause: 'custom error' }
 		</failure>
 	</testcase>
-	<testcase name="unfinished test with uncaughtException" time="*" classname="test" file="*" failure="foo">
+	<testcase name="unfinished test with uncaughtException" time="*" classname="test" file="*">
 		<failure type="uncaughtException" message="foo">
 Error [ERR_TEST_FAILURE]: foo
     at <node-internal-frames> {
@@ -349,7 +349,7 @@ Error [ERR_TEST_FAILURE]: foo
 }
 		</failure>
 	</testcase>
-	<testcase name="unfinished test with unhandledRejection" time="*" classname="test" file="*" failure="bar">
+	<testcase name="unfinished test with unhandledRejection" time="*" classname="test" file="*">
 		<failure type="unhandledRejection" message="bar">
 Error [ERR_TEST_FAILURE]: bar
     at <node-internal-frames> {
@@ -361,7 +361,7 @@ Error [ERR_TEST_FAILURE]: bar
 }
 		</failure>
 	</testcase>
-	<testcase name="assertion errors display actual and expected properly" time="*" classname="test" file="*" failure="Expected values to be loosely deep-equal:&#10;&#10;{&#10;  bar: 1,&#10;  baz: {&#10;    date: 1970-01-01T00:00:00.000Z,&#10;    null: null,&#10;    number: 1,&#10;    string: 'Hello',&#10;    undefined: undefined&#10;  },&#10;  boo: [&#10;    1&#10;  ],&#10;  foo: 1&#10;}&#10;&#10;should loosely deep-equal&#10;&#10;{&#10;  baz: {&#10;    date: 1970-01-01T00:00:00.000Z,&#10;    null: null,&#10;    number: 1,&#10;    string: 'Hello',&#10;    undefined: undefined&#10;  },&#10;  boo: [&#10;    1&#10;  ],&#10;  circular: &lt;ref *1> {&#10;    bar: 2,&#10;    c: [Circular *1]&#10;  }&#10;}">
+	<testcase name="assertion errors display actual and expected properly" time="*" classname="test" file="*">
 		<failure type="testCodeFailure" message="Expected values to be loosely deep-equal:&#10;&#10;{&#10;  bar: 1,&#10;  baz: {&#10;    date: 1970-01-01T00:00:00.000Z,&#10;    null: null,&#10;    number: 1,&#10;    string: 'Hello',&#10;    undefined: undefined&#10;  },&#10;  boo: [&#10;    1&#10;  ],&#10;  foo: 1&#10;}&#10;&#10;should loosely deep-equal&#10;&#10;{&#10;  baz: {&#10;    date: 1970-01-01T00:00:00.000Z,&#10;    null: null,&#10;    number: 1,&#10;    string: 'Hello',&#10;    undefined: undefined&#10;  },&#10;  boo: [&#10;    1&#10;  ],&#10;  circular: &lt;ref *1> {&#10;    bar: 2,&#10;    c: [Circular *1]&#10;  }&#10;}">
 [Error [ERR_TEST_FAILURE]: Expected values to be loosely deep-equal:
 
@@ -446,7 +446,7 @@ should loosely deep-equal
 }
 		</failure>
 	</testcase>
-	<testcase name="invalid subtest fail" time="*" classname="test" file="*" failure="test could not be started because its parent finished">
+	<testcase name="invalid subtest fail" time="*" classname="test" file="*">
 		<failure type="parentAlreadyFinished" message="test could not be started because its parent finished">
 Error [ERR_TEST_FAILURE]: test could not be started because its parent finished
     at Immediate.&lt;anonymous> (<project-root>/test/fixtures/test-runner/output/output.js:197:7) {