Skip to content

integration_test.go: TestCommandArchitecture missing assertions for schedule, backup-location, must-gather, setup on main/oadp-1.6/oadp-1.5 #214

Description

@coderabbitai

Summary

integration_test.go's TestCommandArchitecture test (majorCommands list in the "all major commands exist" subtest) only checks for backup, restore, nabsl-request, nonadmin, client, version. It does not assert the presence of schedule, backup-location, must-gather, and setup, even though cmd/root.go registers all of these commands via schedule.NewCommand(f), backuplocation.NewCommand(f), mustgather.NewMustGatherCommand(f), and setup.NewSetupCommand(f).

This was confirmed on main/oadp-dev, oadp-1.6, and oadp-1.5 — the commands exist in cmd/root.go on all of them, but the integration test's command list was never updated to cover them.

PR #212 fixes this only for the oadp-1.4 branch (see #212, comment #212 (comment)).

Affected branches

  • main / oadp-dev
  • oadp-1.6
  • oadp-1.5

Required change

In integration_test.go, update the majorCommands slice in TestCommandArchitecture's "all major commands exist" subtest to include schedule, backup-location, must-gather, and setup (mirroring the fix applied to oadp-1.4 in PR #212).

Acceptance criteria

  • main/oadp-dev integration test asserts schedule, backup-location, must-gather, setup in root --help output
  • oadp-1.6 integration test updated similarly
  • oadp-1.5 integration test updated similarly

Requested by @kaovilai

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions