Skip to content

Adopt ui's ExternalLink #1260

Description

@microbit-matt-hillsdon

Four hand-rolled external links (WelcomeDialog, DocumentationContent link renderer, NotFoundDialog, FirmwareDialog) could adopt @microbit/ui's new ExternalLink, which adds a visually hidden "opens in a new tab" to the accessible name.

HelpMenu's user-guide entry opens a new tab from a MenuItem — a different pattern ExternalLink doesn't cover; needs a library-level think.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions