Skip to content

My mistake in lms sampler #1848

Description

@vmobilis

@leejet, hello and thank you for the program.
In recent PR #1843 I managed to make an error in 3 lines of code:

x += hist[hist.size() - 2] * lms_coeff[3];

And misindexed the hist[]: 2, 2, 1 instead of 2, 1, 0.
( hist.back() == hist[hist.size() - 1] )

The problem is that fixed version does not work even with 50 steps.

wrong 20fixed 20fixed 50
Image Image Image

What should I do, remove LMS sampler or name it differently?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions