From ad091bbe58aacbd3840989ff691952118054703f Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sun, 13 Sep 2026 12:37:25 +0000
Subject: [PATCH 1/2] Initial plan


From c191dd29bb41e5e061741dd2b0000a869dc824cf Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sun, 13 Sep 2026 12:45:32 +0000
Subject: [PATCH 2/2] Fix boxed null-check in generated logarithmic conversions

Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
---
 .../Cents.g.cs                                                  | 1 -
 .../Decibels.g.cs                                               | 2 --
 .../DirectionalityIndex.g.cs                                    | 1 -
 .../PH.g.cs                                                     | 1 -
 .../Semitones.g.cs                                              | 1 -
 .../SoundIntensityLevel.g.cs                                    | 1 -
 .../SoundPowerLevel.g.cs                                        | 1 -
 .../SoundPressureLevel.g.cs                                     | 1 -
 .../Generators/LogarithmicScalesGenerator.cs                    | 1 -
 Semantics.Test/Quantities/QuantityValueTypeTests.cs             | 2 ++
 10 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Cents.g.cs b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Cents.g.cs
index 95d0c0ff..1d597af6 100644
--- a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Cents.g.cs
+++ b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Cents.g.cs
@@ -36,7 +36,6 @@ public readonly partial record struct Cents<T>(T Value) : IComparable<Cents<T>>
 	/// <returns>A new <see cref="Cents{T}"/>. A linear value of zero maps to negative infinity.</returns>
 	public static Cents<T> FromFrequencyRatio(Ratio<T> linear)
 	{
-		ArgumentNullException.ThrowIfNull(linear);
 		double linearValue = double.CreateChecked(linear.Value);
 		return new(T.CreateChecked(1200.0 * Math.Log2(linearValue)));
 	}
diff --git a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Decibels.g.cs b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Decibels.g.cs
index d60a9f61..6ffaa346 100644
--- a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Decibels.g.cs
+++ b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Decibels.g.cs
@@ -36,7 +36,6 @@ public readonly partial record struct Decibels<T>(T Value) : IComparable<Decibel
 	/// <returns>A new <see cref="Decibels{T}"/>. A linear value of zero maps to negative infinity.</returns>
 	public static Decibels<T> FromGain(Gain<T> linear)
 	{
-		ArgumentNullException.ThrowIfNull(linear);
 		double linearValue = double.CreateChecked(linear.Value);
 		return new(T.CreateChecked(20.0 * Math.Log10(linearValue)));
 	}
@@ -58,7 +57,6 @@ public Gain<T> ToAmplitude()
 	/// <returns>A new <see cref="Decibels{T}"/>. A linear value of zero maps to negative infinity.</returns>
 	public static Decibels<T> FromPowerRatio(Ratio<T> linear)
 	{
-		ArgumentNullException.ThrowIfNull(linear);
 		double linearValue = double.CreateChecked(linear.Value);
 		return new(T.CreateChecked(10.0 * Math.Log10(linearValue)));
 	}
diff --git a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/DirectionalityIndex.g.cs b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/DirectionalityIndex.g.cs
index 3d855bea..6c6c4890 100644
--- a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/DirectionalityIndex.g.cs
+++ b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/DirectionalityIndex.g.cs
@@ -36,7 +36,6 @@ public readonly partial record struct DirectionalityIndex<T>(T Value) : ICompara
 	/// <returns>A new <see cref="DirectionalityIndex{T}"/>. A linear value of zero maps to negative infinity.</returns>
 	public static DirectionalityIndex<T> FromIntensityRatio(Ratio<T> linear)
 	{
-		ArgumentNullException.ThrowIfNull(linear);
 		double linearValue = double.CreateChecked(linear.Value);
 		return new(T.CreateChecked(10.0 * Math.Log10(linearValue)));
 	}
diff --git a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/PH.g.cs b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/PH.g.cs
index 0222816f..98659b47 100644
--- a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/PH.g.cs
+++ b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/PH.g.cs
@@ -36,7 +36,6 @@ public readonly partial record struct PH<T>(T Value) : IComparable<PH<T>>
 	/// <returns>A new <see cref="PH{T}"/>. A linear value of zero maps to negative infinity.</returns>
 	public static PH<T> FromHydrogenConcentration(Concentration<T> linear)
 	{
-		ArgumentNullException.ThrowIfNull(linear);
 		double linearValue = double.CreateChecked(linear.Value);
 		double reference = 1000.0;
 		return new(T.CreateChecked(-1.0 * Math.Log10(linearValue / reference)));
diff --git a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Semitones.g.cs b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Semitones.g.cs
index 3c137115..bc7c03ca 100644
--- a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Semitones.g.cs
+++ b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/Semitones.g.cs
@@ -36,7 +36,6 @@ public readonly partial record struct Semitones<T>(T Value) : IComparable<Semito
 	/// <returns>A new <see cref="Semitones{T}"/>. A linear value of zero maps to negative infinity.</returns>
 	public static Semitones<T> FromFrequencyRatio(Ratio<T> linear)
 	{
-		ArgumentNullException.ThrowIfNull(linear);
 		double linearValue = double.CreateChecked(linear.Value);
 		return new(T.CreateChecked(12.0 * Math.Log2(linearValue)));
 	}
diff --git a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundIntensityLevel.g.cs b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundIntensityLevel.g.cs
index 48c56c41..260a2a0a 100644
--- a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundIntensityLevel.g.cs
+++ b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundIntensityLevel.g.cs
@@ -36,7 +36,6 @@ public readonly partial record struct SoundIntensityLevel<T>(T Value) : ICompara
 	/// <returns>A new <see cref="SoundIntensityLevel{T}"/>. A linear value of zero maps to negative infinity.</returns>
 	public static SoundIntensityLevel<T> FromSoundIntensity(SoundIntensity<T> linear)
 	{
-		ArgumentNullException.ThrowIfNull(linear);
 		double linearValue = double.CreateChecked(linear.Value);
 		double reference = PhysicalConstants.Generic.ReferenceSoundIntensity<double>();
 		return new(T.CreateChecked(10.0 * Math.Log10(linearValue / reference)));
diff --git a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundPowerLevel.g.cs b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundPowerLevel.g.cs
index fb45efdf..695252b2 100644
--- a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundPowerLevel.g.cs
+++ b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundPowerLevel.g.cs
@@ -36,7 +36,6 @@ public readonly partial record struct SoundPowerLevel<T>(T Value) : IComparable<
 	/// <returns>A new <see cref="SoundPowerLevel{T}"/>. A linear value of zero maps to negative infinity.</returns>
 	public static SoundPowerLevel<T> FromSoundPower(SoundPower<T> linear)
 	{
-		ArgumentNullException.ThrowIfNull(linear);
 		double linearValue = double.CreateChecked(linear.Value);
 		double reference = PhysicalConstants.Generic.ReferenceSoundPower<double>();
 		return new(T.CreateChecked(10.0 * Math.Log10(linearValue / reference)));
diff --git a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundPressureLevel.g.cs b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundPressureLevel.g.cs
index 92533528..0f38e163 100644
--- a/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundPressureLevel.g.cs
+++ b/Semantics.Quantities/Generated/Semantics.SourceGenerators/Semantics.SourceGenerators.LogarithmicScalesGenerator/SoundPressureLevel.g.cs
@@ -36,7 +36,6 @@ public readonly partial record struct SoundPressureLevel<T>(T Value) : IComparab
 	/// <returns>A new <see cref="SoundPressureLevel{T}"/>. A linear value of zero maps to negative infinity.</returns>
 	public static SoundPressureLevel<T> FromSoundPressure(SoundPressure<T> linear)
 	{
-		ArgumentNullException.ThrowIfNull(linear);
 		double linearValue = double.CreateChecked(linear.Value);
 		double reference = PhysicalConstants.Generic.ReferenceSoundPressure<double>();
 		return new(T.CreateChecked(20.0 * Math.Log10(linearValue / reference)));
diff --git a/Semantics.SourceGenerators/Generators/LogarithmicScalesGenerator.cs b/Semantics.SourceGenerators/Generators/LogarithmicScalesGenerator.cs
index 6cf0e9b8..83cb0ce4 100644
--- a/Semantics.SourceGenerators/Generators/LogarithmicScalesGenerator.cs
+++ b/Semantics.SourceGenerators/Generators/LogarithmicScalesGenerator.cs
@@ -148,7 +148,6 @@ private static void WriteConversion(CodeBlocker cb, LogarithmicScaleDefinition s
 		cb.WriteLine($"public static {fullType} {fromName}({linear}<T> linear)");
 		using (new Scope(cb))
 		{
-			cb.WriteLine("ArgumentNullException.ThrowIfNull(linear);");
 			cb.WriteLine("double linearValue = double.CreateChecked(linear.Value);");
 			if (referenceExpr != null)
 			{
diff --git a/Semantics.Test/Quantities/QuantityValueTypeTests.cs b/Semantics.Test/Quantities/QuantityValueTypeTests.cs
index 9b38ca26..d03ce3cb 100644
--- a/Semantics.Test/Quantities/QuantityValueTypeTests.cs
+++ b/Semantics.Test/Quantities/QuantityValueTypeTests.cs
@@ -58,6 +58,7 @@ public void QuantityArithmeticDoesNotAllocate()
 	{
 		Length<double> a = Length<double>.FromMeter(3.0);
 		Duration<double> t = Duration<double>.FromSecond(1.5);
+		Gain<double> gain = Gain<double>.Create(2.0);
 
 		Assert.AreEqual(0L, MeasureAllocation(() => (a + a).Value), "addition allocated");
 		Assert.AreEqual(0L, MeasureAllocation(() => (a - a).Value), "subtraction allocated");
@@ -66,6 +67,7 @@ public void QuantityArithmeticDoesNotAllocate()
 		Assert.AreEqual(0L, MeasureAllocation(() => Length<double>.FromFoot(3.0).Value), "a converting factory allocated");
 		Assert.AreEqual(0L, MeasureAllocation(() => Length<double>.FromMeter(3.0).In(ktsu.Semantics.Quantities.Units.Units.Foot)), "converting to a unit allocated");
 		Assert.AreEqual(0L, MeasureAllocation(() => (a / t).Value), "a cross-dimensional operator allocated");
+		Assert.AreEqual(0L, MeasureAllocation(() => Decibels<double>.FromGain(gain).Value), "a logarithmic conversion allocated");
 	}
 
 	/// <summary>