Skip to content

Width/Height options do not work as described in instructions #5

Description

@r-murphy

In the readme file, it says that width and height use the parent values if these options are not set. Implying that the options should have higher priority.
But the actual way it behaves is that the parent value has higher priority, and these values are only used if the parent container is too small.

Maybe should be something like this?

if(noparent)
{
    width = settings.width || $elm.parent().width();
    height = settings.height || $elm.parent().height();
}
else 
{
    $elm.append(canvas);
    width = settings.width || $elm.innerWidth();
    height = settings.height || $elm.innerHeight();
}

The width/height < 2 check becomes redundant if this logic is used.
Not sure if this will break existing integrations, so it might need to be a new option. Or just reflect the actual behaviour in the instructions.

Thanks

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions