From 71f220fa5bb6971106bd3ee063c6e565659210e4 Mon Sep 17 00:00:00 2001 From: romirdes Date: Thu, 6 Aug 2026 13:09:23 -0700 Subject: [PATCH 1/3] revert L3 buffer size change for DRAM BW test --- internal/script/scripts.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/internal/script/scripts.go b/internal/script/scripts.go index b5b6597c..c856c524 100644 --- a/internal/script/scripts.go +++ b/internal/script/scripts.go @@ -164,13 +164,10 @@ func GetParameterizedScriptByName(name string, params map[string]string) ScriptD // mlc benchmark script constants (buffer setup snippets passed into mlcBenchmarkScript) const ( - // for measuring memory bandwidth and latency (2x of per-core L3 share, minimum 100 MB) + // for measuring memory bandwidth and latency (2x of L3 cache size) mlcBufferSetupMemory = `L3_KB=$(cache_size_kb L3) -CORES_PER_SOCKET=$(lscpu | grep -E 'Core\(s\) per socket:' | head -1 | awk '{print $4}') -[ $CORES_PER_SOCKET -lt 1 ] && CORES_PER_SOCKET=1 -BUF_KB=$(( L3_KB * 2 / CORES_PER_SOCKET )) -MIN_KB=102400 -[ $BUF_KB -lt $MIN_KB ] && BUF_KB=$MIN_KB` +BUF_KB=$(( L3_KB * 2 )) +[ $BUF_KB -lt 1 ] && BUF_KB=1` // for measuring L1 bandwidth and latency (half of L1d cache size minus 4KB) mlcBufferSetupL1 = `L1D_KB=$(cache_size_kb L1d) BUF_KB=$(( L1D_KB / 2 - 4 )) From ef557476e747edad6b2609cffc703ba15b1ef72c Mon Sep 17 00:00:00 2001 From: romirdes Date: Thu, 6 Aug 2026 14:24:27 -0700 Subject: [PATCH 2/3] dummy commit to trigger build & test --- internal/script/scripts.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/script/scripts.go b/internal/script/scripts.go index c856c524..c7bef8e8 100644 --- a/internal/script/scripts.go +++ b/internal/script/scripts.go @@ -164,7 +164,7 @@ func GetParameterizedScriptByName(name string, params map[string]string) ScriptD // mlc benchmark script constants (buffer setup snippets passed into mlcBenchmarkScript) const ( - // for measuring memory bandwidth and latency (2x of L3 cache size) + // for measuring memory bandwidth and latency (2x of L3 cache size) mlcBufferSetupMemory = `L3_KB=$(cache_size_kb L3) BUF_KB=$(( L3_KB * 2 )) [ $BUF_KB -lt 1 ] && BUF_KB=1` From fed18939ee241694403ebce2a2752e0371e248b8 Mon Sep 17 00:00:00 2001 From: adgubrud <96072084+adgubrud@users.noreply.github.com> Date: Thu, 6 Aug 2026 15:55:12 -0700 Subject: [PATCH 3/3] Update internal/script/scripts.go --- internal/script/scripts.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/script/scripts.go b/internal/script/scripts.go index c7bef8e8..c856c524 100644 --- a/internal/script/scripts.go +++ b/internal/script/scripts.go @@ -164,7 +164,7 @@ func GetParameterizedScriptByName(name string, params map[string]string) ScriptD // mlc benchmark script constants (buffer setup snippets passed into mlcBenchmarkScript) const ( - // for measuring memory bandwidth and latency (2x of L3 cache size) + // for measuring memory bandwidth and latency (2x of L3 cache size) mlcBufferSetupMemory = `L3_KB=$(cache_size_kb L3) BUF_KB=$(( L3_KB * 2 )) [ $BUF_KB -lt 1 ] && BUF_KB=1`