Skip to content

Suite.py assumes storage class pairings when only one is present, invalid storage class selected for config-pvc in pipelines namespace #465

Description

@Daniel-M-Jacobson

Encountered on ROSA
has gp3-csi but no efs

src/mas/devops/mas/suite.py
Line 86 # We make an assumption that if one of the paired classes if available, both will be

This is not accurate. It would be better to only match the ones that exist and leave the rest None

additionally from the getDefaultStorageClasses function definition and preparePipelinesNamespace it appears that
None is the intended value for unassigned storage classes

but from python/src/mas/cli/upgrade/app.py
line 381 if self.isSNO() or defaultStorageClasses.rwx == "none":
isn't going to work with None representing unmatched storageclasses

the "none" check appears in other files so whatever way this is resolved should be done there as well.
in theory matched providers could update unmatched storageclasses to "none" but that seems incorrect
e.g. python/src/mas/cli/install/settings/manageSettings.py

The expected behavior when encountering has gp3-csi but no efs should be config-pvc uses gp3-csi

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions