diff --git a/MODULE.bazel b/MODULE.bazel index d78d30c3dd6e4..30b9d15964ea8 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -29,7 +29,12 @@ bazel_dep(name = "abseil-cpp", version = "20250814.2") # The name "com_google_protobuf" is internally used by @bazel_tools, # a native repository we cannot override. # See https://github.com/googleapis/google-cloud-cpp/issues/15393 -bazel_dep(name = "protobuf", version = "35.1", repo_name = "com_google_protobuf") +bazel_dep(name = "protobuf", version = "36.0-rc2", repo_name = "com_google_protobuf") +#git_override( +# module_name = "protobuf", +# commit = "d65ed10e49acbee0e7d14277ab3e0330a0dd2838", +# remote = "https://github.com/protocolbuffers/protobuf.git", +#) bazel_dep(name = "boringssl", version = "0.20251124.0") bazel_dep(name = "nlohmann_json", version = "3.12.0.bcr.1") bazel_dep(name = "curl", version = "8.8.0.bcr.3") diff --git a/ci/cloudbuild/dockerfiles/demo-debian-bookworm.Dockerfile b/ci/cloudbuild/dockerfiles/demo-debian-bookworm.Dockerfile index 8ba22402ecc73..8d3d8c0641c0c 100644 --- a/ci/cloudbuild/dockerfiles/demo-debian-bookworm.Dockerfile +++ b/ci/cloudbuild/dockerfiles/demo-debian-bookworm.Dockerfile @@ -76,7 +76,7 @@ RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | # ```bash WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ diff --git a/ci/cloudbuild/dockerfiles/demo-debian-bullseye.Dockerfile b/ci/cloudbuild/dockerfiles/demo-debian-bullseye.Dockerfile index fe357506bd3ce..3b8c9f3fde09a 100644 --- a/ci/cloudbuild/dockerfiles/demo-debian-bullseye.Dockerfile +++ b/ci/cloudbuild/dockerfiles/demo-debian-bullseye.Dockerfile @@ -68,7 +68,7 @@ RUN apt-get update && \ # ```bash WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ diff --git a/ci/cloudbuild/dockerfiles/demo-fedora.Dockerfile b/ci/cloudbuild/dockerfiles/demo-fedora.Dockerfile index b544061a357ad..c69d4027f9248 100644 --- a/ci/cloudbuild/dockerfiles/demo-fedora.Dockerfile +++ b/ci/cloudbuild/dockerfiles/demo-fedora.Dockerfile @@ -66,7 +66,7 @@ ENV PKG_CONFIG_PATH=/usr/local/share/pkgconfig:/usr/lib64/pkgconfig:/usr/local/l # ```bash WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Release \ diff --git a/ci/cloudbuild/dockerfiles/demo-opensuse-leap.Dockerfile b/ci/cloudbuild/dockerfiles/demo-opensuse-leap.Dockerfile index df91fcc713bb2..3e9f56c100054 100644 --- a/ci/cloudbuild/dockerfiles/demo-opensuse-leap.Dockerfile +++ b/ci/cloudbuild/dockerfiles/demo-opensuse-leap.Dockerfile @@ -75,7 +75,7 @@ RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | # ```bash WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ diff --git a/ci/cloudbuild/dockerfiles/demo-rockylinux-9.Dockerfile b/ci/cloudbuild/dockerfiles/demo-rockylinux-9.Dockerfile index 607401c1f4336..69d72cb1c7ef2 100644 --- a/ci/cloudbuild/dockerfiles/demo-rockylinux-9.Dockerfile +++ b/ci/cloudbuild/dockerfiles/demo-rockylinux-9.Dockerfile @@ -93,7 +93,7 @@ RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | # ```bash WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ diff --git a/ci/cloudbuild/dockerfiles/demo-ubuntu-24.04.Dockerfile b/ci/cloudbuild/dockerfiles/demo-ubuntu-24.04.Dockerfile index b4a248130d2bd..f6033c174b8c1 100644 --- a/ci/cloudbuild/dockerfiles/demo-ubuntu-24.04.Dockerfile +++ b/ci/cloudbuild/dockerfiles/demo-ubuntu-24.04.Dockerfile @@ -78,7 +78,7 @@ RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | # ```bash WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ diff --git a/ci/cloudbuild/dockerfiles/demo-ubuntu-jammy.Dockerfile b/ci/cloudbuild/dockerfiles/demo-ubuntu-jammy.Dockerfile index 77addb40842e2..945a310a6c5b4 100644 --- a/ci/cloudbuild/dockerfiles/demo-ubuntu-jammy.Dockerfile +++ b/ci/cloudbuild/dockerfiles/demo-ubuntu-jammy.Dockerfile @@ -52,7 +52,7 @@ RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | # ```bash WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ diff --git a/ci/cloudbuild/dockerfiles/fedora-cmake-quickstart.Dockerfile b/ci/cloudbuild/dockerfiles/fedora-cmake-quickstart.Dockerfile index b19cd5905fa49..7bde1d7100ceb 100644 --- a/ci/cloudbuild/dockerfiles/fedora-cmake-quickstart.Dockerfile +++ b/ci/cloudbuild/dockerfiles/fedora-cmake-quickstart.Dockerfile @@ -129,7 +129,7 @@ RUN curl -fsSL https://github.com/nlohmann/json/archive/v3.11.3.tar.gz | \ ldconfig && cd /var/tmp && rm -fr build WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Release \ diff --git a/ci/cloudbuild/dockerfiles/fedora-latest-cmake.Dockerfile b/ci/cloudbuild/dockerfiles/fedora-latest-cmake.Dockerfile index 59104b8e25e64..29fd16a5c6dfe 100644 --- a/ci/cloudbuild/dockerfiles/fedora-latest-cmake.Dockerfile +++ b/ci/cloudbuild/dockerfiles/fedora-latest-cmake.Dockerfile @@ -129,7 +129,7 @@ RUN curl -fsSL https://github.com/nlohmann/json/archive/v3.11.3.tar.gz | \ ldconfig && cd /var/tmp && rm -fr build WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Release \ diff --git a/ci/cloudbuild/dockerfiles/fedora-latest-cxx20.Dockerfile b/ci/cloudbuild/dockerfiles/fedora-latest-cxx20.Dockerfile index e321e2b937c48..72da74b8a3bd2 100644 --- a/ci/cloudbuild/dockerfiles/fedora-latest-cxx20.Dockerfile +++ b/ci/cloudbuild/dockerfiles/fedora-latest-cxx20.Dockerfile @@ -125,7 +125,7 @@ RUN curl -fsSL https://github.com/nlohmann/json/archive/v3.11.3.tar.gz | \ cd /var/tmp && rm -fr build WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_CXX_STANDARD=20 \ diff --git a/ci/cloudbuild/dockerfiles/fedora-latest-publish-docs.Dockerfile b/ci/cloudbuild/dockerfiles/fedora-latest-publish-docs.Dockerfile index a12b7d08dc146..6f61906d26921 100644 --- a/ci/cloudbuild/dockerfiles/fedora-latest-publish-docs.Dockerfile +++ b/ci/cloudbuild/dockerfiles/fedora-latest-publish-docs.Dockerfile @@ -88,7 +88,7 @@ RUN curl -fsSL https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.24 ldconfig && cd /var/tmp && rm -fr build WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Release \ diff --git a/ci/cloudbuild/dockerfiles/gcc-oldest.Dockerfile b/ci/cloudbuild/dockerfiles/gcc-oldest.Dockerfile index 9ff742c279af0..83b536ad55b77 100644 --- a/ci/cloudbuild/dockerfiles/gcc-oldest.Dockerfile +++ b/ci/cloudbuild/dockerfiles/gcc-oldest.Dockerfile @@ -84,7 +84,7 @@ RUN curl -fsSL https://github.com/google/benchmark/archive/v1.9.5.tar.gz | \ ldconfig && cd /var/tmp && rm -fr build WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Release \ diff --git a/ci/cloudbuild/dockerfiles/ubuntu-20.04-install.Dockerfile b/ci/cloudbuild/dockerfiles/ubuntu-20.04-install.Dockerfile index 200a068bce1b0..04c896e723cdf 100644 --- a/ci/cloudbuild/dockerfiles/ubuntu-20.04-install.Dockerfile +++ b/ci/cloudbuild/dockerfiles/ubuntu-20.04-install.Dockerfile @@ -110,7 +110,7 @@ RUN curl -fsSL https://github.com/nlohmann/json/archive/v3.11.3.tar.gz | \ WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Release \ diff --git a/ci/cloudbuild/dockerfiles/ubuntu-22.04-install.Dockerfile b/ci/cloudbuild/dockerfiles/ubuntu-22.04-install.Dockerfile index cfc7db4be552b..cb6f0404067e2 100644 --- a/ci/cloudbuild/dockerfiles/ubuntu-22.04-install.Dockerfile +++ b/ci/cloudbuild/dockerfiles/ubuntu-22.04-install.Dockerfile @@ -109,7 +109,7 @@ RUN curl -fsSL https://github.com/nlohmann/json/archive/v3.11.3.tar.gz | \ WORKDIR /var/tmp/build/protobuf -RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Release \ diff --git a/doc/packaging.md b/doc/packaging.md index 3e00e72b6bc98..5e4992b5d267e 100644 --- a/doc/packaging.md +++ b/doc/packaging.md @@ -279,7 +279,7 @@ export PKG_CONFIG_PATH=/usr/local/share/pkgconfig:/usr/lib64/pkgconfig:/usr/loca ```bash mkdir -p $HOME/Downloads/protobuf && cd $HOME/Downloads/protobuf -curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Release \ @@ -421,7 +421,7 @@ sudo ldconfig ```bash mkdir -p $HOME/Downloads/protobuf && cd $HOME/Downloads/protobuf -curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ @@ -594,7 +594,7 @@ sudo ldconfig ```bash mkdir -p $HOME/Downloads/protobuf && cd $HOME/Downloads/protobuf -curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ @@ -740,7 +740,7 @@ Google Cloud Platform proto files: ```bash mkdir -p $HOME/Downloads/protobuf && cd $HOME/Downloads/protobuf -curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ @@ -907,7 +907,7 @@ sudo ldconfig ```bash mkdir -p $HOME/Downloads/protobuf && cd $HOME/Downloads/protobuf -curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ @@ -1072,7 +1072,7 @@ to build from source: ```bash mkdir -p $HOME/Downloads/protobuf && cd $HOME/Downloads/protobuf -curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ @@ -1249,7 +1249,7 @@ install Protobuf (and any downstream packages) from source. ```bash mkdir -p $HOME/Downloads/protobuf && cd $HOME/Downloads/protobuf -curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.6.tar.gz | \ +curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v36.0-rc2.tar.gz | \ tar -xzf - --strip-components=1 && \ cmake \ -DCMAKE_BUILD_TYPE=Debug \ diff --git a/generator/integration_tests/tests/golden_kitchen_sink_stub_test.cc b/generator/integration_tests/tests/golden_kitchen_sink_stub_test.cc index c93af238b0817..eafe59b340030 100644 --- a/generator/integration_tests/tests/golden_kitchen_sink_stub_test.cc +++ b/generator/integration_tests/tests/golden_kitchen_sink_stub_test.cc @@ -783,7 +783,6 @@ class MockWriteObjectResponse TEST_F(GoldenKitchenSinkStubTest, StreamingWrite) { auto context = std::make_shared(); - Request request; EXPECT_CALL(*grpc_stub_, StreamingWriteRaw(context.get(), _)) .WillOnce([](::grpc::ClientContext*, Response*) { auto stream = std::make_unique(); diff --git a/generator/integration_tests/tests/golden_thing_admin_connection_test.cc b/generator/integration_tests/tests/golden_thing_admin_connection_test.cc index ef2d6171bd9a3..799e21c9df843 100644 --- a/generator/integration_tests/tests/golden_thing_admin_connection_test.cc +++ b/generator/integration_tests/tests/golden_thing_admin_connection_test.cc @@ -97,7 +97,6 @@ TEST(GoldenThingAdminConnectionTest, ListDatabases) { ::google::test::admin::database::v1::ListDatabasesResponse page; page.set_next_page_token("page-1"); - ::google::test::admin::database::v1::Database database; page.add_databases()->set_name("db-1"); page.add_databases()->set_name("db-2"); return make_status_or(page); @@ -112,7 +111,6 @@ TEST(GoldenThingAdminConnectionTest, ListDatabases) { ::google::test::admin::database::v1::ListDatabasesResponse page; page.set_next_page_token("page-2"); - ::google::test::admin::database::v1::Database database; page.add_databases()->set_name("db-3"); page.add_databases()->set_name("db-4"); return make_status_or(page); @@ -127,7 +125,6 @@ TEST(GoldenThingAdminConnectionTest, ListDatabases) { ::google::test::admin::database::v1::ListDatabasesResponse page; page.clear_next_page_token(); - ::google::test::admin::database::v1::Database database; page.add_databases()->set_name("db-5"); return make_status_or(page); }); @@ -195,7 +192,7 @@ TEST(GoldenThingAdminConnectionTest, CreateDatabaseSuccess) { op.set_done(true); ::google::test::admin::database::v1::Database database; database.set_name("test-database"); - op.mutable_response()->PackFrom(database); + (void)op.mutable_response()->PackFrom(database); return make_ready_future(make_status_or(op)); }); auto conn = CreateTestingConnection(std::move(mock)); @@ -248,7 +245,7 @@ TEST(GoldenThingAdminConnectionTest, CreateDatabaseStartAwait) { google::longrunning::Operation expected_operation; expected_operation.set_name("test-operation-name"); google::test::admin::database::v1::CreateDatabaseMetadata metadata; - expected_operation.mutable_metadata()->PackFrom(metadata); + (void)expected_operation.mutable_metadata()->PackFrom(metadata); EXPECT_CALL(*mock, CreateDatabase(_, _, _)).WillOnce([&] { return make_status_or(expected_operation); @@ -263,7 +260,7 @@ TEST(GoldenThingAdminConnectionTest, CreateDatabaseStartAwait) { op.set_done(true); ::google::test::admin::database::v1::Database database; database.set_name("test-database"); - op.mutable_response()->PackFrom(database); + (void)op.mutable_response()->PackFrom(database); return make_ready_future(make_status_or(op)); }); @@ -364,7 +361,7 @@ TEST(GoldenThingAdminConnectionTest, UpdateDatabaseDdlSuccess) { op.set_done(true); ::google::test::admin::database::v1::UpdateDatabaseDdlMetadata metadata; metadata.set_database("test-database"); - op.mutable_metadata()->PackFrom(metadata); + (void)op.mutable_metadata()->PackFrom(metadata); return make_ready_future(make_status_or(op)); }); auto conn = CreateTestingConnection(std::move(mock)); @@ -421,7 +418,7 @@ TEST(GoldenThingAdminConnectionTest, UpdateDatabaseDdlStartAwait) { google::longrunning::Operation expected_operation; expected_operation.set_name("test-operation-name"); google::test::admin::database::v1::UpdateDatabaseDdlMetadata metadata; - expected_operation.mutable_metadata()->PackFrom(metadata); + (void)expected_operation.mutable_metadata()->PackFrom(metadata); EXPECT_CALL(*mock, UpdateDatabaseDdl(_, _, _)).WillOnce([&] { return make_status_or(expected_operation); @@ -436,7 +433,7 @@ TEST(GoldenThingAdminConnectionTest, UpdateDatabaseDdlStartAwait) { op.set_done(true); ::google::test::admin::database::v1::UpdateDatabaseDdlMetadata metadata; metadata.set_database("test-database"); - op.mutable_metadata()->PackFrom(metadata); + (void)op.mutable_metadata()->PackFrom(metadata); return make_ready_future(make_status_or(op)); }); @@ -787,7 +784,7 @@ TEST(GoldenThingAdminConnectionTest, CreateBackupSuccess) { op.set_done(true); ::google::test::admin::database::v1::Backup backup; backup.set_name("test-backup"); - op.mutable_response()->PackFrom(backup); + (void)op.mutable_response()->PackFrom(backup); return make_ready_future(make_status_or(op)); }); auto conn = CreateTestingConnection(std::move(mock)); @@ -843,7 +840,7 @@ TEST(GoldenThingAdminConnectionTest, CreateBackupStartAwait) { google::longrunning::Operation expected_operation; expected_operation.set_name("test-operation-name"); google::test::admin::database::v1::CreateBackupMetadata metadata; - expected_operation.mutable_metadata()->PackFrom(metadata); + (void)expected_operation.mutable_metadata()->PackFrom(metadata); EXPECT_CALL(*mock, CreateBackup(_, _, _)).WillOnce([&] { return make_status_or(expected_operation); @@ -858,7 +855,7 @@ TEST(GoldenThingAdminConnectionTest, CreateBackupStartAwait) { op.set_done(true); ::google::test::admin::database::v1::Backup backup; backup.set_name("test-backup"); - op.mutable_response()->PackFrom(backup); + (void)op.mutable_response()->PackFrom(backup); return make_ready_future(make_status_or(op)); }); @@ -1155,7 +1152,7 @@ TEST(GoldenThingAdminConnectionTest, RestoreDatabaseSuccess) { op.set_done(true); ::google::test::admin::database::v1::Database database; database.set_name("test-database"); - op.mutable_response()->PackFrom(database); + (void)op.mutable_response()->PackFrom(database); return make_ready_future(make_status_or(op)); }); auto conn = CreateTestingConnection(std::move(mock)); @@ -1213,7 +1210,7 @@ TEST(GoldenThingAdminConnectionTest, RestoreDatabaseStartAwait) { google::longrunning::Operation expected_operation; expected_operation.set_name("test-operation-name"); google::test::admin::database::v1::RestoreDatabaseMetadata metadata; - expected_operation.mutable_metadata()->PackFrom(metadata); + (void)expected_operation.mutable_metadata()->PackFrom(metadata); EXPECT_CALL(*mock, RestoreDatabase(_, _, _)).WillOnce([&] { return make_status_or(expected_operation); @@ -1228,7 +1225,7 @@ TEST(GoldenThingAdminConnectionTest, RestoreDatabaseStartAwait) { op.set_done(true); ::google::test::admin::database::v1::Database database; database.set_name("test-database"); - op.mutable_response()->PackFrom(database); + (void)op.mutable_response()->PackFrom(database); return make_ready_future(make_status_or(op)); }); diff --git a/generator/integration_tests/tests/golden_thing_admin_rest_connection_test.cc b/generator/integration_tests/tests/golden_thing_admin_rest_connection_test.cc index 721ff35c2e208..e7082c43bcf6e 100644 --- a/generator/integration_tests/tests/golden_thing_admin_rest_connection_test.cc +++ b/generator/integration_tests/tests/golden_thing_admin_rest_connection_test.cc @@ -98,7 +98,6 @@ TEST(GoldenThingAdminConnectionTest, ListDatabases) { ::google::test::admin::database::v1::ListDatabasesResponse page; page.set_next_page_token("page-1"); - ::google::test::admin::database::v1::Database database; page.add_databases()->set_name("db-1"); page.add_databases()->set_name("db-2"); return make_status_or(page); @@ -113,7 +112,6 @@ TEST(GoldenThingAdminConnectionTest, ListDatabases) { ::google::test::admin::database::v1::ListDatabasesResponse page; page.set_next_page_token("page-2"); - ::google::test::admin::database::v1::Database database; page.add_databases()->set_name("db-3"); page.add_databases()->set_name("db-4"); return make_status_or(page); @@ -128,7 +126,6 @@ TEST(GoldenThingAdminConnectionTest, ListDatabases) { ::google::test::admin::database::v1::ListDatabasesResponse page; page.clear_next_page_token(); - ::google::test::admin::database::v1::Database database; page.add_databases()->set_name("db-5"); return make_status_or(page); }); @@ -201,7 +198,7 @@ TEST(GoldenThingAdminConnectionTest, CreateDatabaseSuccess) { op.set_done(true); ::google::test::admin::database::v1::Database database; database.set_name("test-database"); - op.mutable_response()->PackFrom(database); + (void)op.mutable_response()->PackFrom(database); return make_ready_future(make_status_or(op)); }); auto conn = CreateTestingConnection(std::move(mock)); @@ -260,7 +257,7 @@ TEST(GoldenThingAdminConnectionTest, CreateDatabaseStartAwait) { google::longrunning::Operation expected_operation; expected_operation.set_name("test-operation-name"); google::test::admin::database::v1::CreateDatabaseMetadata metadata; - expected_operation.mutable_metadata()->PackFrom(metadata); + (void)expected_operation.mutable_metadata()->PackFrom(metadata); EXPECT_CALL(*mock, CreateDatabase(_, _, _)).WillOnce([&] { return make_status_or(expected_operation); @@ -275,7 +272,7 @@ TEST(GoldenThingAdminConnectionTest, CreateDatabaseStartAwait) { op.set_done(true); ::google::test::admin::database::v1::Database database; database.set_name("test-database"); - op.mutable_response()->PackFrom(database); + (void)op.mutable_response()->PackFrom(database); return make_ready_future(make_status_or(op)); }); @@ -381,7 +378,7 @@ TEST(GoldenThingAdminConnectionTest, UpdateDatabaseDdlSuccess) { op.set_done(true); ::google::test::admin::database::v1::UpdateDatabaseDdlMetadata metadata; metadata.set_database("test-database"); - op.mutable_metadata()->PackFrom(metadata); + (void)op.mutable_metadata()->PackFrom(metadata); return make_ready_future(make_status_or(op)); }); auto conn = CreateTestingConnection(std::move(mock)); @@ -444,7 +441,7 @@ TEST(GoldenThingAdminRestConnectionTest, UpdateDatabaseDdlStartAwait) { google::longrunning::Operation expected_operation; expected_operation.set_name("test-operation-name"); google::test::admin::database::v1::UpdateDatabaseDdlMetadata metadata; - expected_operation.mutable_metadata()->PackFrom(metadata); + (void)expected_operation.mutable_metadata()->PackFrom(metadata); EXPECT_CALL(*mock, UpdateDatabaseDdl(_, _, _)).WillOnce([&] { return make_status_or(expected_operation); @@ -459,7 +456,7 @@ TEST(GoldenThingAdminRestConnectionTest, UpdateDatabaseDdlStartAwait) { op.set_done(true); ::google::test::admin::database::v1::UpdateDatabaseDdlMetadata metadata; metadata.set_database("test-database"); - op.mutable_metadata()->PackFrom(metadata); + (void)op.mutable_metadata()->PackFrom(metadata); return make_ready_future(make_status_or(op)); }); @@ -815,7 +812,7 @@ TEST(GoldenThingAdminConnectionTest, CreateBackupSuccess) { op.set_done(true); ::google::test::admin::database::v1::Backup backup; backup.set_name("test-backup"); - op.mutable_response()->PackFrom(backup); + (void)op.mutable_response()->PackFrom(backup); return make_ready_future(make_status_or(op)); }); auto conn = CreateTestingConnection(std::move(mock)); @@ -877,7 +874,7 @@ TEST(GoldenThingAdminConnectionTest, CreateBackupStartAwait) { google::longrunning::Operation expected_operation; expected_operation.set_name("test-operation-name"); google::test::admin::database::v1::CreateBackupMetadata metadata; - expected_operation.mutable_metadata()->PackFrom(metadata); + (void)expected_operation.mutable_metadata()->PackFrom(metadata); EXPECT_CALL(*mock, CreateBackup(_, _, _)).WillOnce([&] { return make_status_or(expected_operation); @@ -892,7 +889,7 @@ TEST(GoldenThingAdminConnectionTest, CreateBackupStartAwait) { op.set_done(true); ::google::test::admin::database::v1::Backup backup; backup.set_name("test-backup"); - op.mutable_response()->PackFrom(backup); + (void)op.mutable_response()->PackFrom(backup); return make_ready_future(make_status_or(op)); }); @@ -1194,7 +1191,7 @@ TEST(GoldenThingAdminConnectionTest, RestoreDatabaseSuccess) { op.set_done(true); ::google::test::admin::database::v1::Database database; database.set_name("test-database"); - op.mutable_response()->PackFrom(database); + (void)op.mutable_response()->PackFrom(database); return make_ready_future(make_status_or(op)); }); auto conn = CreateTestingConnection(std::move(mock)); @@ -1254,7 +1251,7 @@ TEST(GoldenThingAdminConnectionTest, RestoreDatabaseStartAwait) { google::longrunning::Operation expected_operation; expected_operation.set_name("test-operation-name"); google::test::admin::database::v1::RestoreDatabaseMetadata metadata; - expected_operation.mutable_metadata()->PackFrom(metadata); + (void)expected_operation.mutable_metadata()->PackFrom(metadata); EXPECT_CALL(*mock, RestoreDatabase(_, _, _)).WillOnce([&] { return make_status_or(expected_operation); @@ -1269,7 +1266,7 @@ TEST(GoldenThingAdminConnectionTest, RestoreDatabaseStartAwait) { op.set_done(true); ::google::test::admin::database::v1::Database database; database.set_name("test-database"); - op.mutable_response()->PackFrom(database); + (void)op.mutable_response()->PackFrom(database); return make_ready_future(make_status_or(op)); }); diff --git a/generator/integration_tests/tests/request_id_connection_impl_test.cc b/generator/integration_tests/tests/request_id_connection_impl_test.cc index bf65a4fcc78cb..caad6d32bde25 100644 --- a/generator/integration_tests/tests/request_id_connection_impl_test.cc +++ b/generator/integration_tests/tests/request_id_connection_impl_test.cc @@ -191,7 +191,7 @@ TEST(RequestIdTest, Lro) { EXPECT_CALL(*mock, AsyncGetOperation).WillOnce([] { google::longrunning::Operation result; result.set_done(true); - result.mutable_response()->PackFrom(Foo{}); + (void)result.mutable_response()->PackFrom(Foo{}); return make_ready_future(make_status_or(std::move(result))); }); @@ -216,7 +216,7 @@ TEST(RequestIdTest, LroExplicit) { EXPECT_CALL(*mock, AsyncGetOperation).WillOnce([] { google::longrunning::Operation result; result.set_done(true); - result.mutable_response()->PackFrom(Foo{}); + (void)result.mutable_response()->PackFrom(Foo{}); return make_ready_future(make_status_or(std::move(result))); }); diff --git a/generator/integration_tests/tests/request_id_tracing_stub_test.cc b/generator/integration_tests/tests/request_id_tracing_stub_test.cc index fb4f9fbaa1562..46033600ea904 100644 --- a/generator/integration_tests/tests/request_id_tracing_stub_test.cc +++ b/generator/integration_tests/tests/request_id_tracing_stub_test.cc @@ -169,7 +169,7 @@ TEST(RequestIdTracingStubTest, Lro) { EXPECT_TRUE(ThereIsAnActiveSpan()); google::longrunning::Operation result; result.set_done(true); - result.mutable_response()->PackFrom(Foo{}); + (void)result.mutable_response()->PackFrom(Foo{}); return make_ready_future(make_status_or(std::move(result))); }); diff --git a/generator/internal/descriptor_utils.cc b/generator/internal/descriptor_utils.cc index 7d54fa58b0b26..b2d4cf9a9fc56 100644 --- a/generator/internal/descriptor_utils.cc +++ b/generator/internal/descriptor_utils.cc @@ -345,7 +345,7 @@ std::string FormattedCommentsForParameter( google::protobuf::FieldDescriptor const* parameter_descriptor = input_type->FindFieldByName(parameter); google::protobuf::SourceLocation loc; - parameter_descriptor->GetSourceLocation(&loc); + (void)parameter_descriptor->GetSourceLocation(&loc); auto comment = EscapePrinterDelimiter(ChompByValue(loc.leading_comments)); // This is an arbitrary threshold. The intent is to simplify the generator // code for corner cases. In the few cases where the documentation of a field @@ -897,7 +897,7 @@ std::map ParseIdempotencyOverrides( absl::StrSplit(idempotency_override, absl::ByChar(':')); auto idempotency = ServiceConfiguration::IdempotencyOverride::NON_IDEMPOTENT; - ServiceConfiguration::IdempotencyOverride::Idempotency_Parse( + (void)ServiceConfiguration::IdempotencyOverride::Idempotency_Parse( override_splits.second, &idempotency); parsed_overrides[override_splits.first] = (idempotency == ServiceConfiguration::IdempotencyOverride::IDEMPOTENT diff --git a/generator/internal/doxygen.cc b/generator/internal/doxygen.cc index 4066e429b85e3..986f6721d7b0c 100644 --- a/generator/internal/doxygen.cc +++ b/generator/internal/doxygen.cc @@ -23,7 +23,7 @@ namespace generator_internal { std::string FormatDoxygenLink( google::protobuf::Descriptor const& message_type) { google::protobuf::SourceLocation loc; - message_type.GetSourceLocation(&loc); + (void)message_type.GetSourceLocation(&loc); std::string output_type_proto_file_name{message_type.file()->name()}; return absl::StrCat( "@googleapis_link{", ProtoNameToCppName(message_type.full_name()), ",", diff --git a/generator/internal/format_method_comments.cc b/generator/internal/format_method_comments.cc index 8271493137361..799861e5799b1 100644 --- a/generator/internal/format_method_comments.cc +++ b/generator/internal/format_method_comments.cc @@ -53,7 +53,7 @@ auto constexpr kDeprecationComment = R"""( @deprecated This RPC is deprecated. ProtoDefinitionLocation Location(google::protobuf::Descriptor const& d) { google::protobuf::SourceLocation loc; - d.GetSourceLocation(&loc); + (void)d.GetSourceLocation(&loc); return ProtoDefinitionLocation{std::string{d.file()->name()}, loc.start_line + 1}; } diff --git a/generator/internal/pagination_test.cc b/generator/internal/pagination_test.cc index 35ae79e707b95..c15f1ab439eaa 100644 --- a/generator/internal/pagination_test.cc +++ b/generator/internal/pagination_test.cc @@ -605,10 +605,12 @@ class BigQueryTestFixture public: void AddDependenciesToDatabase() { FileDescriptorProto proto_file; - google::protobuf::TextFormat::ParseFromString(kProtobufText, &proto_file); + (void)google::protobuf::TextFormat::ParseFromString(kProtobufText, + &proto_file); simple_db_.Add(proto_file); FileDescriptorProto bq_file; - google::protobuf::TextFormat::ParseFromString(kBigQueryText, &bq_file); + (void)google::protobuf::TextFormat::ParseFromString(kBigQueryText, + &bq_file); simple_db_.Add(bq_file); } diff --git a/generator/internal/resolve_comment_references.cc b/generator/internal/resolve_comment_references.cc index b7aa53c158dbe..2e3f7045fd151 100644 --- a/generator/internal/resolve_comment_references.cc +++ b/generator/internal/resolve_comment_references.cc @@ -28,7 +28,7 @@ std::optional> GetLocation( Descriptor const* d) { if (d == nullptr) return std::nullopt; google::protobuf::SourceLocation loc; - d->GetSourceLocation(&loc); + (void)d->GetSourceLocation(&loc); return std::make_pair(std::string{d->full_name()}, ProtoDefinitionLocation{std::string{d->file()->name()}, loc.start_line + 1}); diff --git a/generator/internal/resolve_method_return.cc b/generator/internal/resolve_method_return.cc index e2bb73566f485..387f574f0c1d7 100644 --- a/generator/internal/resolve_method_return.cc +++ b/generator/internal/resolve_method_return.cc @@ -27,7 +27,7 @@ namespace { ProtoDefinitionLocation Location(google::protobuf::Descriptor const& d) { google::protobuf::SourceLocation loc; - d.GetSourceLocation(&loc); + (void)d.GetSourceLocation(&loc); return ProtoDefinitionLocation{std::string{d.file()->name()}, loc.start_line + 1}; } diff --git a/generator/internal/service_code_generator.cc b/generator/internal/service_code_generator.cc index 2f498b65a23a5..b7b1dad62bf38 100644 --- a/generator/internal/service_code_generator.cc +++ b/generator/internal/service_code_generator.cc @@ -95,7 +95,7 @@ ServiceCodeGenerator::ServiceCodeGenerator( ServiceCodeGenerator::ServiceConfiguration::EndpointLocationStyle ServiceCodeGenerator::EndpointLocationStyle() const { auto endpoint_location_style = ServiceConfiguration::LOCATION_INDEPENDENT; - ServiceConfiguration::EndpointLocationStyle_Parse( + (void)ServiceConfiguration::EndpointLocationStyle_Parse( vars("endpoint_location_style"), &endpoint_location_style); return endpoint_location_style; } diff --git a/google/cloud/bigquerycontrol/integration_tests/job_integration_test.cc b/google/cloud/bigquerycontrol/integration_tests/job_integration_test.cc index be062026831a1..7f68c5a28eac1 100644 --- a/google/cloud/bigquerycontrol/integration_tests/job_integration_test.cc +++ b/google/cloud/bigquerycontrol/integration_tests/job_integration_test.cc @@ -66,7 +66,6 @@ TEST_F(BigQueryJobIntegrationTest, JobCRUD) { query.set_parameter_mode("NAMED"); // Specify value for named integer parameter: @minimum_year - bigquery_proto::QueryParameter minimum_year_param; auto constexpr kMinimumYearParam = R"pb( name: "minimum_year" parameter_type { type: "INT64" } diff --git a/google/cloud/bigtable/internal/metrics_test.cc b/google/cloud/bigtable/internal/metrics_test.cc index d4d924493d737..5e9db61a7b523 100644 --- a/google/cloud/bigtable/internal/metrics_test.cc +++ b/google/cloud/bigtable/internal/metrics_test.cc @@ -2060,7 +2060,6 @@ TEST(ConnectivityErrorCount, MissingResourceLabels) { auto clone = connectivity_error_count.clone(resource_labels, data_labels); grpc::ClientContext client_context; - google::bigtable::v2::ResponseParams response_params; RpcMetadata server_metadata; server_metadata.headers.emplace("server-timing", "gfet4t7; dur=15"); SetServerMetadata(client_context, server_metadata); diff --git a/google/cloud/bigtable/mutations_test.cc b/google/cloud/bigtable/mutations_test.cc index e131ad0d6ced0..eae5739c2ca90 100644 --- a/google/cloud/bigtable/mutations_test.cc +++ b/google/cloud/bigtable/mutations_test.cc @@ -184,14 +184,14 @@ TEST(MutationsTest, FailedMutation) { google::rpc::RetryInfo retry; retry.mutable_retry_delay()->set_seconds(900); retry.mutable_retry_delay()->set_nanos(0); - status.add_details()->PackFrom(retry); + (void)status.add_details()->PackFrom(retry); google::rpc::DebugInfo debug_info; debug_info.add_stack_entries("foo()"); debug_info.add_stack_entries("bar()"); debug_info.add_stack_entries("main()"); debug_info.set_detail("just a test"); - status.add_details()->PackFrom(retry); - status.add_details()->PackFrom(debug_info); + (void)status.add_details()->PackFrom(retry); + (void)status.add_details()->PackFrom(debug_info); FailedMutation fm(std::move(status), 27); EXPECT_EQ(google::cloud::StatusCode::kFailedPrecondition, fm.status().code()); diff --git a/google/cloud/bigtable/tests/instance_admin_emulator.cc b/google/cloud/bigtable/tests/instance_admin_emulator.cc index 40bde479f2cb8..b2db97cd216e6 100644 --- a/google/cloud/bigtable/tests/instance_admin_emulator.cc +++ b/google/cloud/bigtable/tests/instance_admin_emulator.cc @@ -40,7 +40,7 @@ class InstanceAdminEmulator final google::longrunning::Operation* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto constexpr kMaxInstanceIdLength = 33; @@ -64,7 +64,7 @@ class InstanceAdminEmulator final response->set_name("create-instance/" + name); response->set_done(true); auto contents = std::make_unique(); - contents->PackFrom(stored_instance); + (void)contents->PackFrom(stored_instance); response->set_allocated_response(contents.release()); // Add cluster into clusters_ @@ -85,7 +85,7 @@ class InstanceAdminEmulator final btadmin::Instance* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto i = instances_.find(request->name()); @@ -101,7 +101,7 @@ class InstanceAdminEmulator final btadmin::ListInstancesResponse* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; std::string prefix = request->parent() + "/instances/"; @@ -118,7 +118,7 @@ class InstanceAdminEmulator final btadmin::Instance*) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; return grpc::Status(grpc::StatusCode::UNIMPLEMENTED, "not implemented"); @@ -130,7 +130,7 @@ class InstanceAdminEmulator final google::longrunning::Operation* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; std::string name = request->instance().name(); @@ -170,7 +170,7 @@ class InstanceAdminEmulator final response->set_name("update-instance/" + name); response->set_done(true); auto contents = std::make_unique(); - contents->PackFrom(stored_instance); + (void)contents->PackFrom(stored_instance); response->set_allocated_response(contents.release()); return grpc::Status::OK; } @@ -180,7 +180,7 @@ class InstanceAdminEmulator final google::protobuf::Empty*) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto i = instances_.find(request->name()); @@ -203,7 +203,7 @@ class InstanceAdminEmulator final google::longrunning::Operation* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto constexpr kMaxClusterIdLength = 30; @@ -225,7 +225,7 @@ class InstanceAdminEmulator final response->set_name("create-cluster/" + name); response->set_done(true); auto contents = std::make_unique(); - contents->PackFrom(stored_cluster); + (void)contents->PackFrom(stored_cluster); response->set_allocated_response(contents.release()); return grpc::Status::OK; } @@ -237,7 +237,7 @@ class InstanceAdminEmulator final btadmin::Cluster* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto i = clusters_.find(request->name()); @@ -253,7 +253,7 @@ class InstanceAdminEmulator final btadmin::ListClustersResponse* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; // We should only return the clusters for the project embedded in the @@ -294,7 +294,7 @@ class InstanceAdminEmulator final google::longrunning::Operation* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; std::string name = request->name(); @@ -307,7 +307,7 @@ class InstanceAdminEmulator final response->set_name("update-cluster/" + name); response->set_done(true); auto contents = std::make_unique(); - contents->PackFrom(stored_cluster); + (void)contents->PackFrom(stored_cluster); response->set_allocated_response(contents.release()); return grpc::Status::OK; } @@ -317,7 +317,7 @@ class InstanceAdminEmulator final google::protobuf::Empty*) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto i = clusters_.find(request->name()); @@ -333,7 +333,7 @@ class InstanceAdminEmulator final btadmin::AppProfile* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto constexpr kMaxAppProfileIdLength = 50; @@ -364,7 +364,7 @@ class InstanceAdminEmulator final btadmin::AppProfile* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto i = app_profiles_.find(request->name()); @@ -380,7 +380,7 @@ class InstanceAdminEmulator final btadmin::ListAppProfilesResponse* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto const& parent = request->parent(); @@ -398,7 +398,7 @@ class InstanceAdminEmulator final google::longrunning::Operation* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; std::string name = request->app_profile().name(); @@ -427,7 +427,7 @@ class InstanceAdminEmulator final response->set_name("update-app-profile/" + name); response->set_done(true); auto contents = std::make_unique(); - contents->PackFrom(stored_app_profile); + (void)contents->PackFrom(stored_app_profile); response->set_allocated_response(contents.release()); return grpc::Status::OK; } @@ -437,7 +437,7 @@ class InstanceAdminEmulator final google::protobuf::Empty*) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto i = app_profiles_.find(request->name()); @@ -458,7 +458,7 @@ class InstanceAdminEmulator final google::iam::v1::Policy* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto it = policies_.find(request->resource()); @@ -476,7 +476,7 @@ class InstanceAdminEmulator final google::iam::v1::Policy* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto policy = request->policy(); @@ -492,7 +492,7 @@ class InstanceAdminEmulator final google::iam::v1::TestIamPermissionsResponse* response) override { std::unique_lock lk(mu_); std::string request_text; - google::protobuf::TextFormat::PrintToString(*request, &request_text); + (void)google::protobuf::TextFormat::PrintToString(*request, &request_text); std::cout << __func__ << "() request=" << request_text << "\n"; auto it = instances_.find(request->resource()); diff --git a/google/cloud/grpc_error_delegate_test.cc b/google/cloud/grpc_error_delegate_test.cc index 1b96d428b363e..04812fcaffed7 100644 --- a/google/cloud/grpc_error_delegate_test.cc +++ b/google/cloud/grpc_error_delegate_test.cc @@ -54,8 +54,8 @@ std::string MakeErrorDetails(grpc::StatusCode code, std::string message, *retry_info_proto.mutable_retry_delay() = internal::ToDurationProto(retry_info.retry_delay()); - proto.add_details()->PackFrom(error_info_proto); - proto.add_details()->PackFrom(retry_info_proto); + (void)proto.add_details()->PackFrom(error_info_proto); + (void)proto.add_details()->PackFrom(retry_info_proto); return MakeErrorDetails(proto); } diff --git a/google/cloud/internal/async_long_running_operation_test.cc b/google/cloud/internal/async_long_running_operation_test.cc index 98a689a38e44c..1fdfd923ccc64 100644 --- a/google/cloud/internal/async_long_running_operation_test.cc +++ b/google/cloud/internal/async_long_running_operation_test.cc @@ -137,7 +137,7 @@ TEST(AsyncLongRunningTest, RequestPollThenSuccessMetadata) { starting_op.set_name("test-op-name"); google::longrunning::Operation done_op = starting_op; done_op.set_done(true); - done_op.mutable_metadata()->PackFrom(expected); + (void)done_op.mutable_metadata()->PackFrom(expected); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -190,7 +190,7 @@ TEST(AsyncLongRunningTest, RequestPollThenSuccessResponse) { starting_op.set_name("test-op-name"); google::longrunning::Operation done_op = starting_op; done_op.set_done(true); - done_op.mutable_response()->PackFrom(expected); + (void)done_op.mutable_response()->PackFrom(expected); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -315,7 +315,7 @@ TEST(AsyncLongRunningTest, AwaitPollThenSuccessMetadata) { starting_op.set_name("test-op-name"); google::longrunning::Operation done_op = starting_op; done_op.set_done(true); - done_op.mutable_metadata()->PackFrom(expected); + (void)done_op.mutable_metadata()->PackFrom(expected); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -356,7 +356,7 @@ TEST(AsyncLongRunningTest, AwaitPollThenSuccessResponse) { starting_op.set_name("test-op-name"); google::longrunning::Operation done_op = starting_op; done_op.set_done(true); - done_op.mutable_response()->PackFrom(expected); + (void)done_op.mutable_response()->PackFrom(expected); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) diff --git a/google/cloud/internal/async_polling_loop_test.cc b/google/cloud/internal/async_polling_loop_test.cc index 2ca520c9efb99..68d5381105230 100644 --- a/google/cloud/internal/async_polling_loop_test.cc +++ b/google/cloud/internal/async_polling_loop_test.cc @@ -102,7 +102,7 @@ TEST(AsyncPollingLoopTest, ImmediateSuccess) { google::longrunning::Operation op; op.set_name("test-op-name"); op.set_done(true); - op.mutable_metadata()->PackFrom(expected); + (void)op.mutable_metadata()->PackFrom(expected); auto mock = std::make_shared(); EXPECT_CALL(*mock, AsyncGetOperation).Times(0); @@ -183,7 +183,7 @@ TEST(AsyncPollingLoopTest, PollThenSuccess) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -253,7 +253,7 @@ TEST(AsyncPollingLoopTest, PollThenEventualSuccess) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -309,7 +309,7 @@ TEST(AsyncPollingLoopTest, PollThenExhaustedPollingPolicy) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -357,7 +357,7 @@ TEST(AsyncPollingLoopTest, PollThenExhaustedPollingPolicyWithFailure) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -404,7 +404,7 @@ TEST(AsyncPollingLoopTest, PollLifetime) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); AsyncSequencer timer_sequencer; auto mock_cq = std::make_shared(); diff --git a/google/cloud/internal/async_rest_long_running_operation_test.cc b/google/cloud/internal/async_rest_long_running_operation_test.cc index 1a91521dd118c..8bf985c668670 100644 --- a/google/cloud/internal/async_rest_long_running_operation_test.cc +++ b/google/cloud/internal/async_rest_long_running_operation_test.cc @@ -133,7 +133,7 @@ TEST(AsyncLongRunningTest, RequestPollThenSuccessMetadata) { starting_op.set_name("test-op-name"); google::longrunning::Operation done_op = starting_op; done_op.set_done(true); - done_op.mutable_metadata()->PackFrom(expected); + (void)done_op.mutable_metadata()->PackFrom(expected); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -188,7 +188,7 @@ TEST(AsyncLongRunningTest, RequestPollThenSuccessResponse) { starting_op.set_name("test-op-name"); google::longrunning::Operation done_op = starting_op; done_op.set_done(true); - done_op.mutable_response()->PackFrom(expected); + (void)done_op.mutable_response()->PackFrom(expected); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -319,7 +319,7 @@ TEST(AsyncLongRunningTest, AwaitPollThenSuccessMetadata) { starting_op.set_name("test-op-name"); google::longrunning::Operation done_op = starting_op; done_op.set_done(true); - done_op.mutable_metadata()->PackFrom(expected); + (void)done_op.mutable_metadata()->PackFrom(expected); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -362,7 +362,7 @@ TEST(AsyncLongRunningTest, AwaitPollThenSuccessResponse) { starting_op.set_name("test-op-name"); google::longrunning::Operation done_op = starting_op; done_op.set_done(true); - done_op.mutable_response()->PackFrom(expected); + (void)done_op.mutable_response()->PackFrom(expected); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) diff --git a/google/cloud/internal/async_rest_polling_loop_test.cc b/google/cloud/internal/async_rest_polling_loop_test.cc index b382b427bf8be..6c03915e9b5ab 100644 --- a/google/cloud/internal/async_rest_polling_loop_test.cc +++ b/google/cloud/internal/async_rest_polling_loop_test.cc @@ -102,7 +102,7 @@ TEST(AsyncRestPollingLoopTest, ImmediateSuccess) { google::longrunning::Operation op; op.set_name("test-op-name"); op.set_done(true); - op.mutable_metadata()->PackFrom(expected); + (void)op.mutable_metadata()->PackFrom(expected); auto mock = std::make_shared(); EXPECT_CALL(*mock, AsyncGetOperation).Times(0); @@ -187,7 +187,7 @@ TEST(AsyncRestPollingLoopTest, PollThenSuccess) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -262,7 +262,7 @@ TEST(AsyncRestPollingLoopTest, PollThenEventualSuccess) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -323,7 +323,7 @@ TEST(AsyncRestPollingLoopTest, PollThenExhaustedPollingPolicy) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -371,7 +371,7 @@ TEST(AsyncRestPollingLoopTest, PollThenExhaustedPollingPolicyWithFailure) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); auto mock_cq = std::make_shared(); EXPECT_CALL(*mock_cq, MakeRelativeTimer) @@ -418,7 +418,7 @@ TEST(AsyncRestPollingLoopTest, PollLifetime) { starting_op.set_name("test-op-name"); google::longrunning::Operation expected = starting_op; expected.set_done(true); - expected.mutable_metadata()->PackFrom(response); + (void)expected.mutable_metadata()->PackFrom(response); AsyncSequencer timer_sequencer; auto mock_cq = std::make_shared(); diff --git a/google/cloud/internal/debug_string_protobuf.cc b/google/cloud/internal/debug_string_protobuf.cc index e652d2458bbd5..66c8a3284cf1e 100644 --- a/google/cloud/internal/debug_string_protobuf.cc +++ b/google/cloud/internal/debug_string_protobuf.cc @@ -79,7 +79,7 @@ std::string DebugString(google::protobuf::Message const& m, new DurationMessagePrinter); p.RegisterMessagePrinter(google::protobuf::Timestamp::descriptor(), new TimestampMessagePrinter); - p.PrintToString(m, &str); + (void)p.PrintToString(m, &str); return absl::StrCat(m.GetTypeName(), " {", (options.single_line_mode() ? " " : "\n"), str, "}"); } diff --git a/google/cloud/internal/debug_string_status_test.cc b/google/cloud/internal/debug_string_status_test.cc index 008605e063309..45d74affb10b3 100644 --- a/google/cloud/internal/debug_string_status_test.cc +++ b/google/cloud/internal/debug_string_status_test.cc @@ -36,7 +36,7 @@ TEST(DebugStringStatus, Basic) { auto proto = google::rpc::Status(); proto.set_code(static_cast(StatusCode::kInvalidArgument)); proto.set_message("oh noes!"); - proto.add_details()->PackFrom(detail); + (void)proto.add_details()->PackFrom(detail); auto const status = MakeStatusFromRpcError(proto); auto const actual = DebugString(status, TracingOptions()); @@ -55,7 +55,7 @@ TEST(DebugStringStatus, WithDetails) { google::rpc::Status proto; proto.set_code(grpc::StatusCode::NOT_FOUND); proto.set_message("Resource not found"); - proto.add_details()->PackFrom(resource_info); + (void)proto.add_details()->PackFrom(resource_info); TracingOptions tracing_options; auto s = DebugString(MakeStatusFromRpcError(proto), tracing_options); diff --git a/google/cloud/internal/extract_long_running_result.cc b/google/cloud/internal/extract_long_running_result.cc index f0ac481306931..1100e34c1cf9e 100644 --- a/google/cloud/internal/extract_long_running_result.cc +++ b/google/cloud/internal/extract_long_running_result.cc @@ -44,7 +44,7 @@ Status ExtractOperationResultMetadataImpl( op->name(), GCP_ERROR_INFO()); } - any.UnpackTo(&result); + (void)any.UnpackTo(&result); return Status{}; } @@ -71,7 +71,7 @@ Status ExtractOperationResultResponseImpl( op->name(), GCP_ERROR_INFO()); } - any.UnpackTo(&result); + (void)any.UnpackTo(&result); return Status{}; } diff --git a/google/cloud/internal/extract_long_running_result_test.cc b/google/cloud/internal/extract_long_running_result_test.cc index 7eb810a85416e..ca88ffa9bd4d1 100644 --- a/google/cloud/internal/extract_long_running_result_test.cc +++ b/google/cloud/internal/extract_long_running_result_test.cc @@ -37,7 +37,7 @@ TEST(ExtractLongRunningResultTest, MetadataDoneWithSuccess) { expected.set_seconds(123456); google::longrunning::Operation op; op.set_done(true); - op.mutable_metadata()->PackFrom(expected); + (void)op.mutable_metadata()->PackFrom(expected); auto const actual = ExtractLongRunningResultMetadata(op, "test-function"); ASSERT_STATUS_OK(actual); @@ -66,7 +66,7 @@ TEST(ExtractLongRunningResultTest, MetadataDoneWithoutResult) { TEST(ExtractLongRunningResultTest, MetadataDoneWithInvalidContent) { google::longrunning::Operation op; op.set_done(true); - op.mutable_metadata()->PackFrom(google::protobuf::Empty{}); + (void)op.mutable_metadata()->PackFrom(google::protobuf::Empty{}); auto const actual = ExtractLongRunningResultMetadata(op, "test-function"); EXPECT_THAT(actual, StatusIs(StatusCode::kInternal, @@ -87,7 +87,7 @@ TEST(ExtractLongRunningResultTest, ResponseDoneWithSuccess) { expected.set_seconds(123456); google::longrunning::Operation op; op.set_done(true); - op.mutable_response()->PackFrom(expected); + (void)op.mutable_response()->PackFrom(expected); auto const actual = ExtractLongRunningResultResponse(op, "test-function"); ASSERT_STATUS_OK(actual); @@ -116,7 +116,7 @@ TEST(ExtractLongRunningResultTest, ResponseDoneWithoutResult) { TEST(ExtractLongRunningResultTest, ResponseDoneWithInvalidContent) { google::longrunning::Operation op; op.set_done(true); - op.mutable_response()->PackFrom(google::protobuf::Empty{}); + (void)op.mutable_response()->PackFrom(google::protobuf::Empty{}); auto const actual = ExtractLongRunningResultResponse(op, "test-function"); EXPECT_THAT(actual, StatusIs(StatusCode::kInternal, diff --git a/google/cloud/pubsub/message.cc b/google/cloud/pubsub/message.cc index 577beedc0bd17..4b3dfd25f7188 100644 --- a/google/cloud/pubsub/message.cc +++ b/google/cloud/pubsub/message.cc @@ -87,7 +87,7 @@ std::ostream& operator<<(std::ostream& os, Message const& rhs) { p.SetSingleLineMode(true); p.SetTruncateStringFieldLongerThan(kMaximumPayloadBytes); std::string text; - p.PrintToString(rhs.proto_, &text); + (void)p.PrintToString(rhs.proto_, &text); return os << text; } diff --git a/google/cloud/pubsub/samples/samples.cc b/google/cloud/pubsub/samples/samples.cc index a71b29fd4b510..94d500be6dcb3 100644 --- a/google/cloud/pubsub/samples/samples.cc +++ b/google/cloud/pubsub/samples/samples.cc @@ -237,7 +237,7 @@ google::cloud::future SubscribeProtobufRecords( auto session = subscriber.Subscribe( [](pubsub::Message const& m, pubsub::AckHandler h) { google::cloud::pubsub::samples::State state; - state.ParseFromString(std::string{m.data()}); + (void)state.ParseFromString(std::string{m.data()}); std::cout << "Message contents: " << state.DebugString() << "\n"; std::move(h).ack(); }); diff --git a/google/cloud/spanner/admin/integration_tests/backup_integration_test.cc b/google/cloud/spanner/admin/integration_tests/backup_integration_test.cc index 14085985883d5..e88209a53f4c7 100644 --- a/google/cloud/spanner/admin/integration_tests/backup_integration_test.cc +++ b/google/cloud/spanner/admin/integration_tests/backup_integration_test.cc @@ -158,7 +158,7 @@ TEST_F(BackupIntegrationTest, BackupRestore) { database_admin_client_.ListBackupOperations(lreq)) { if (!operation) break; google::spanner::admin::database::v1::CreateBackupMetadata metadata; - operation->metadata().UnpackTo(&metadata); + (void)operation->metadata().UnpackTo(&metadata); db_names.push_back(metadata.database()); } if (Emulator()) { @@ -229,7 +229,7 @@ TEST_F(BackupIntegrationTest, BackupRestore) { database_admin_client_.ListDatabaseOperations(dreq)) { if (!operation) break; google::spanner::admin::database::v1::OptimizeRestoredDatabaseMetadata md; - operation->metadata().UnpackTo(&md); + (void)operation->metadata().UnpackTo(&md); restored_db_names.push_back(md.name()); } EXPECT_LE(1, std::count(restored_db_names.begin(), restored_db_names.end(), diff --git a/google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc b/google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc index edfd09d82e1e6..92c881035e736 100644 --- a/google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc +++ b/google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc @@ -588,7 +588,6 @@ class ReadExperiment : public BasicExperiment { *request.mutable_key_set() = spanner_internal::ToProto(key); int row_count = 0; - google::spanner::v1::PartialResultSet result; std::vector row; row.resize(columns.size()); auto stream = stub->StreamingRead(std::make_shared(), @@ -736,7 +735,6 @@ class SelectExperiment : public BasicExperiment { std::move(end_type_value.second); int row_count = 0; - google::spanner::v1::PartialResultSet result; std::vector row; row.resize(ExperimentImpl::kColumnCount); auto stream = diff --git a/google/cloud/spanner/internal/connection_impl_test.cc b/google/cloud/spanner/internal/connection_impl_test.cc index 9a94725998a7f..c3c372013a05d 100644 --- a/google/cloud/spanner/internal/connection_impl_test.cc +++ b/google/cloud/spanner/internal/connection_impl_test.cc @@ -2945,7 +2945,6 @@ TEST(ConnectionImplTest, MultiplexedPrecommitUpdated) { } )pb"}; - google::spanner::v1::PartialResultSet result_set; EXPECT_CALL(*mock, StreamingRead) .WillOnce(Return(ByMove(MakeReader({response})))); diff --git a/google/cloud/spanner/proto_message.h b/google/cloud/spanner/proto_message.h index 2c75dc5388973..3c6d1dd46b15e 100644 --- a/google/cloud/spanner/proto_message.h +++ b/google/cloud/spanner/proto_message.h @@ -56,7 +56,7 @@ class ProtoMessage { /// Implicit construction from the message type. // NOLINTNEXTLINE(google-explicit-constructor) - ProtoMessage(M const& m) { m.SerializeToString(&serialized_message_); } + ProtoMessage(M const& m) { (void)m.SerializeToString(&serialized_message_); } /// Explicit construction from wire format. explicit ProtoMessage(std::string serialized_message) @@ -65,7 +65,7 @@ class ProtoMessage { /// Explicit conversion to the message type. explicit operator message_type() const { message_type m; - m.ParseFromString(serialized_message_); + (void)m.ParseFromString(serialized_message_); return m; } diff --git a/google/cloud/spanner/samples/samples.cc b/google/cloud/spanner/samples/samples.cc index f198b32e695b8..25f076bf103e9 100644 --- a/google/cloud/spanner/samples/samples.cc +++ b/google/cloud/spanner/samples/samples.cc @@ -217,7 +217,7 @@ void ListInstanceConfigOperations( client.ListInstanceConfigOperations(project.FullName())) { if (!operation) throw std::move(operation).status(); google::spanner::admin::instance::v1::CreateInstanceConfigMetadata metadata; - operation->metadata().UnpackTo(&metadata); + (void)operation->metadata().UnpackTo(&metadata); std::cout << "CreateInstanceConfig metadata is:\n" << metadata.DebugString(); } @@ -229,7 +229,7 @@ void ListInstanceConfigOperations( client.ListInstanceConfigOperations(project.FullName())) { if (!operation) throw std::move(operation).status(); google::spanner::admin::instance::v1::UpdateInstanceConfigMetadata metadata; - operation->metadata().UnpackTo(&metadata); + (void)operation->metadata().UnpackTo(&metadata); std::cout << "UpdateInstanceConfig metadata is:\n" << metadata.DebugString(); } @@ -1849,7 +1849,7 @@ void ListBackupOperations( for (auto& operation : client.ListBackupOperations(request)) { if (!operation) throw std::move(operation).status(); google::spanner::admin::database::v1::CreateBackupMetadata metadata; - operation->metadata().UnpackTo(&metadata); + (void)operation->metadata().UnpackTo(&metadata); std::cout << "Backup " << metadata.name() << " of database " << metadata.database() << " is " << metadata.progress().progress_percent() << "% complete.\n"; @@ -1861,7 +1861,7 @@ void ListBackupOperations( for (auto& operation : client.ListBackupOperations(request)) { if (!operation) throw std::move(operation).status(); google::spanner::admin::database::v1::CopyBackupMetadata metadata; - operation->metadata().UnpackTo(&metadata); + (void)operation->metadata().UnpackTo(&metadata); std::cout << "Copy " << metadata.name() << " of backup " << metadata.source_backup() << " is " << metadata.progress().progress_percent() << "% complete.\n"; @@ -1894,7 +1894,7 @@ void ListDatabaseOperations( if (!operation) throw std::move(operation).status(); google::spanner::admin::database::v1::OptimizeRestoredDatabaseMetadata metadata; - operation->metadata().UnpackTo(&metadata); + (void)operation->metadata().UnpackTo(&metadata); std::cout << "Database " << metadata.name() << " restored from backup is " << metadata.progress().progress_percent() << "% optimized.\n"; } @@ -4371,7 +4371,7 @@ void AddProtoTypeColumns( .GetMetadata() .descriptor->file() ->CopyTo(fds.add_file()); - fds.SerializeToString(request.mutable_proto_descriptors()); + (void)fds.SerializeToString(request.mutable_proto_descriptors()); request.add_statements(R"""( CREATE PROTO BUNDLE ( google.cloud.spanner.testing.SingerInfo, diff --git a/google/cloud/spanner/testing/database_integration_test.cc b/google/cloud/spanner/testing/database_integration_test.cc index c2f1184ce0bad..74ad48b464e7f 100644 --- a/google/cloud/spanner/testing/database_integration_test.cc +++ b/google/cloud/spanner/testing/database_integration_test.cc @@ -126,7 +126,7 @@ void DatabaseIntegrationTest::SetUpTestSuite() { .GetMetadata() .descriptor->file() ->CopyTo(fds.add_file()); - fds.SerializeToString(request.mutable_proto_descriptors()); + (void)fds.SerializeToString(request.mutable_proto_descriptors()); request.add_extra_statements(R"sql( CREATE PROTO BUNDLE ( google.cloud.spanner.testing.SingerInfo, diff --git a/google/cloud/spanner/testing/status_utils.cc b/google/cloud/spanner/testing/status_utils.cc index 4ee7904e9caed..b55281268151e 100644 --- a/google/cloud/spanner/testing/status_utils.cc +++ b/google/cloud/spanner/testing/status_utils.cc @@ -37,7 +37,7 @@ grpc::Status SessionNotFoundRpcError(std::string name) { google::rpc::Status proto; proto.set_code(grpc::StatusCode::NOT_FOUND); proto.set_message("Session not found"); - proto.add_details()->PackFrom(resource_info); + (void)proto.add_details()->PackFrom(resource_info); return grpc::Status(grpc::StatusCode::NOT_FOUND, proto.message(), proto.SerializeAsString()); diff --git a/google/cloud/spanner/value.cc b/google/cloud/spanner/value.cc index c0fcf5c683631..39b2007a2e73e 100644 --- a/google/cloud/spanner/value.cc +++ b/google/cloud/spanner/value.cc @@ -186,7 +186,8 @@ std::ostream& StreamHelper(std::ostream& os, // NOLINT(misc-no-recursion) auto* f = google::protobuf::MessageFactory::generated_factory(); if (auto const* pt = f->GetPrototype(d)) { std::unique_ptr m(pt->New()); - m->ParseFromString(std::string(bytes->begin(), bytes->end())); + (void)m->ParseFromString( + std::string(bytes->begin(), bytes->end())); return os << internal::DebugString(*m, TracingOptions{}); } } diff --git a/google/cloud/storage/internal/async/connection_impl_appendable_upload_test.cc b/google/cloud/storage/internal/async/connection_impl_appendable_upload_test.cc index 189af38f74830..a0cb52005b049 100644 --- a/google/cloud/storage/internal/async/connection_impl_appendable_upload_test.cc +++ b/google/cloud/storage/internal/async/connection_impl_appendable_upload_test.cc @@ -464,7 +464,7 @@ TEST_F(AsyncConnectionImplAppendableTest, AppendableUploadRedirect) { redirect.mutable_write_handle()->set_handle("redirect-handle"); redirect.set_routing_token("redirect-token"); redirect.set_generation(4321); - rpc_status.add_details()->PackFrom(redirect); + (void)rpc_status.add_details()->PackFrom(redirect); std::string rpc_status_payload; ASSERT_TRUE(rpc_status.SerializeToString(&rpc_status_payload)); Status status(StatusCode::kAborted, "redirect"); @@ -564,7 +564,7 @@ TEST_F(AsyncConnectionImplAppendableTest, AppendableUploadRedirectNoHandle) { google::storage::v2::BidiWriteObjectRedirectedError redirect; redirect.set_routing_token("redirect-token"); redirect.set_generation(4321); - rpc_status.add_details()->PackFrom(redirect); + (void)rpc_status.add_details()->PackFrom(redirect); std::string rpc_status_payload; ASSERT_TRUE(rpc_status.SerializeToString(&rpc_status_payload)); Status status(StatusCode::kAborted, "redirect"); diff --git a/google/cloud/storage/internal/async/connection_impl_open_test.cc b/google/cloud/storage/internal/async/connection_impl_open_test.cc index 32609f98aec4e..363b9bde12cfa 100644 --- a/google/cloud/storage/internal/async/connection_impl_open_test.cc +++ b/google/cloud/storage/internal/async/connection_impl_open_test.cc @@ -100,10 +100,10 @@ Status RedirectError(absl::string_view handle, absl::string_view token) { auto details_proto = google::rpc::Status{}; details_proto.set_code(grpc::StatusCode::ABORTED); details_proto.set_message("redirect"); - details_proto.add_details()->PackFrom(redirected); + (void)details_proto.add_details()->PackFrom(redirected); std::string details; - details_proto.SerializeToString(&details); + (void)details_proto.SerializeToString(&details); return details; }; diff --git a/google/cloud/storage/internal/async/handle_redirect_error.cc b/google/cloud/storage/internal/async/handle_redirect_error.cc index d8fe1ad0684c4..10a2c27cabfa2 100644 --- a/google/cloud/storage/internal/async/handle_redirect_error.cc +++ b/google/cloud/storage/internal/async/handle_redirect_error.cc @@ -24,7 +24,7 @@ google::rpc::Status ExtractGrpcStatus(Status const& status) { google::rpc::Status proto_status = google::rpc::Status{}; auto payload = google::cloud::internal::GetPayload( status, google::cloud::internal::StatusPayloadGrpcProto()); - if (payload) proto_status.ParseFromString(*payload); + if (payload) (void)proto_status.ParseFromString(*payload); return proto_status; } diff --git a/google/cloud/storage/internal/async/handle_redirect_error_test.cc b/google/cloud/storage/internal/async/handle_redirect_error_test.cc index b3ecca5bb5073..60d2154fb8394 100644 --- a/google/cloud/storage/internal/async/handle_redirect_error_test.cc +++ b/google/cloud/storage/internal/async/handle_redirect_error_test.cc @@ -95,7 +95,7 @@ TEST(ApplyWriteRedirectErrors, Success) { redirect.mutable_write_handle()->set_handle("test-handle"); redirect.set_routing_token("test-token"); redirect.set_generation(1234); - rpc_status.add_details()->PackFrom(redirect); + (void)rpc_status.add_details()->PackFrom(redirect); ApplyWriteRedirectErrors(spec, rpc_status); EXPECT_EQ(spec.bucket(), "projects/_/buckets/test-bucket"); @@ -138,7 +138,7 @@ TEST(HandleBidiWriteRedirect, NoWriteHandle) { google::rpc::Status rpc_status; google::storage::v2::BidiWriteObjectRedirectedError redirect; redirect.set_routing_token("test-token"); - rpc_status.add_details()->PackFrom(redirect); + (void)rpc_status.add_details()->PackFrom(redirect); auto info = HandleBidiWriteRedirect(request, rpc_status); EXPECT_EQ(info.routing_token, "test-token"); @@ -163,7 +163,7 @@ TEST(HandleBidiWriteRedirect, WithWriteHandleForWriteObjectSpec) { redirect.mutable_write_handle()->set_handle("test-handle"); redirect.set_routing_token("test-token"); redirect.set_generation(1234); - rpc_status.add_details()->PackFrom(redirect); + (void)rpc_status.add_details()->PackFrom(redirect); auto info = HandleBidiWriteRedirect(request, rpc_status); EXPECT_EQ(info.routing_token, "test-token"); @@ -199,7 +199,7 @@ TEST(HandleBidiWriteRedirect, WithWriteHandleForAppendObjectSpec) { redirect.mutable_write_handle()->set_handle("test-handle"); redirect.set_routing_token("test-token"); redirect.set_generation(1234); - rpc_status.add_details()->PackFrom(redirect); + (void)rpc_status.add_details()->PackFrom(redirect); auto info = HandleBidiWriteRedirect(request, rpc_status); EXPECT_EQ(info.routing_token, "test-token"); diff --git a/google/cloud/storage/internal/async/object_descriptor_impl_test.cc b/google/cloud/storage/internal/async/object_descriptor_impl_test.cc index d36181bfcf748..723401372173a 100644 --- a/google/cloud/storage/internal/async/object_descriptor_impl_test.cc +++ b/google/cloud/storage/internal/async/object_descriptor_impl_test.cc @@ -891,10 +891,10 @@ Status RedirectError(absl::string_view handle, absl::string_view token) { auto details_proto = google::rpc::Status{}; details_proto.set_code(grpc::StatusCode::UNAVAILABLE); details_proto.set_message("redirect"); - details_proto.add_details()->PackFrom(redirected); + (void)details_proto.add_details()->PackFrom(redirected); std::string details; - details_proto.SerializeToString(&details); + (void)details_proto.SerializeToString(&details); return details; }; @@ -1121,10 +1121,10 @@ Status PartialFailure(std::int64_t read_id) { auto details_proto = google::rpc::Status{}; details_proto.set_code(grpc::StatusCode::INVALID_ARGUMENT); details_proto.set_message("some reads are out of range"); - details_proto.add_details()->PackFrom(error); + (void)details_proto.add_details()->PackFrom(error); std::string details; - details_proto.SerializeToString(&details); + (void)details_proto.SerializeToString(&details); return details; }; diff --git a/google/cloud/storage/internal/async/open_object_test.cc b/google/cloud/storage/internal/async/open_object_test.cc index 265cfdfd5ad9e..aabeafef634be 100644 --- a/google/cloud/storage/internal/async/open_object_test.cc +++ b/google/cloud/storage/internal/async/open_object_test.cc @@ -68,7 +68,7 @@ TEST(OpenImpl, RequestParams) { auto params = [](auto text) { auto r = google::storage::v2::BidiReadObjectRequest{}; - TextFormat::ParseFromString(text, &r); + (void)TextFormat::ParseFromString(text, &r); return RequestParams(r); }; EXPECT_EQ(params(kPlain), "bucket=projects/_/buckets/test-bucket-name"); diff --git a/google/cloud/storage/internal/async/writer_connection_finalized_test.cc b/google/cloud/storage/internal/async/writer_connection_finalized_test.cc index 743ad082050d5..86d2a54f10fe3 100644 --- a/google/cloud/storage/internal/async/writer_connection_finalized_test.cc +++ b/google/cloud/storage/internal/async/writer_connection_finalized_test.cc @@ -36,7 +36,7 @@ auto MakeTestObject() { name: "test-object" )pb"; auto object = google::storage::v2::Object{}; - google::protobuf::TextFormat::ParseFromString(kText, &object); + (void)google::protobuf::TextFormat::ParseFromString(kText, &object); return object; } diff --git a/google/cloud/storage/internal/async/writer_connection_impl_test.cc b/google/cloud/storage/internal/async/writer_connection_impl_test.cc index 7e16808831278..7d5c40a902a10 100644 --- a/google/cloud/storage/internal/async/writer_connection_impl_test.cc +++ b/google/cloud/storage/internal/async/writer_connection_impl_test.cc @@ -708,7 +708,7 @@ TEST(AsyncWriterConnectionTest, FlushFailsWithRedirect) { redirect.mutable_write_handle()->set_handle("redirect-handle"); redirect.set_routing_token("redirect-token"); redirect.set_generation(4321); - rpc_status.add_details()->PackFrom(redirect); + (void)rpc_status.add_details()->PackFrom(redirect); std::string rpc_status_payload; ASSERT_TRUE(rpc_status.SerializeToString(&rpc_status_payload)); Status status(StatusCode::kAborted, "redirect");