address review comments

Author: scotthart

google/cloud/bigtable/internal/grpc_metrics_exporter.cc

@@ -290,11 +290,12 @@ MonitoredResourceResult MakeMonitoredResource(
 }
 
 GrpcMetricsPluginConfig MakeGrpcMetricsPluginConfig(
-    opentelemetry::sdk::resource::Resource const& detected_resource,
+    // NOLINTNEXTLINE(performance-unnecessary-value-param)
+    opentelemetry::sdk::resource::Resource detected_resource,
     std::shared_ptr<monitoring_v3::MetricServiceConnection> const& conn,
     Options const& options, std::string const& client_uid) {
   auto dynamic_resource_fn =
-      [options, client_uid, detected_resource](
+      [options, client_uid, detected_resource = std::move(detected_resource)](
           opentelemetry::sdk::metrics::PointDataAttributes const& pda) {
         auto res =
             MakeMonitoredResource(pda, detected_resource, options, client_uid);

google/cloud/bigtable/internal/grpc_metrics_exporter.h

@@ -108,7 +108,7 @@ struct GrpcMetricsPluginConfig {
 };
 
 GrpcMetricsPluginConfig MakeGrpcMetricsPluginConfig(
-    opentelemetry::sdk::resource::Resource const& detected_resource,
+    opentelemetry::sdk::resource::Resource detected_resource,
     std::shared_ptr<monitoring_v3::MetricServiceConnection> const& conn,
     Options const& options, std::string const& client_uid);
 

google/cloud/bigtable/internal/grpc_metrics_exporter_test.cc

@@ -412,6 +412,7 @@ TEST(GrpcMetricsExporterTest, ValidatePluginConfigArguments) {
   Options options;
   options.set<AuthorityOption>("custom-bigtable-authority.googleapis.com");
   options.set<bigtable::AppProfileIdOption>("test-app-profile");
+  options.set<bigtable::MetricsPeriodOption>(std::chrono::seconds(60));
   auto conn = std::make_shared<DummyMetricServiceConnection>();
   std::string const client_uid = "test-client-uid";