From 994f980f27555378f1917f8f7c2f764f7396e297 Mon Sep 17 00:00:00 2001 From: Quratulain-bilal Date: Tue, 4 Aug 2026 02:16:38 +0500 Subject: [PATCH] fix: log progress tracker refresh errors instead of silently swallowing The bare 'except Exception: pass' in StepTracker._maybe_refresh() completely hid rendering bugs in the Rich progress display. Now logs at DEBUG level with full traceback for diagnostics. --- src/specify_cli/_console.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/specify_cli/_console.py b/src/specify_cli/_console.py index 8d1216387f..0e448780ad 100644 --- a/src/specify_cli/_console.py +++ b/src/specify_cli/_console.py @@ -7,6 +7,7 @@ """ from __future__ import annotations +import logging import sys from collections.abc import Callable @@ -21,6 +22,8 @@ from rich.tree import Tree from typer.core import TyperGroup +logger = logging.getLogger(__name__) + BANNER = """ ███████╗██████╗ ███████╗ ██████╗██╗███████╗██╗ ██╗ ██╔════╝██╔══██╗██╔════╝██╔════╝██║██╔════╝╚██╗ ██╔╝ @@ -85,7 +88,7 @@ def _maybe_refresh(self): try: self._refresh_cb() except Exception: - pass + logger.debug("Progress tracker refresh failed", exc_info=True) def render(self): tree = Tree(f"[cyan]{self.title}[/cyan]", guide_style="grey50")