From 795d46e37c63f408c3607ee91b738cdf52ba2dc3 Mon Sep 17 00:00:00 2001 From: Quratulain-bilal Date: Tue, 4 Aug 2026 01:00:25 +0500 Subject: [PATCH] fix: use logger instead of print() for error/warning messages in events.py Replace print(..., file=sys.stderr) calls with logger.error()/warning() for consistent logging behavior. The module already defines logger = logging.getLogger(__name__) and uses it elsewhere, but three messages were using print() which bypasses logging configuration. --- src/specify_cli/events.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/specify_cli/events.py b/src/specify_cli/events.py index d3002fe805..a3635fc268 100644 --- a/src/specify_cli/events.py +++ b/src/specify_cli/events.py @@ -276,10 +276,10 @@ def _run_inline(command_name, payload, project_root, timeout): return result.returncode return 0 except subprocess.TimeoutExpired: - print(f"Event {command_name} timed out", file=sys.stderr) + logger.error("Event %s timed out", command_name) return 2 except Exception as e: - print(f"Event {command_name} error: {e}", file=sys.stderr) + logger.error("Event %s error: %s", command_name, e) return 2 @@ -1070,9 +1070,8 @@ def install_integration_events( if ev in canonical_to_native: filtered[ev] = handlers else: - print( - f"\u26a0\ufe0f {integration.key} does not support '{ev}' events; skipping", - file=sys.stderr, + logger.warning( + "%s does not support '%s' events; skipping", integration.key, ev, ) # #3: an empty resolved map (--events false, or override disabling events)