Stack merging stuck + manually merging bottom up dismissed reviews

[nemith]

I tried to merge my first 4 PR stack eagerly. I have been waiting for stacked PR for years now and think they are important for developer and reviewer velocity (which is made worse by AI on both sides).

Clicked merged. Waited hours. Nothing happened. I have very little workflows to run on merge and it should have been done in minutes if not seconds but nothign happened.

No worries. Stacks are for time shifting developers and reviewers. Merging an entire stack is just connivence. I'll just merge them one by one starting at the bottom.

Oh great. So now manually landing one change made the review stale. I think this is not a great feature before stacks but with stacks this is outright crazy. The whole point was to make reviews easier and now I can't land a full stack and landing each PR in a stack will require re-review.

[floriecai]

Also running into this and it really defeats the purpose of stacks for me. There's no indication of why the squash + merge for the stack is taking so long and when you merge 1 PR, I had to manually merge every subsequent PR manually (then the next one rebases, CI runs, then someone re-reviews due to the stale review).

[leemeichin]

I have the same issue. There is no indication in the UI that I have done anything wrong, and it doesn't warn me if my branch protection rules would somehow stop a stack merge from working. It just hangs.

Merging them one by one from the bottom up just seems to defeat the point of a stack because the rebase and re-review dance is what you would do before this feature anyway.

edit: only way I got it to work was after I temporarily disabled the branch protection rules for requiring codeowner approval and dismissing stale reviews.