False positives in csharp for useless-tostring-call

[rvdginste]

Description of the false positive

I see two contexts in which this generates a false positive:

• override of ToString() that calls base.ToString()
• ToString() call inside the argument to StringBuilder.AppendLine(...)

Code samples or links to source code

public class Test : BaseTest
{
    public override string ToString()
        => $"Test class ToString; TestBase: {base.ToString()}";
}

public class Test
{
   public EnumType Prop { get; set; }

  public override string ToString()
  {
    StringBuilder sb = new();
    sb.AppendLine(Prop.ToString());
    return sb.ToString();
  }
}

[hvitved]

Hi 👋

Thank you for reporting; I agree that both are FPs. Here is a fix: #21726.

[rvdginste]

Hi,

That was fast, thanks for the fix!