From a70259ffb1cca18c9e5adc5406e9c5c222c53b6e Mon Sep 17 00:00:00 2001 From: Dario Valdespino Date: Thu, 12 Nov 2026 10:43:33 -0300 Subject: [PATCH 1/2] docs(komodo): state explicit-bundle and managed cli prerequisites --- CONTRIBUTING.md | 9 ++++--- README.md | 12 +++++---- packages/vscode/CHANGELOG.md | 1 + packages/vscode/README.md | 25 +++++++++++-------- packages/vscode/media/typescript/package.json | 3 +-- packages/vscode/package.json | 2 +- 6 files changed, 29 insertions(+), 23 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e91b002..e3c8705 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -139,10 +139,11 @@ verification loop when upgrading vsce or changing plugin packaging. with every installed extension disabled (as on a machine without the JetBrains extension), and exercises each capability the server advertises through VS Code's provider commands, logging `PASS`/`FAIL`/`SKIP` per check and a count. It also exercises repeated reloads with unsaved declarations, CodeLens after declaration edits/reverts, and -native-service disabled activity reporting/recovery without failing project sync. By default the extension asks the selected Elide CLI to resolve its -managed Komodo component, including its compiler plugins and JDK inputs. Install it explicitly with -`elide komodo install --yes --json` or **Elide: Install Komodo**; ordinary activation and sync never install it. -An older CLI reports an upgrade requirement, without changing the selected language server. +native-service disabled activity reporting/recovery without failing project sync. Managed resolution requires a CLI +implementing `elide komodo resolve --json` and `elide komodo install --yes --json`; a version string is not a capability +probe. If those commands are absent, use the explicit bundle overrides below. With a compatible CLI, install Komodo +explicitly with `elide komodo install --yes --json` or **Elide: Install Komodo**; activation and sync never install it. +An unsupported CLI reports the missing prerequisite without changing the selected language server. For an unpublished local candidate, explicitly authorize the producer's development catalog with `ELIDE_COMPONENTS_HOME=/absolute/temp/components elide komodo install --catalog /absolute/catalog.json --yes --json`. Set `ELIDE_TEST_COMPONENTS_HOME` to that same absolute store when launching integration scenarios. diff --git a/README.md b/README.md index ba8c497..32b66f3 100644 --- a/README.md +++ b/README.md @@ -31,8 +31,10 @@ and a pinned (`&version=`) link. installed separately from the Marketplace. Complete its one-time region / data-sharing setup for Kotlin/Java analysis and JVM debugging. Elide activates independently: sync, build, layoutlib previews and environment diagnostics do not wait for the language server. Opening an Elide Kotlin or Java source document starts the companion when needed. - It is not needed with Komodo (`elide.kotlinLsp.server` = `komodo`), which requires an Elide release with - on-demand Komodo resolution. Choose **Elide: Install Komodo** explicitly; default use never downloads it. + It is not needed with Komodo (`elide.kotlinLsp.server` = `komodo`), which requires either an explicit native bundle + (`elide.kotlinLsp.komodo.path`) or a CLI implementing `elide komodo resolve --json` and `elide komodo install --yes --json`. + Elide's version number alone does not establish managed-component support. CLIs without these commands require + the explicit bundle override. **Elide: Install Komodo** never runs automatically. Missing, incompatible or failed Komodo disables native analysis/debug actions and stops stale native resources, while ordinary project sync and builds remain available. Fix the component or override and sync again to recover without reloading the window; settings are never rewritten and no alternative engine is selected automatically. @@ -599,10 +601,10 @@ standalone `tsc` build. They do not install Node.js types or change the project' | `elide.home` | `""` | Distribution root containing `bin/elide`. | | `elide.jdk.home` | `""` | JDK for symbol resolution; else `jvm.javaHome`, `$JAVA_HOME`, installed JDKs matching `jvm.target`. | | `elide.sync.onStartup` | `true` | Sync when the workspace opens. | -| `elide.sync.onManifestChange` | `"prompt"` | `always` / `prompt` / `never` when `elide.pkl` changes, or when the lockfile's resolved dependencies do. Every `elide` invocation rewrites `.dev/elide.lock*.bin`, so rewrites with unchanged content are ignored. | +| `elide.sync.onManifestChange` | `"prompt"` | `always` / `prompt` / `never` when `elide.pkl` changes, or when the lockfile's resolved dependencies do. Lockfile writes with unchanged content are ignored; current Elide preserves the file when its records have not changed. | | `elide.kotlinLsp.writeWorkspaceJson` | `true` | Write `/workspace.json` for the JetBrains server; never for a Komodo folder. | -| `elide.kotlinLsp.server` | `"jetbrains"` | `komodo` (experimental): native Kotlin services resolved and installed on demand by Elide. | -| `elide.kotlinLsp.komodo.path`, `.pluginDirectory`, `.javaHome`, `.maxHeap` | `""` | Developer overrides for executable, compiler plugins, JDK inputs and heap. Empty uses Elide's managed resolution. | +| `elide.kotlinLsp.server` | `"jetbrains"` | `komodo` (experimental): native Kotlin services; requires an explicit bundle or a CLI with managed Komodo commands. | +| `elide.kotlinLsp.komodo.path`, `.pluginDirectory`, `.javaHome`, `.maxHeap` | `""` | Overrides for executable, compiler plugins, JDK inputs and heap. Empty requires Elide's managed-resolution command. | | `elide.install.classifiers` | `["sources"]` | Classifiers installed for declared Maven packages (`sources`, `docs`); empty installs classes only. Elide's own Kotlin/JUnit jars have none. | | `elide.flags` | `[]` | `-f NAME[=VALUE]` build flags for every invocation, sync included; changing them marks the model stale. | | `elide.build.options` | `{}` | Default options for `elide build`, e.g. `{ "no-cache": true }`. | diff --git a/packages/vscode/CHANGELOG.md b/packages/vscode/CHANGELOG.md index 6d06e9e..f96b731 100644 --- a/packages/vscode/CHANGELOG.md +++ b/packages/vscode/CHANGELOG.md @@ -22,6 +22,7 @@ All notable changes to the Elide extension are documented here. The format follo - Enable colorized process output for Elide task terminals, including tasks launched from sidebar targets and Android builds. Preserve color opt-outs and keep failure messages free of ANSI escapes. - Report coverage-minimum and other run-level failures when all individual test results passed. +- Clarify Komodo's explicit-bundle and managed CLI prerequisites. - Komodo Compose previews no longer fail with "the preview session closed" after an earlier preview session was closed or replaced; the next preview starts a new session. diff --git a/packages/vscode/README.md b/packages/vscode/README.md index 9bc3700..e5c1ffe 100644 --- a/packages/vscode/README.md +++ b/packages/vscode/README.md @@ -76,7 +76,7 @@ test, and debug commands are available from the editor. | | | | --- | --- | | [Elide](https://elide.dev) **1.5+** | Found via `elide.home`, `$ELIDE_HOME`, the platform install locations, or `PATH`. **1.6.1+** reports live task progress and resolves a project's classpaths in one call; older releases sync with one call per classpath and show tasks once they finish. | -| **Kotlin by JetBrains** (`JetBrains.kotlin-server`, ≥ 0.0.11), for the default language server | Install it from the Marketplace and complete its region/data-sharing prompt. Not needed with Komodo, which requires an Elide release supporting on-demand component resolution. | +| **Kotlin by JetBrains** (`JetBrains.kotlin-server`, ≥ 0.0.11), for the default language server | Install it from the Marketplace and complete its region/data-sharing prompt. Not needed with Komodo, which requires an explicit native bundle or an Elide CLI implementing managed Komodo commands. | | A JDK | `$JAVA_HOME`, SDKMAN, `/Library/Java/JavaVirtualMachines`, `/usr/lib/jvm`, or `elide.jdk.home`. Elide's bundled JDK image cannot be used for symbol resolution: it ships without a `release` file. | | An Android SDK, for Android projects | `android.sdk` in the manifest, `$ANDROID_HOME`, `$ANDROID_SDK_ROOT`, or where the SDK installs itself on this platform. `Elide: Install Android SDK Components` installs what a build is missing. | @@ -214,22 +214,25 @@ The extension also maintains two Kotlin LSP settings, and explicit values you se ### Komodo language server (experimental) -Komodo is an optional native Kotlin language server, debugger and live Compose preview engine managed by Elide. It is -opt-in; the JetBrains Kotlin LSP stays the default. To use it, set: +Komodo is an optional native Kotlin language server, debugger and live Compose preview engine. It requires either +an explicit native bundle or an Elide CLI with managed-component support. The JetBrains Kotlin LSP stays the default. +To use Komodo, set: ```jsonc "elide.kotlinLsp.server": "komodo", // per folder: Kotlin language server and debugger "elide.android.composePreview.engine": "komodo" // optional, window-wide: live Compose previews ``` -Leave executable, plugin and JDK overrides empty for managed use. The selected Elide CLI runs -`elide komodo resolve --json` without downloading or installing anything. If Komodo is missing, choose -**Install Komodo** from the notification, or run **Elide: Install Komodo** from the Command Palette. -That explicit action runs Elide's installer with progress and cancellation, resolves the installed identity, -and resyncs Komodo folders. Declining or failing installation leaves the feature unavailable; it never changes -engines. Ordinary Elide installs and default JetBrains/layoutlib use do not acquire Komodo. -Older Elide versions remain usable for existing features but need an upgrade for managed Komodo. -Elide validates supported platforms, compatible protocols, JDK inputs and trusted artifact checksums. +Managed use requires the selected CLI to implement `elide komodo resolve --json` and +`elide komodo install --yes --json`; Elide's version number alone does not establish support. A CLI without +these commands cannot resolve or install Komodo. Use `elide.kotlinLsp.komodo.path` to select an intact native +bundle explicitly, with its compiler plugins and JDK inputs configured as needed. + +With a compatible CLI, leave executable, plugin and JDK overrides empty. Resolution never downloads anything. +If Komodo is missing, choose **Install Komodo** from the notification or Command Palette. That explicit action +runs Elide's installer with progress and cancellation, resolves the installed identity, and resyncs Komodo folders. +Declining or failing installation leaves the feature unavailable; it never changes engines. Elide validates +supported platforms, compatible protocols, JDK inputs and trusted artifact checksums. Missing, incompatible or failed Komodo disables its native analysis and debugger at runtime: Activity reports a `disabled` detail, while the rest of project sync succeeds and the resolved models remain usable for builds. diff --git a/packages/vscode/media/typescript/package.json b/packages/vscode/media/typescript/package.json index f80edf9..08b49ef 100644 --- a/packages/vscode/media/typescript/package.json +++ b/packages/vscode/media/typescript/package.json @@ -6,6 +6,5 @@ "type": "commonjs", "license": "MIT", "description": "Native TypeScript server support for Elide build extensions.", - "elideBuildTypesSource": "https://github.com/elide-dev/elide/blob/e3dee520e930012f541644a0cb90ce6f6a4eba95/packages/types/build.d.ts", - "elideBuildTypesPatches": ["Task actions and prepare hooks accept Promise, matching async callbacks with explicit Promise return types."] + "elideBuildTypesSource": "https://github.com/elide-dev/elide/blob/8a27f9e129370451375cc10b4380abfd33a59f26/packages/types/build.d.ts" } diff --git a/packages/vscode/package.json b/packages/vscode/package.json index f2a4f8e..aba4a65 100644 --- a/packages/vscode/package.json +++ b/packages/vscode/package.json @@ -244,7 +244,7 @@ "Experimental: Komodo's native language server, installed on demand by Elide, analyzes Kotlin sources from the Elide project model. No workspace.json or JetBrains server is needed for the folder. One server serves every Komodo folder of the window." ], "default": "jetbrains", - "markdownDescription": "Kotlin language server for the folder's Elide projects. `komodo` requires an Elide release supporting on-demand Komodo resolution. If missing, choose **Install Komodo** explicitly; activation and sync never download it. With `komodo`, `#elide.debug.adapter#` defaults to Komodo's debugger." + "markdownDescription": "Kotlin language server for the folder's Elide projects. `komodo` requires an explicit native bundle (`#elide.kotlinLsp.komodo.path#`) or a CLI implementing `elide komodo resolve --json` and `elide komodo install --yes --json`. Activation and sync never download it; **Install Komodo** is explicit. With `komodo`, `#elide.debug.adapter#` defaults to Komodo's debugger." }, "elide.kotlinLsp.komodo.path": { "type": "string", From 43a2b24fcc39b72848afb32f0a59926187ccf1bc Mon Sep 17 00:00:00 2001 From: Dario Valdespino Date: Mon, 16 Nov 2026 12:24:10 -0300 Subject: [PATCH 2/2] build: refresh the npm lock action cache for the vscode manifest - CI's frozen lock check failed on the stale packages/vscode/package.json hash. - `bazel run @npm//:sync` leaves the refreshed hash as committed. --- .../npm_translate_lock_LTE4Nzc1MDcwNjU= | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.aspect/rules/external_repository_action_cache/npm_translate_lock_LTE4Nzc1MDcwNjU= b/.aspect/rules/external_repository_action_cache/npm_translate_lock_LTE4Nzc1MDcwNjU= index 4f3b3b8..6d6d845 100755 --- a/.aspect/rules/external_repository_action_cache/npm_translate_lock_LTE4Nzc1MDcwNjU= +++ b/.aspect/rules/external_repository_action_cache/npm_translate_lock_LTE4Nzc1MDcwNjU= @@ -3,6 +3,6 @@ # This file should be checked into version control along with the pnpm-lock.yaml file. package.json=1645056029 packages/core/package.json=-1407934132 -packages/vscode/package.json=988212829 +packages/vscode/package.json=1573059662 pnpm-lock.yaml=1115513514 pnpm-workspace.yaml=-1673009026