diff --git a/tests/radio-source-plan.test.mjs b/tests/radio-source-plan.test.mjs index 1c00af0d..bba4bcfe 100644 --- a/tests/radio-source-plan.test.mjs +++ b/tests/radio-source-plan.test.mjs @@ -148,3 +148,19 @@ test("does not disclose embedded stream credentials through a CORS proxy", () => ]); assert.equal(result.filter(item => item.proxied).length, 1); }); + + +test("never forwards signed query credentials to a third-party proxy", () => { + const sources = [ + { src: "https://radio.example/live.mp3?token=private-test-value" }, + { src: "https://radio.example/live.aac?accessKey=private-test-value" }, + { src: "https://radio.example/live.mp3?Signature=private-test-value" }, + { src: "https://radio.example/live.mp3?quality=high" }, + ]; + const result = buildPlaybackSources(sources, "https://cors.example/"); + assert.deepEqual(result.map(item => item.src), [ + ...sources.slice(0, 3).map(item => item.src), + "https://radio.example/live.mp3?quality=high", + "https://cors.example/https://radio.example/live.mp3?quality=high", + ]); +}); diff --git a/utils/radio-source-plan.mjs b/utils/radio-source-plan.mjs index 4cdc43e6..c29833fa 100644 --- a/utils/radio-source-plan.mjs +++ b/utils/radio-source-plan.mjs @@ -43,7 +43,10 @@ export const buildPlaybackSources = (sources, corsServer) => { let hasCredentials = false; try { const parsed = new URL(src); - hasCredentials = Boolean(parsed.username || parsed.password); + // Signed stream URLs must not be forwarded to third-party CORS proxies. + const sensitiveQuery = [...parsed.searchParams.keys()].some(key => + /^(?:token|access[_-]?key|api[_-]?key|auth(?:orization)?|signature|sig|secret|password|jwt|expires?|policy|key[_-]?pair[_-]?id)$/i.test(key)); + hasCredentials = Boolean(parsed.username || parsed.password || sensitiveQuery); } catch { /* Invalid URLs are not eligible for proxy fallback. */ hasCredentials = true; }