Skip to content

Implement Volume Handling #6

Description

@mitschwimmer

Let me begin with a question. The sink API defines a method ".setVolume()". Should this method be implented in such a way that it:

  1. actually controlls the media volume of the device
  2. controls the gain level of the current track. It would default to "1.0" which means flat, unchanged gain
  3. does nothing on Android as most users of this lib would use an "android-idiomatic" way of manipulating volume

I think the third option makes sense. @devgianlu what do you think?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions