From 89abaf8e37ff741cc34a6ec1e32cf37e0dba3adf Mon Sep 17 00:00:00 2001 From: Deepika Lalwani Date: Tue, 17 Nov 2026 06:05:13 +0000 Subject: [PATCH] Move grpc-all to test scope to stop packaging unshaded Netty grpc-all 1.49.0 was a compile-scope dependency, so the datastream plugin jar packaged grpc-netty with unshaded Netty 4.1.77.Final (netty-buffer, -codec, -codec-http, -codec-http2, -common, -handler, -resolver, -transport), grpc-okhttp, grpc-rls, grpc-testing and, through grpc-testing, junit 4.12 and hamcrest-core 1.3. Image scanning of gcr.io/cdapio/cdap reports these under /opt/cdap/master/artifacts/datastream-delta-plugins-*.jar/lib/ (40 rows). The exclusion meant to drop grpc-netty had groupId and artifactId swapped, so it never matched. Only DatastreamTableRegistryTest uses io.grpc directly (io.grpc.Status, which is in grpc-api), so grpc-all moves to test scope and the exclusion is fixed. The runtime transport stays grpc-netty-shaded. The plugin jar embeds only compile-scope dependencies, and gax-grpc declares grpc-auth, grpc-grpclb, grpc-services and grpc-xds at runtime scope; grpc-all used to lift them to compile scope. They are now declared directly at compile scope (versions from libraries-bom 26.1.1; grpc-xds, which that BOM does not manage, pinned to the same 1.48.0) so they stay in the plugin jar. As a side effect grpc-xds's own compile deps grpc-alts 1.48.0, opencensus-proto 0.2.0 and re2j 1.6 are now packaged too (they were runtime-only, so missing, before). delta-api's junit was already excluded in this repo. Versions: - grpc-all 1.49.0 compile -> test scope (exclusion fixed to io.grpc:grpc-netty) - io.netty 4.1.77.Final (8 jars), grpc-netty 1.48.0, grpc-okhttp 1.48.0, grpc-rls 1.49.0, grpc-testing 1.48.0, junit 4.12, hamcrest-core 1.3 -> no longer packaged - grpc-auth, grpc-grpclb, grpc-services, grpc-xds 1.48.0: now direct compile deps (unchanged versions) Bugs: plugin side for the unshaded Netty 4.1.77 rows (plan DS-1: 38 bugs touched, all also need other copies removed); junit b/578455300 closes once delta DL-1 and database-delta DBD-1 also land. Risk: low. No code change. The packaged gRPC set is the same except the removed test/alternate-transport jars and the three added xds deps. Testing: JDK 8. mvn clean package: BUILD SUCCESS, Checkstyle 0 violations, 16 unit tests pass (DatastreamTableRegistryTest, DatastreamEventConsumerTest, DatastreamConfigTest, DatastreamAssessmentTest, UtilsTest; the credential-gated tests are skipped by their assumptions as on develop). mvn dependency:tree -Dincludes=io.netty,junit,org.hamcrest,io.grpc: no io.netty artifact at any scope; junit/hamcrest and grpc-okhttp/rls/testing only under grpc-all at test scope. unzip -l of the plugin jar vs develop: removed lib/netty-*-4.1.77.Final.jar (8), grpc-all, grpc-netty, grpc-okhttp, grpc-rls, grpc-testing, junit-4.12, hamcrest-core-1.3; added grpc-alts, opencensus-proto, re2j; lib/grpc-netty-shaded-1.48.0.jar kept. --- pom.xml | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index f12eac6..acd9878 100644 --- a/pom.xml +++ b/pom.xml @@ -140,17 +140,41 @@ grpc-netty-shaded compile + + + io.grpc + grpc-auth + + + io.grpc + grpc-grpclb + + + io.grpc + grpc-services + + + io.grpc + grpc-xds + + 1.48.0 + io.grpc grpc-all 1.49.0 - io.grpc - grpc-netty + io.grpc + grpc-netty - compile + + test io.perfmark