From 4cd6c9bb10c3ecdba1cfdc3a4af177ff5447611b Mon Sep 17 00:00:00 2001 From: Deepika Lalwani Date: Tue, 17 Nov 2026 06:01:21 +0000 Subject: [PATCH] Remove logback-classic 1.0.9 and delta-api junit from plugin jars The root POM declared ch.qos.logback:logback-classic 1.0.9 at compile scope, so mysql-delta-plugins and sqlserver-delta-plugins packaged logback-classic and logback-core 1.0.9 under lib/. Image scanning of gcr.io/cdapio/cdap reports these jars under /opt/cdap/master/artifacts/{mysql,sqlserver}-delta-plugins-*.jar/lib/. No plugin main code uses logback; CDAP supplies the slf4j binding at runtime. The only logback references are the logback-test.xml test resources, which are ignored when no logback is on the test classpath. delta-api 0.9.0 leaks junit 4.12 at compile scope (fixed at the source in data-integrations/delta DL-1). Exclude it here so junit 4.12 is no longer packaged (lib/junit-4.12.jar in mysql-delta-plugins), and add junit 4.13.2 at test scope for the unit tests that relied on it. Versions: - logback-classic / logback-core 1.0.9 -> removed (root pom) - junit 4.12 (compile, via delta-api) -> excluded; junit 4.13.2 test scope (root pom) Bugs: b/578434136, b/578581195. Plugins side done for the junit 4.12 row of b/578455300 (closes once DL-1 and DS-1 land). Risk: low. Packaging-only change; no code change. Plugin logging still goes through slf4j to the CDAP-provided binding. Testing: JDK 8. mvn clean package -DtestSourceLocation=src/test/java (develop never compiles src/test/java by default because testSourceDirectory is ${testSourceLocation}): BUILD SUCCESS, Checkstyle 0 violations; delta-plugins-common RecordsTest, RuntimeArgumentsTest (3 tests) and sqlserver SqlServerTableAssessorTest, SqlServerRecordConsumerTest (7 tests) pass. mysql-delta-plugins has only *IntegrationTest (Docker MySQL); integration and e2e tests not run. mvn dependency:tree -Dincludes=junit,ch.qos.logback now shows only junit:junit:4.13.2:test in every module (was logback-classic 1.0.9 compile and junit 4.12 compile). unzip -l of the built mysql/sqlserver plugin jars shows no logback-*, junit-* or hamcrest-* under lib/ (develop: logback-classic/core 1.0.9 in both, junit-4.12 and hamcrest-core-1.3 in mysql-delta-plugins). --- pom.xml | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/pom.xml b/pom.xml index caef909..ea15e98 100644 --- a/pom.xml +++ b/pom.xml @@ -93,11 +93,6 @@ - - ch.qos.logback - logback-classic - 1.0.9 - org.slf4j log4j-over-slf4j @@ -107,12 +102,25 @@ io.cdap.delta delta-api ${delta.version} + + + + junit + junit + + com.google.guava guava ${guava.version} + + junit + junit + 4.13.2 + test +