Repository navigation
Expand file tree
/
Copy pathserializer_test.go
More file actions
363 lines (328 loc) · 8.91 KB
/
Copy pathserializer_test.go
File metadata and controls
363 lines (328 loc) · 8.91 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
package httpsig
import (
"testing"
"github.com/dunglas/httpsfv"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestNewSerializer(t *testing.T) {
t.Parallel()
for _, tc := range []struct {
uc string
params *httpsfv.Params
req bool
assert func(t *testing.T, s serializer, err error)
}{
{
uc: "req parameter not allowed for requests",
params: func() *httpsfv.Params {
params := httpsfv.NewParams()
params.Add("req", true)
return params
}(),
req: true,
assert: func(t *testing.T, _ serializer, err error) {
t.Helper()
require.Error(t, err)
require.ErrorIs(t, err, errSerialization)
require.ErrorContains(t, err, "'req' parameter")
},
},
{
uc: "strict encoding serializer",
params: func() *httpsfv.Params {
params := httpsfv.NewParams()
params.Add("sf", true)
return params
}(),
assert: func(t *testing.T, s serializer, err error) {
t.Helper()
require.NoError(t, err)
assert.IsType(t, &strictSerializer{}, s)
},
},
{
uc: "structured field serializer",
params: func() *httpsfv.Params {
params := httpsfv.NewParams()
params.Add("key", "foo")
return params
}(),
assert: func(t *testing.T, s serializer, err error) {
t.Helper()
require.NoError(t, err)
ser, ok := s.(*strictSerializer)
require.True(t, ok)
assert.Equal(t, "foo", ser.key)
},
},
{
uc: "byte sequence serializer",
params: func() *httpsfv.Params {
params := httpsfv.NewParams()
params.Add("bs", true)
return params
}(),
assert: func(t *testing.T, s serializer, err error) {
t.Helper()
require.NoError(t, err)
assert.IsType(t, &byteSequenceSerializer{}, s)
},
},
{
uc: "raw serializer",
params: httpsfv.NewParams(),
assert: func(t *testing.T, s serializer, err error) {
t.Helper()
require.NoError(t, err)
assert.IsType(t, &rawSerializer{}, s)
},
},
} {
t.Run(tc.uc, func(t *testing.T) {
s, err := newSerializer(tc.params, tc.req)
tc.assert(t, s, err)
})
}
}
func TestRawSerialization(t *testing.T) {
t.Parallel()
for _, tc := range []struct {
uc string
input []string
result []string
errContains string
}{
{
uc: "dictionary field",
input: []string{"a=1, b=2;x=1;y=2, c=(a b c)"},
result: []string{"a=1, b=2;x=1;y=2, c=(a b c)"},
},
{
uc: "list field with surrounding whitespace",
input: []string{" value, with, lots, of, commas, and, spaces"},
result: []string{"value, with, lots, of, commas, and, spaces"},
},
{
uc: "strip HTTP whitespace from each field value",
input: []string{" \t alpha \t", "\tbeta "},
result: []string{"alpha", "beta"},
},
{
uc: "empty field value",
input: []string{"", " \t "},
result: []string{"", ""},
},
{
uc: "preserve internal whitespace and commas",
input: []string{"alpha \t beta, gamma"},
result: []string{"alpha \t beta, gamma"},
},
{
uc: "unfold obsolete line folding with preceding whitespace",
input: []string{"alpha \t\r\n\t beta"},
result: []string{"alpha beta"},
},
{
uc: "reject leading obsolete line folding",
input: []string{"\r\n value"},
errContains: "invalid HTTP field value",
},
{
uc: "reject leading obsolete line folding after whitespace",
input: []string{" \t\r\n value"},
errContains: "invalid HTTP field value",
},
{
uc: "reject non-ASCII UTF-8",
input: []string{"caf\u00e9"},
errContains: "non-ASCII",
},
{
uc: "reject non-ASCII octet",
input: []string{"\xff"},
errContains: "non-ASCII",
},
{
uc: "reject bare newline",
input: []string{"alpha\nbeta"},
errContains: "invalid HTTP field value",
},
{
uc: "reject NUL",
input: []string{"alpha\x00beta"},
errContains: "invalid HTTP field value",
},
{
uc: "reject other ASCII control characters",
input: []string{"alpha\x01beta"},
errContains: "invalid HTTP field value",
},
{
uc: "reject DEL",
input: []string{"alpha\x7fbeta"},
errContains: "invalid HTTP field value",
},
} {
t.Run(tc.uc, func(t *testing.T) {
params := httpsfv.NewParams()
s, err := newSerializer(params, false)
require.NoError(t, err)
result, err := s.serialize(tc.input)
if tc.errContains != "" {
require.ErrorIs(t, err, errSerialization)
require.ErrorContains(t, err, tc.errContains)
return
}
require.NoError(t, err)
assert.Equal(t, tc.result, result)
})
}
}
func TestByteSequenceSerialization(t *testing.T) {
t.Parallel()
for _, tc := range []struct {
uc string
input []string
result []string
}{
{
uc: "two fields",
input: []string{"value, with, lots", "of, commas"},
result: []string{":dmFsdWUsIHdpdGgsIGxvdHM=:", ":b2YsIGNvbW1hcw==:"},
},
{
uc: "single field",
input: []string{"value, with, lots, of, commas"},
result: []string{":dmFsdWUsIHdpdGgsIGxvdHMsIG9mLCBjb21tYXM=:"},
},
{
uc: "preserve internal spaces and commas",
input: []string{"foo , bar"},
result: []string{":Zm9vICwgIGJhcg==:"},
},
{
uc: "preserve internal tabs",
input: []string{"alpha\tbeta"},
result: []string{":YWxwaGEJYmV0YQ==:"},
},
{
uc: "strip surrounding HTTP whitespace",
input: []string{"\t alpha \t"},
result: []string{":YWxwaGE=:"},
},
{
uc: "unfold obsolete line folding",
input: []string{"hello\r\n \tworld"},
result: []string{":aGVsbG8gd29ybGQ=:"},
},
{
uc: "unfold obsolete line folding with preceding whitespace",
input: []string{"hello \r\n \tworld"},
result: []string{":aGVsbG8gd29ybGQ=:"},
},
{
uc: "preserve non-ASCII whitespace bytes",
input: []string{"\u00a0alpha"},
result: []string{":wqBhbHBoYQ==:"},
},
} {
t.Run(tc.uc, func(t *testing.T) {
params := httpsfv.NewParams()
params.Add("bs", true)
s, err := newSerializer(params, false)
require.NoError(t, err)
result, err := s.serialize(tc.input)
require.NoError(t, err)
assert.Equal(t, tc.result, result)
})
}
}
func TestStrictEncodingSerialization(t *testing.T) {
t.Parallel()
for _, tc := range []struct {
uc string
input []string
result []string
err bool
}{
{
uc: "dictionary field",
input: []string{"a=1, b=2;x=1;y=2, c=(a b c)"},
result: []string{"a=1, b=2;x=1;y=2, c=(a b c)"},
},
{
uc: "field with lots of comas and spaces",
input: []string{" value, with, lots, of, commas, and, spaces"},
result: []string{"value, with, lots, of, commas, and, spaces"},
},
{
uc: "list field",
input: []string{"(a b c d e f g)"},
result: []string{"(a b c d e f g)"},
},
{
uc: "item field",
input: []string{"foo; bar=baz"},
result: []string{"foo;bar=baz"},
},
{
uc: "bare item field",
input: []string{" 1 "},
result: []string{"1"},
},
{
uc: "list field",
input: []string{"[a b c]"},
err: true,
},
} {
t.Run(tc.uc, func(t *testing.T) {
params := httpsfv.NewParams()
params.Add("sf", true)
s, err := newSerializer(params, false)
require.NoError(t, err)
result, err := s.serialize(tc.input)
if tc.err {
require.Error(t, err)
require.ErrorIs(t, err, errSerialization)
} else {
require.NoError(t, err)
assert.Equal(t, tc.result, result)
}
})
}
}
func TestStructuredFieldSerialization(t *testing.T) {
t.Parallel()
for uc, tc := range map[string]struct {
input []string
key string
result []string
err bool
}{
"integer member": {input: []string{" a=1, b=2;x=1;y=2, c=(a b c), d"}, key: "a", result: []string{"1"}},
"member with parameters": {input: []string{" a=1, b=2;x=1;y=2, c=(a b c), d"}, key: "b", result: []string{"2;x=1;y=2"}},
"inner list member": {input: []string{" a=1, b=2;x=1;y=2, c=(a b c), d"}, key: "c", result: []string{"(a b c)"}},
"boolean member in dictionary": {input: []string{" a=1, b=2;x=1;y=2, c=(a b c), d"}, key: "d", result: []string{"?1"}},
"single bare boolean member": {input: []string{"a"}, key: "a", result: []string{"?1"}},
"bare boolean with parameters": {input: []string{"a;x=1"}, key: "a", result: []string{"?1;x=1"}},
"missing dictionary member": {input: []string{" a=1, b=2;x=1;y=2, c=(a b c), d"}, key: "e", err: true},
"non-dictionary field": {input: []string{"(a b c)"}, key: "a", err: true},
} {
t.Run(uc, func(t *testing.T) {
params := httpsfv.NewParams()
params.Add("key", tc.key)
s, err := newSerializer(params, false)
require.NoError(t, err)
result, err := s.serialize(tc.input)
if tc.err {
require.Error(t, err)
require.ErrorIs(t, err, errSerialization)
} else {
require.NoError(t, err)
assert.Equal(t, tc.result, result)
}
})
}
}