Repository navigation
Expand file tree
/
Copy pathcomponent_identifier_test.go
More file actions
381 lines (334 loc) · 9.38 KB
/
Copy pathcomponent_identifier_test.go
File metadata and controls
381 lines (334 loc) · 9.38 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
package httpsig
import (
"testing"
"github.com/dunglas/httpsfv"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestToComponentIdentifiers(t *testing.T) {
t.Parallel()
for uc, tc := range map[string]struct {
identifiers []string
assert func(t *testing.T, ci []*componentIdentifier, err error)
}{
"invalid identifier definition": {
identifiers: []string{`"foo";#`},
assert: func(t *testing.T, _ []*componentIdentifier, err error) {
t.Helper()
require.Error(t, err)
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
},
},
"unquoted derived component": {
identifiers: []string{"@method"},
assert: func(t *testing.T, ci []*componentIdentifier, err error) {
t.Helper()
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
assert.Nil(t, ci)
},
},
"unquoted field name": {
identifiers: []string{"content-digest"},
assert: func(t *testing.T, ci []*componentIdentifier, err error) {
t.Helper()
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
assert.Nil(t, ci)
},
},
"unquoted field name with parameters": {
identifiers: []string{"content-digest;req"},
assert: func(t *testing.T, ci []*componentIdentifier, err error) {
t.Helper()
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
assert.Nil(t, ci)
},
},
"unquoted derived component with parameters": {
identifiers: []string{`@query-param;name="Pet"`},
assert: func(t *testing.T, ci []*componentIdentifier, err error) {
t.Helper()
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
assert.Nil(t, ci)
},
},
"non-string SF integer": {
identifiers: []string{"42"},
assert: func(t *testing.T, ci []*componentIdentifier, err error) {
t.Helper()
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
assert.Nil(t, ci)
},
},
"non-string SF boolean": {
identifiers: []string{"?1"},
assert: func(t *testing.T, ci []*componentIdentifier, err error) {
t.Helper()
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
assert.Nil(t, ci)
},
},
"unknown identifier": {
identifiers: []string{`"@foo"`},
assert: func(t *testing.T, _ []*componentIdentifier, err error) {
t.Helper()
require.Error(t, err)
require.ErrorIs(t, err, ErrUnsupportedComponentIdentifier)
},
},
"preserving supported parameter types": {
identifiers: []string{`"x-test";key="abc";sf;req`},
assert: func(t *testing.T, ci []*componentIdentifier, err error) {
t.Helper()
require.NoError(t, err)
require.Len(t, ci, 1)
key, present := ci[0].Params.Get("key")
require.True(t, present)
assert.Equal(t, "abc", key)
sf, present := ci[0].Params.Get("sf")
require.True(t, present)
assert.Equal(t, true, sf)
req, present := ci[0].Params.Get("req")
require.True(t, present)
assert.Equal(t, true, req)
},
},
"preserving parameter order": {
identifiers: []string{`"x-test";sf;req`, `"x-test";req;sf`},
assert: func(t *testing.T, ci []*componentIdentifier, err error) {
t.Helper()
require.NoError(t, err)
require.Len(t, ci, 2)
for i, expected := range []string{`"x-test";sf;req`, `"x-test";req;sf`} {
actual, marshalErr := httpsfv.Marshal(ci[i].Item)
require.NoError(t, marshalErr)
assert.Equal(t, expected, actual)
}
assert.True(t, ci[0].equal(ci[1]))
},
},
"valid": {
identifiers: []string{`"@method";req`, `"@status"`, `"@query-param";name="Pet"`},
assert: func(t *testing.T, ci []*componentIdentifier, err error) {
t.Helper()
require.NoError(t, err)
require.Len(t, ci, 3)
assert.Equal(t, "@method", ci[0].Value.(string))
res, ok := ci[0].Params.Get("req")
require.True(t, ok)
require.Equal(t, true, res)
assert.NotNil(t, ci[0].c)
assert.Equal(t, "@status", ci[1].Value.(string))
assert.Empty(t, ci[1].Params.Names())
assert.NotNil(t, ci[1].c)
assert.Equal(t, "@query-param", ci[2].Value.(string))
res, ok = ci[2].Params.Get("name")
require.True(t, ok)
require.Equal(t, "Pet", res.(string))
assert.NotNil(t, ci[2].c)
},
},
} {
t.Run(uc, func(t *testing.T) {
res, err := toComponentIdentifiers(tc.identifiers)
tc.assert(t, res, err)
})
}
}
func TestIsValidHTTPFieldName(t *testing.T) {
t.Parallel()
for uc, tc := range map[string]struct {
name string
valid bool
}{
"lowercase field name": {name: "content-type", valid: true},
"uppercase field name": {name: "Content-Type", valid: true},
"all permitted punctuation": {name: "!#$%&'*+-.^_`|~", valid: true},
"empty name": {name: ""},
"space": {name: "bad name"},
"colon": {name: ":authority"},
"slash": {name: "bad/name"},
"at sign": {name: "name@other"},
"non-ASCII": {name: "caf\u00e9"},
"control character": {name: "bad\nname"},
} {
t.Run(uc, func(t *testing.T) {
assert.Equal(t, tc.valid, isValidHTTPFieldName(tc.name))
})
}
}
func TestNewComponentIdentifier(t *testing.T) {
t.Parallel()
for uc, tc := range map[string]struct {
item httpsfv.Item
assert func(t *testing.T, ci *componentIdentifier, err error)
}{
"non-string component name": {
item: httpsfv.NewItem(int64(42)),
assert: func(t *testing.T, ci *componentIdentifier, err error) {
t.Helper()
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
assert.Nil(t, ci)
},
},
"invalid": {
item: httpsfv.NewItem("@foo"),
assert: func(t *testing.T, _ *componentIdentifier, err error) {
t.Helper()
require.Error(t, err)
require.ErrorIs(t, err, ErrUnsupportedComponentIdentifier)
},
},
"uppercase component name": {
item: httpsfv.NewItem("Content-Type"),
assert: func(t *testing.T, ci *componentIdentifier, err error) {
t.Helper()
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
assert.Nil(t, ci)
},
},
"invalid HTTP field name": {
item: httpsfv.NewItem("bad name"),
assert: func(t *testing.T, ci *componentIdentifier, err error) {
t.Helper()
require.ErrorIs(t, err, ErrInvalidComponentIdentifier)
assert.Nil(t, ci)
},
},
"valid HTTP field name": {
item: httpsfv.NewItem("x_test"),
assert: func(t *testing.T, ci *componentIdentifier, err error) {
t.Helper()
require.NoError(t, err)
assert.NotNil(t, ci.c)
},
},
"valid": {
item: func() httpsfv.Item {
item := httpsfv.NewItem("@method")
item.Params.Add("req", true)
return item
}(),
assert: func(t *testing.T, ci *componentIdentifier, err error) {
t.Helper()
require.NoError(t, err)
assert.NotNil(t, ci.c)
val, ok := ci.Params.Get("req")
require.True(t, ok)
assert.Equal(t, true, val)
},
},
} {
t.Run(uc, func(t *testing.T) {
ci, err := newComponentIdentifier(tc.item)
tc.assert(t, ci, err)
})
}
}
func TestComponentIdentifierEqual(t *testing.T) {
t.Parallel()
for uc, tc := range map[string]struct {
first string
second string
equal bool
}{
"same identifier with reordered parameters": {
first: `"x-test";key="foo";sf`,
second: `"x-test";sf;key="foo"`,
equal: true,
},
"different names": {
first: `"x-first"`,
second: `"x-second"`,
},
"different parameter names": {
first: `"x-test";sf`,
second: `"x-test";bs`,
},
"different parameter counts": {
first: `"x-test";req`,
second: `"x-test"`,
},
"different parameter values": {
first: `"x-test";key="foo"`,
second: `"x-test";key="bar"`,
},
} {
t.Run(uc, func(t *testing.T) {
identifiers, err := toComponentIdentifiers([]string{tc.first, tc.second})
require.NoError(t, err)
assert.Equal(t, tc.equal, identifiers[0].equal(identifiers[1]))
})
}
}
func TestEqualComponentParameterValues(t *testing.T) {
t.Parallel()
for uc, tc := range map[string]struct {
actual any
expected any
equal bool
}{
"equal byte sequences": {
actual: []byte{1, 2, 3},
expected: []byte{1, 2, 3},
equal: true,
},
"different byte sequences": {
actual: []byte{1, 2, 4},
expected: []byte{1, 2, 3},
},
"non-byte value against byte sequence": {
actual: "foo",
expected: []byte{1, 2, 3},
},
"equal scalar values": {
actual: int64(42),
expected: int64(42),
equal: true,
},
"different scalar types": {
actual: httpsfv.Token("foo"),
expected: "foo",
},
} {
t.Run(uc, func(t *testing.T) {
assert.Equal(t, tc.equal, equalComponentParameterValues(tc.actual, tc.expected))
})
}
}
func TestComponentIdentifierCreateComponent(t *testing.T) {
t.Parallel()
for uc, tc := range map[string]struct {
item httpsfv.Item
msg *Message
err error
}{
"with error during canonicalization": {
item: func() httpsfv.Item {
item := httpsfv.NewItem("@method")
item.Params.Add("req", true)
return item
}(),
msg: &Message{Method: "GET", IsRequest: true},
err: ErrCanonicalization,
},
"successful": {
item: httpsfv.NewItem("@method"),
msg: &Message{Method: "POST", IsRequest: true},
},
} {
t.Run(uc, func(t *testing.T) {
ci, err := newComponentIdentifier(tc.item)
require.NoError(t, err)
c, err := ci.createComponent(tc.msg)
if tc.err != nil {
require.Error(t, err)
require.ErrorIs(t, err, tc.err)
} else {
require.NoError(t, err)
require.NotNil(t, c)
assert.Equal(t, ci, c.key)
assert.NotEmpty(t, c.value)
}
})
}
}