Skip to content

possible incorrectness in libffi include dir assignment, doesn't seem impactful #61

Description

@solvingj

This looks like an obvious mistake but I don't think it matters because the pkgconfig files are correct and provide the path ultimately:

yield f"LIBFFI_INCLUDEDIR={self.deps_lib}"

            if self.active_module(LibFFI):
                yield f"LIBFFI_INCLUDEDIR={self.deps_lib}"

I'll refrain from opening a PR because I'm not sure... it's possible that this is necessary due to libffi nuances and just looks wrong, but there's no comment or commit message to indicate if thats the case.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions