From 19ab2249d69df5c44f37af1d60bd5fbae0b678cf Mon Sep 17 00:00:00 2001 From: Madraka <8898640+Madraka@users.noreply.github.com> Date: Thu, 19 Nov 2026 03:15:28 +0300 Subject: [PATCH 1/6] fix(app): the sign-in's second step offers a recovery code with Kumo's button "Use a recovery code instead", and "Use a code from the app instead", is an action, so it is Kumo's Button: the ghost kind at the extra small size, grey and underlined, the text action it was, set back by its own padding to the form's edge. The controls check's debt loses SignInSteps. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com> --- app/components/SignInSteps.tsx | 9 ++++++--- scripts/checks/controls.ts | 1 - 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/components/SignInSteps.tsx b/app/components/SignInSteps.tsx index 42cc9af..39e4ea7 100644 --- a/app/components/SignInSteps.tsx +++ b/app/components/SignInSteps.tsx @@ -116,9 +116,12 @@ export default function SignInSteps({ > {t("Continue")} - + ); } diff --git a/scripts/checks/controls.ts b/scripts/checks/controls.ts index 6945c41..7622d6a 100644 --- a/scripts/checks/controls.ts +++ b/scripts/checks/controls.ts @@ -89,7 +89,6 @@ export const TO_MOVE: Readonly>>> "app/components/MessageList.tsx": { button: 2, input: 1 }, "app/components/MessageListToolbar.tsx": { input: 1 }, "app/components/ScheduledList.tsx": { button: 1 }, - "app/components/SignInSteps.tsx": { button: 1 }, "app/components/email-panel/MessageHeader.tsx": { button: 4 }, "app/components/email-panel/ThreadMessage.tsx": { button: 1 }, "app/components/settings/AssistantSettings.tsx": { textarea: 1 }, From 9b8a05c4e65a3af78f2b0ef8417858294d85e59a Mon Sep 17 00:00:00 2001 From: Madraka <8898640+Madraka@users.noreply.github.com> Date: Thu, 19 Nov 2026 03:15:47 +0300 Subject: [PATCH 2/6] fix(app): Sign out on the mailboxes page is Kumo's button Signing out is an action, so it is Kumo's Button at the small size, after the address and the link to sign-in and security, instead of a word underlined in the middle of the sentence. The controls check's debt loses home.tsx. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com> --- app/routes/home.tsx | 20 +++++++++----------- scripts/checks/controls.ts | 1 - 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/app/routes/home.tsx b/app/routes/home.tsx index 119a860..dd7887c 100644 --- a/app/routes/home.tsx +++ b/app/routes/home.tsx @@ -177,11 +177,13 @@ export default function HomeRoute() { )} {me && ( -

- {t("Signed in as {email}.", { email: me.user.email })}{" "} - - {" · "} - - {t("Sign-in and security")} - -

+ + )} {domains.length > 0 && (

{domains.join(", ")}

diff --git a/scripts/checks/controls.ts b/scripts/checks/controls.ts index 7622d6a..ac9017c 100644 --- a/scripts/checks/controls.ts +++ b/scripts/checks/controls.ts @@ -93,7 +93,6 @@ export const TO_MOVE: Readonly>>> "app/components/email-panel/ThreadMessage.tsx": { button: 1 }, "app/components/settings/AssistantSettings.tsx": { textarea: 1 }, "app/components/settings/SignatureSettings.tsx": { input: 1 }, - "app/routes/home.tsx": { button: 1 }, "app/routes/mailbox.tsx": { button: 1 }, "app/routes/members.tsx": { select: 1 }, "app/routes/search-results.tsx": { button: 1 }, From 63bfe5ef69db4c39f846d3f2ea105b1da636d93f Mon Sep 17 00:00:00 2001 From: Madraka <8898640+Madraka@users.noreply.github.com> Date: Thu, 19 Nov 2026 03:16:58 +0300 Subject: [PATCH 3/6] fix(app): the top bar's search box keeps its shape on purpose, with Kumo's buttons inside it The search box stays the field it is: one wide box 48 px tall, fully round and filled, with no line, that turns to the page's colour with a ring when it has focus. Kumo 2.18.1's Input and InputGroup give a size alone, 40 px at their largest, with Kumo's corner and line, and a height, a corner or padding written by hand is refused; so the field is one ON_PURPOSE line that says what Kumo lacks. Its two buttons, "Clear search" and "Search options", are Kumo's: the ghost kind, round, at the small size, where they stood. The shade behind the rail on a phone stays a native button, as one ON_PURPOSE line with its reason: it is the screen around the rail, out of the tab order, and closes the rail when pressed. The controls check now holds InputGroup and its parts as it holds Kumo's other controls, so a size written by hand on one is refused; two cases in its tests, which fail without it. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com> --- app/components/Header.tsx | 30 ++++++++++++++++-------------- scripts/checks/controls.ts | 17 +++++++++++++++-- test/unit/controls.test.ts | 2 ++ 3 files changed, 33 insertions(+), 16 deletions(-) diff --git a/app/components/Header.tsx b/app/components/Header.tsx index b42dd95..bef0255 100644 --- a/app/components/Header.tsx +++ b/app/components/Header.tsx @@ -119,24 +119,26 @@ export default function Header() { className="h-12 w-full rounded-full border border-transparent bg-kumo-fill pl-12 pr-20 text-sm text-kumo-default placeholder:text-kumo-subtle focus:border-kumo-line focus:bg-kumo-base focus:outline-none focus:ring-1 focus:ring-kumo-ring [&::-webkit-search-cancel-button]:hidden" /> {searchQuery && ( - + onClick={clearSearch} + /> )} - + onClick={() => setOptionsOpen(true)} + /> >>> "app/components/ComposeWindow.tsx": { button: 1 }, "app/components/EmailAttachmentList.tsx": { button: 2 }, "app/components/EmailPanel.tsx": { button: 1 }, - "app/components/Header.tsx": { button: 2, input: 1 }, "app/components/InlineReply.tsx": { button: 2 }, "app/components/InvitePerson.tsx": { select: 1 }, "app/components/LabelDialog.tsx": { input: 1 }, @@ -93,7 +107,6 @@ export const TO_MOVE: Readonly>>> "app/components/email-panel/ThreadMessage.tsx": { button: 1 }, "app/components/settings/AssistantSettings.tsx": { textarea: 1 }, "app/components/settings/SignatureSettings.tsx": { input: 1 }, - "app/routes/mailbox.tsx": { button: 1 }, "app/routes/members.tsx": { select: 1 }, "app/routes/search-results.tsx": { button: 1 }, }; diff --git a/test/unit/controls.test.ts b/test/unit/controls.test.ts index 555af05..103af16 100644 --- a/test/unit/controls.test.ts +++ b/test/unit/controls.test.ts @@ -105,6 +105,8 @@ describe("Kumo controls sized by hand", () => { ["the important mark after", ''], ["a style attribute", ''], ["a dotted part of Kumo's", ''], + ["an input group", ''], + ["a part of an input group", ''], ])("refuses %s", (_what, text) => { expect(problems(text)).toHaveLength(1); }); From 429c8da5b3458ad6a6fe76fcc96a233a71f7e18b Mon Sep 17 00:00:00 2001 From: Madraka <8898640+Madraka@users.noreply.github.com> Date: Thu, 19 Nov 2026 03:18:45 +0300 Subject: [PATCH 4/6] fix(app): the list's boxes and stars are Kumo's, and its lines stay on purpose The box above the list is Kumo's Checkbox, which says "some" with its own indeterminate state instead of a property set on the element after each paint. A line's box is Kumo's Checkbox too, and its star Kumo's Button, the ghost kind, square, at the small size: 26 px, no smaller a target than the 20 px the star had. Shift still ticks every line from the last box used: Kumo's box takes no click handler, so the line reads Shift from the click or the key that passes through it on the way to the box. Kumo's box takes clicks 12 px around itself, so the box above the list keeps that room from the menu's button beside it, which it covered. A line itself stays one native button, as one ON_PURPOSE line with its reason: it is the conversation, with who wrote, the subject, the text, its labels and the date, laid out for the width of the list, and Kumo's Button holds a label and an icon in one row. The browser tests find these boxes by role and name. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com> --- app/components/MessageList.tsx | 43 +++++++++++++-------------- app/components/MessageListToolbar.tsx | 17 ++++------- scripts/checks/controls.ts | 9 ++++-- test/e2e/bulk.spec.ts | 6 ++-- test/e2e/choices.spec.ts | 4 ++- test/e2e/live.spec.ts | 2 +- test/e2e/mailbox.spec.ts | 2 +- 7 files changed, 42 insertions(+), 41 deletions(-) diff --git a/app/components/MessageList.tsx b/app/components/MessageList.tsx index af60d6a..b6204a3 100644 --- a/app/components/MessageList.tsx +++ b/app/components/MessageList.tsx @@ -1,7 +1,7 @@ // Copyright 2026 Cloudhal and the Podbay contributors // Licensed under the Apache 2.0 license found in the LICENSE file. -import { Badge, Tooltip } from "@cloudflare/kumo"; +import { Badge, Button, Checkbox, Tooltip } from "@cloudflare/kumo"; import { ArchiveIcon, ArrowBendUpLeftIcon, @@ -328,6 +328,14 @@ export default function MessageList({ event.dataTransfer.effectAllowed = "move"; }} onDragEnd={() => useUIStore.setState({ dragged: [] })} + // Whether Shift is held for the box this click or key ticks: Kumo's box takes no click + // handler of its own, so the line reads it on the way down. + onClickCapture={(event) => { + withShift.current = event.shiftKey; + }} + onKeyDownCapture={(event) => { + withShift.current = event.shiftKey; + }} onContextMenu={(event) => { event.preventDefault(); setMenu({ email, at: { x: event.clientX, y: event.clientY } }); @@ -336,35 +344,26 @@ export default function MessageList({ index === cursor ? "border-l-kumo-brand" : "border-l-transparent" } ${tone}`} > - { - withShift.current = event.shiftKey; - }} - onChange={() => toggle(email.id)} + onCheckedChange={() => toggle(email.id)} /> - + /> {/* The conversation itself: one button, so the row has one name and one action */} + ); })} diff --git a/docs/status.md b/docs/status.md index 983662b..e1daada 100644 --- a/docs/status.md +++ b/docs/status.md @@ -28,7 +28,7 @@ | Markdown links and anchors | D14 | `pnpm static docs` | | The guidance is consistent: `AGENTS.md` is one page and names every skill and subagent; skills are named as their folders; a rule's paths still match files; a subagent names only skills that exist and cannot edit; the settings keep local secrets unread and ask before a push or a deploy | D15 | `pnpm static guidance`, `test/unit/guidance.test.ts` | | No lint warning: every rule has one level for every file, no file is exempt, and `pnpm lint` fails on a warning (`--error-on-warnings`), so a clean run prints none. A rule is kept off at a place only by a `biome-ignore` that says why (two keyed lists that are never reordered). File size only goes down | D1, D4 | `pnpm lint`, `pnpm static ratchets` (lint warnings at 0) | -| The app's controls are Kumo's (`pnpm static controls`): no `