From 6cd5ee0c47851167ee151af5d2473bc4bf44e70d Mon Sep 17 00:00:00 2001 From: charlie4284 Date: Thu, 24 Sep 2026 17:34:12 +0000 Subject: [PATCH] feat: expose resolved image ID in server metadata --- provider/spec.go | 5 +++++ provider/spec_test.go | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/provider/spec.go b/provider/spec.go index 32909c2..9ab60ac 100644 --- a/provider/spec.go +++ b/provider/spec.go @@ -225,6 +225,11 @@ func (m *machineSpec) Validate() error { // SetSpecFromImage looks for aditional info in the image metadata that can be set // on a machine for later retrieval. func (m *machineSpec) SetSpecFromImage(img images.Image) { + if m.Properties == nil { + m.Properties = make(map[string]string) + } + m.Properties["image_id"] = img.ID + if os_name, ok := img.Properties["os_distro"]; ok { val, ok := os_name.(string) if ok { diff --git a/provider/spec_test.go b/provider/spec_test.go index 3239f23..cf21cb2 100644 --- a/provider/spec_test.go +++ b/provider/spec_test.go @@ -21,11 +21,19 @@ import ( "github.com/cloudbase/garm-provider-common/cloudconfig" "github.com/cloudbase/garm-provider-common/params" "github.com/gophercloud/gophercloud/v2/openstack/compute/v2/servers" + "github.com/gophercloud/gophercloud/v2/openstack/image/v2/images" "github.com/stretchr/testify/assert" "github.com/cloudbase/garm-provider-openstack/config" ) +func TestMachineSpecSetSpecFromImageAddsImageID(t *testing.T) { + m := &machineSpec{Properties: map[string]string{}} + m.SetSpecFromImage(images.Image{ID: "image-uuid"}) + + assert.Equal(t, "image-uuid", m.Properties["image_id"]) +} + func Test_machineSpec_MergeExtraSpecs(t *testing.T) { tests := []struct { name string