From 7313f7a7f123682daf1203785d7c998120aa9497 Mon Sep 17 00:00:00 2001
From: Inaki Villar <inaki.seri@gmail.com>
Date: Thu, 20 Aug 2026 10:35:46 -0700
Subject: [PATCH] fix: refactor versions yaml generation to isolate template
 rendering

---
 .../cli/GenerateVersionsYaml.kt               | 14 ++++++----
 .../cli/VersionsParserTest.kt                 | 28 +++++++++++++++++++
 2 files changed, 36 insertions(+), 6 deletions(-)

diff --git a/cli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/GenerateVersionsYaml.kt b/cli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/GenerateVersionsYaml.kt
index 5210f5f3..7f6fb539 100644
--- a/cli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/GenerateVersionsYaml.kt
+++ b/cli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/GenerateVersionsYaml.kt
@@ -1,16 +1,20 @@
 package io.github.cdsap.projectgenerator.cli
 
 import io.github.cdsap.projectgenerator.model.AdditionalPlugin
-import io.github.cdsap.projectgenerator.model.Versions
 import io.github.cdsap.projectgenerator.model.Gradle
+import io.github.cdsap.projectgenerator.model.Versions
 import java.io.File
 
 class GenerateVersionsYaml {
     fun generate() {
         val file = File("versions.yaml")
-        val versions = Versions()
-        val content = """
-            |gradle: ${Gradle.latest().version}
+        file.writeText(render())
+        if (file.exists()) println("file versions.yaml created ")
+    }
+
+    fun render(versions: Versions = Versions(), gradle: Gradle = Gradle.latest()): String {
+        return """
+            |gradle: ${gradle.version}
             |project:
             |  develocity: ${versions.project.develocity}
             |  develocityUrl: ${versions.project.develocityUrl}
@@ -52,8 +56,6 @@ class GenerateVersionsYaml {
             |additionalBuildGradleRootPlugins:
             |  ${additionalPlugins(versions.additionalBuildGradleRootPlugins)}
         """.trimMargin()
-        file.writeText(content)
-        if (file.exists()) println("file versions.yaml created ")
     }
 
     fun additionalPlugins(plugins: List<AdditionalPlugin>): String {
diff --git a/cli/src/test/kotlin/io/github/cdsap/projectgenerator/cli/VersionsParserTest.kt b/cli/src/test/kotlin/io/github/cdsap/projectgenerator/cli/VersionsParserTest.kt
index 61e214a5..c4c9418d 100644
--- a/cli/src/test/kotlin/io/github/cdsap/projectgenerator/cli/VersionsParserTest.kt
+++ b/cli/src/test/kotlin/io/github/cdsap/projectgenerator/cli/VersionsParserTest.kt
@@ -1,7 +1,9 @@
 package io.github.cdsap.projectgenerator.cli
 
 import io.github.cdsap.projectgenerator.model.AdditionalPlugin
+import io.github.cdsap.projectgenerator.model.DependencyInjection
 import io.github.cdsap.projectgenerator.model.Gradle
+import io.github.cdsap.projectgenerator.model.Versions
 import org.junit.jupiter.api.Assertions.assertEquals
 import org.junit.jupiter.api.Assertions.assertTrue
 import org.junit.jupiter.api.Test
@@ -14,6 +16,32 @@ class VersionsParserTest {
     @TempDir
     lateinit var tempDir: Path
 
+    @Test
+    fun `rendered default versions YAML is parseable including plugin list sections`() {
+        val versions = Versions()
+        val gradle = Gradle.latest()
+        val yaml = GenerateVersionsYaml().render(versions, gradle)
+        val file = File(tempDir.toFile(), "versions.yaml").apply { writeText(yaml) }
+
+        val versionsFile = VersionsParser.fromFile(file)
+        val parsed = versionsFile.resolve()
+
+        assertEquals(gradle, versionsFile.gradle)
+        assertEquals(versions.project.develocity, parsed.project.develocity)
+        assertEquals(versions.project.develocityUrl, parsed.project.develocityUrl)
+        assertEquals(versions.project.jdk, parsed.project.jdk)
+        assertEquals(DependencyInjection.HILT, parsed.di)
+        assertEquals(versions.kotlin.kgp, parsed.kotlin.kgp)
+        assertEquals(versions.kotlin.ksp, parsed.kotlin.ksp)
+        assertEquals(versions.kotlin.coroutines, parsed.kotlin.coroutines)
+        assertEquals(versions.kotlin.kotlinProcessor.processor, parsed.kotlin.kotlinProcessor.processor)
+        assertEquals(versions.android.agp, parsed.android.agp)
+        assertEquals(versions.android.composeBom, parsed.android.composeBom)
+        assertEquals(versions.testing.junit4, parsed.testing.junit4)
+        assertEquals(versions.additionalSettingsPlugins, parsed.additionalSettingsPlugins)
+        assertEquals(versions.additionalBuildGradleRootPlugins, parsed.additionalBuildGradleRootPlugins)
+    }
+
     @Test
     fun `parses YAML without additionalSettingsPlugins and additionalBuildGradleRootPlugins as empty lists`() {
         val yaml = """