Skip to content

Consider replacing attrs with msgspec #78

Description

@effigies

As this project gets closer to usability, performance on large datasets is going to become relevant. I suspect that attrs is not a bottleneck, but we do instantiate a large number of attrs dataclasses. We should evaluate whether switching to msgspec.Struct offers nontrivial performance improvements.

I would say the main two relevant measures would be:

  1. CLI responsiveness. If importing is slow the CLI will feel sluggish, even if we're talking a one-time cost of a couple hundred ms.
  2. Total runtime on a large dataset. 5-10% speedup is probably worth it. <5% if the code becomes simpler to read.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions