Skip to content

Bug about dynamicCommander and unit_attributes_generic #5827

Description

@XNTEABDSC

Currently damage and range buff from unit_attributes_generic.lua is not applied on commander because:

unit_attributes_generic UpdateWeapons calls rangeUpdater at the end, which is RangeUpdate for commander.

At scripts/dynamicCommander.lua RangeUpdate, its actually weapon def range + module range bonus(fixed 25elmo per range module) * range buff from attributes. (only module range bonus is multiplied by attribute range buff)

And damage buff from unit_attributes_generic is later overrided by UpdateWeapons called by RangeUpdate.

We need further fix about commanders script at zk.

(I just read code but not precisely tested, but im sure its not working at Relic-K)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions