From 56c38ab9cba8262f00b244c0a7f91b34785fd5e1 Mon Sep 17 00:00:00 2001 From: Thang Nguyen Date: Fri, 13 Nov 2026 15:28:36 +0700 Subject: [PATCH 1/3] fix(port-forward): confirm before deleting a rule --- app/lib/widgets/port_forwarding_screen.dart | 8 ++++++++ .../widgets/port_forwarding_screen_test.dart | 19 +++++++++++++++++++ 2 files changed, 27 insertions(+) diff --git a/app/lib/widgets/port_forwarding_screen.dart b/app/lib/widgets/port_forwarding_screen.dart index 4704e23b..56567cc1 100644 --- a/app/lib/widgets/port_forwarding_screen.dart +++ b/app/lib/widgets/port_forwarding_screen.dart @@ -174,6 +174,14 @@ class _ForwardTileState extends State<_ForwardTile> { } Future _delete() async { + final ok = await showYsConfirm( + context, + title: 'Delete rule?', + message: '${widget.forward.label} (${widget.forward.summary})', + confirmLabel: 'Delete', + destructive: true, + ); + if (!ok || !mounted) return; final service = context.read(); final provider = context.read(); await service.stop(widget.forward.id); diff --git a/app/test/widgets/port_forwarding_screen_test.dart b/app/test/widgets/port_forwarding_screen_test.dart index 772cd7cb..29e76607 100644 --- a/app/test/widgets/port_forwarding_screen_test.dart +++ b/app/test/widgets/port_forwarding_screen_test.dart @@ -210,6 +210,19 @@ void main() { await tester.tap(find.text('Delete')); await tester.pumpAndSettle(); + // Confirmation first: nothing is removed until Delete is confirmed. + expect(find.text('Delete rule?'), findsOneWidget); + expect(provider.forwards, hasLength(1)); + await tester.tap(find.widgetWithText(FButton, 'Cancel')); + await tester.pumpAndSettle(); + expect(provider.forwards, hasLength(1)); + expect(lastService.stopped, isEmpty); + + await rightClick(tester, find.text('delete via menu')); + await tester.tap(find.text('Delete')); + await tester.pumpAndSettle(); + await tester.tap(find.widgetWithText(FButton, 'Delete')); + await tester.pumpAndSettle(); expect(provider.forwards, isEmpty); }); @@ -246,6 +259,9 @@ void main() { await hover(tester, find.text('tile buttons')); await tester.tap(find.byTooltip('Delete')); await tester.pumpAndSettle(); + expect(find.text('Delete rule?'), findsOneWidget); + await tester.tap(find.widgetWithText(FButton, 'Delete')); + await tester.pumpAndSettle(); expect(provider.forwards, isEmpty); expect(lastService.stopped, hasLength(2)); }); @@ -478,6 +494,9 @@ void main() { expect(focusedTooltip(), 'Delete'); await tester.sendKeyEvent(LogicalKeyboardKey.enter); await tester.pumpAndSettle(); + expect(find.text('Delete rule?'), findsOneWidget); + await tester.tap(find.widgetWithText(FButton, 'Delete')); + await tester.pumpAndSettle(); expect(provider.forwards, isEmpty); }); } From 3608cc645064ced8861b0e2b713879bf0542be0b Mon Sep 17 00:00:00 2001 From: Thang Nguyen Date: Fri, 13 Nov 2026 15:28:36 +0700 Subject: [PATCH 2/3] fix(share): state that sessions are end-to-end encrypted with the share code --- app/lib/widgets/share_session_dialog.dart | 2 +- app/test/widgets/share_dialogs_test.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/lib/widgets/share_session_dialog.dart b/app/lib/widgets/share_session_dialog.dart index 990741f1..e3d8e532 100644 --- a/app/lib/widgets/share_session_dialog.dart +++ b/app/lib/widgets/share_session_dialog.dart @@ -63,7 +63,7 @@ class _StartSharingView extends StatelessWidget { ), const SizedBox(height: YsSpace.s1), const Text( - 'Shared over TLS via your Supabase project.', + 'End-to-end encrypted with the share code.', style: TextStyle(color: YsColors.off, fontSize: 11), ), const SizedBox(height: YsSpace.s5 - 4), diff --git a/app/test/widgets/share_dialogs_test.dart b/app/test/widgets/share_dialogs_test.dart index 6a1b980c..1bba4921 100644 --- a/app/test/widgets/share_dialogs_test.dart +++ b/app/test/widgets/share_dialogs_test.dart @@ -142,7 +142,7 @@ void main() { findsOneWidget, ); expect( - find.text('Shared over TLS via your Supabase project.'), + find.text('End-to-end encrypted with the share code.'), findsOneWidget, ); From 228e49e92d166c5a21142e175eab7e857ae96739 Mon Sep 17 00:00:00 2001 From: Thang Nguyen Date: Fri, 13 Nov 2026 15:28:36 +0700 Subject: [PATCH 3/3] docs(readme): macOS builds are notarized, link user docs, describe share encryption --- README.md | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index 57276c39..cfba6d26 100644 --- a/README.md +++ b/README.md @@ -19,9 +19,9 @@ A professional, open-source SSH client for **macOS**, **Windows**, and **Linux** ## Download -Get the latest release from the [Releases page](https://github.com/YoursshLabs/yourssh/releases). +Get the latest release from the [Releases page](https://github.com/YoursshLabs/yourssh/releases). User documentation: [YoursshLabs/docs](https://github.com/YoursshLabs/docs). -YourSSH also checks for new releases on launch and from **Settings → Updates**; when a newer version is available it shows a banner and can download the right build for your OS and open the installer for you. Because the app is not code-signed, this is an assisted flow (it never silently replaces itself); if no matching build exists for your platform it opens the Releases page instead. +YourSSH also checks for new releases on launch and from **Settings → Updates**; when a newer version is available it shows a banner and can download the right build for your OS and open the installer for you. Because the installers are not silently swapped in, this is an assisted flow (it never silently replaces itself); if no matching build exists for your platform it opens the Releases page instead. | Platform | File | |---|---| @@ -34,17 +34,9 @@ YourSSH also checks for new releases on launch and from **Settings → Updates** ### macOS — First Launch -macOS may block the app on first open because it is not yet notarized with Apple. To open it: +The DMG and zip are signed with an Apple Developer ID and notarized + stapled by Apple, so YourSSH opens normally: drag it to **Applications** and launch it. -1. **Right-click** (or Control-click) the app → **Open** -2. Click **Open** in the dialog that appears - -You only need to do this once. After that, the app opens normally. - -Alternatively, run this in Terminal: -```bash -xattr -dr com.apple.quarantine /Applications/YourSSH.app -``` +> Building from source, or using an unsigned fork? macOS may block the app on first open. Right-click the app → **Open**, or run `xattr -dr com.apple.quarantine /Applications/YourSSH.app`. ### Windows — Installation @@ -81,7 +73,7 @@ sudo dpkg -r yourssh - **In-app RDP client** — connect to Windows, xrdp, and any RDP-compatible server directly from a tab alongside your SSH sessions; supports NLA, TLS, and auto security modes; optional SSH tunnel via a saved jump host; server-certificate TOFU with pre-auth pin enforcement (a changed certificate aborts before your credentials are sent); **fullscreen mode** with an mstsc-style hover bar at the top edge; full keyboard and mouse support (including Ctrl+Alt+Del); bidirectional clipboard; RDP tabs excluded from terminal-only features (recording, split view, input bar, snippets) - **In-app VNC client** — connect to Linux VNC servers (TigerVNC, x11vnc, TightVNC) as first-class tabs too; RFB with None / VNC-password auth, framebuffer rendering, full mouse + keyboard, bidirectional clipboard, server-driven auto-resize, optional SSH tunnel through a saved jump host, and the same fullscreen hover-bar UX as RDP - **Multi-tab SSH sessions** with named tabs, per-tab connection state, distro icons (detected via `/etc/os-release`), and middle-click to close -- **Terminal sharing (multiplayer)** — share a live SSH session with a session code; guests join via the Command Palette and watch or interact in real time; built on Supabase Realtime +- **Terminal sharing (multiplayer)** — share a live SSH session with a session code; guests join via the Command Palette and watch or interact in real time; built on Supabase Realtime; every message is end-to-end encrypted (AES-256-GCM) with a key derived from the share code - **Split terminal view** — horizontal/vertical pane splitting within a session - **Search-in-scrollback (Cmd/Ctrl+F)** — regex-powered search across the full terminal buffer; highlights all matches, navigate with Enter / Shift+Enter - **Copy & paste that just works** — `Ctrl+C` copies when text is selected and stays SIGINT otherwise (Windows Terminal behavior); `Cmd+C/V` on macOS, `Ctrl(+Shift)+V` to paste, right-click Copy/Paste/Select All menu, and middle-click paste