From 51dd40df2ae725ef819a07c0bfe30c3fc4c3bd12 Mon Sep 17 00:00:00 2001 From: Sergio Prada Date: Thu, 15 Oct 2026 09:57:36 -0400 Subject: [PATCH 1/2] switched from hardcoded refs to the split system, netstandard and mscorlib; guaranteeing compatibility with .NET 10 and backwards --- .../Tests/Editor/AndroidLogcatNetTests.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/com.unity.mobile.android-logcat/Tests/Editor/AndroidLogcatNetTests.cs b/com.unity.mobile.android-logcat/Tests/Editor/AndroidLogcatNetTests.cs index 23f796d7..f4ad66ac 100644 --- a/com.unity.mobile.android-logcat/Tests/Editor/AndroidLogcatNetTests.cs +++ b/com.unity.mobile.android-logcat/Tests/Editor/AndroidLogcatNetTests.cs @@ -35,17 +35,16 @@ public void ValidateAssemblyReferences() { var logcatAssembly = GetLogcatAssembly(); + static bool IsFrameworkReference(string name) => + name == "mscorlib" || name == "netstandard" || name == "System" || name.StartsWith("System.", StringComparison.Ordinal); + var expectedReferences = new List(new[] { - "mscorlib", - "System", - "System.Xml.Linq", "UnityEngine.IMGUIModule", "UnityEngine.CoreModule", "UnityEngine.VideoModule", "UnityEngine.TextRenderingModule", "UnityEngine.UIElementsModule", - "System.Core", "UnityEngine.ImageConversionModule", "UnityEngine.JSONSerializeModule", "UnityEditor.CoreModule" @@ -79,7 +78,7 @@ public void ValidateAssemblyReferences() var references = typeof(AndroidLogcatConsoleWindow).Assembly.GetReferencedAssemblies().Select(a => a.Name); var errors = new StringBuilder(); Console.WriteLine($"Logcat package references:\n{string.Join("\n", references)}"); - foreach (var r in references) + foreach (var r in references.Where(n => !IsFrameworkReference(n))) { if (!expectedReferences.Contains(r)) errors.AppendLine($"Unexpected reference '{r}'"); From 4da8888a57fdd2b0c0ad7f4db10251ac805f6097 Mon Sep 17 00:00:00 2001 From: Sergio Prada Date: Thu, 15 Oct 2026 12:37:14 -0400 Subject: [PATCH 2/2] remove trailing whitespace in AndroidLogcatNetTests --- .../Tests/Editor/AndroidLogcatNetTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/com.unity.mobile.android-logcat/Tests/Editor/AndroidLogcatNetTests.cs b/com.unity.mobile.android-logcat/Tests/Editor/AndroidLogcatNetTests.cs index f4ad66ac..d4575e8c 100644 --- a/com.unity.mobile.android-logcat/Tests/Editor/AndroidLogcatNetTests.cs +++ b/com.unity.mobile.android-logcat/Tests/Editor/AndroidLogcatNetTests.cs @@ -35,9 +35,9 @@ public void ValidateAssemblyReferences() { var logcatAssembly = GetLogcatAssembly(); - static bool IsFrameworkReference(string name) => + static bool IsFrameworkReference(string name) => name == "mscorlib" || name == "netstandard" || name == "System" || name.StartsWith("System.", StringComparison.Ordinal); - + var expectedReferences = new List(new[] { "UnityEngine.IMGUIModule",