Skip to content

gson.getDelegateAdapter is buggy. #48

Description

@tohidemyname

TitleDb calls gson 2.10.1. In this version, gson.getDelegateAdapter() has a code hack:

public <T> TypeAdapter<T> getDelegateAdapter(TypeAdapterFactory skipPast, TypeToken<T> type) { // Hack. If the skipPast factory isn't registered, assume the factory is being requested via // our @JsonAdapter annotation. if (!factories.contains(skipPast)) {

The code hack triggers a bug. Please see Fix Gson.getDelegateAdapter not working properly for JsonAdapter #2435
google/gson#2435

Please check its revison:

google/gson@9e77d39

TitleDB calls this API in hundreds of locations. Please update gson to avoid this bug.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions